From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH 2/2] OMAP2/3 GPTIMER: skip unnecessary TLDR write during
	non-autoreload
Date: Wed, 26 Nov 2008 10:49:59 -0800
Message-ID: <20081126184958.GW11997@atomide.com>
References: <20081014172417.5459.36601.stgit@localhost.localdomain> <20081014172745.5459.1893.stgit@localhost.localdomain> <13B9B4C6EF24D648824FF11BE89671620365C448AB@dlee02.ent.ti.com> <20081121222232.GG4927@atomide.com> <13B9B4C6EF24D648824FF11BE8967162036CD41930@dlee02.ent.ti.com> <87r64yjpru.fsf@deeprootsystems.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <linux-omap-owner@vger.kernel.org>
Received: from mho-01-bos.mailhop.org ([63.208.196.178]:55728 "EHLO
	mho-01-bos.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752518AbYKZSuA (ORCPT
	<rfc822;linux-omap@vger.kernel.org>); Wed, 26 Nov 2008 13:50:00 -0500
Content-Disposition: inline
In-Reply-To: <87r64yjpru.fsf@deeprootsystems.com>
Sender: linux-omap-owner@vger.kernel.org
List-Id: linux-omap@vger.kernel.org
To: Kevin Hilman <khilman@deeprootsystems.com>
Cc: "Woodruff, Richard" <r-woodruff2@ti.com>, Paul Walmsley <paul@pwsan.com>, "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>

* Kevin Hilman <khilman@deeprootsystems.com> [081126 10:39]:
> "Woodruff, Richard" <r-woodruff2@ti.com> writes:
> 
> >> * Woodruff, Richard <r-woodruff2@ti.com> [081014 12:47]:
> >> > >       omap_dm_timer_write_reg(timer, OMAP_TIMER_COUNTER_REG, load);
> >> > > -     omap_dm_timer_write_reg(timer, OMAP_TIMER_LOAD_REG, load);
> >> > >       omap_dm_timer_write_reg(timer, OMAP_TIMER_CTRL_REG, l);
> >> > >  }
> >> >
> >> > I seem to recall there was a missed interrupt condition which this worked
> >> around.
> >> >
> >> > IIRC, the original code didn't bother with the load I added back as a work
> >> around as a way to get posted mode working.
> >>
> >> Well these seem to be working based on some quick timer tests.
> >> Pushing so we can verify it ;)
> >
> > This kind of change might be better tested on the PM branch.  It's
> > the kind of thing more likely to work with PM disabled.  Testing in
> > both is good, PM for many things is less forgiving...
> 
> I validated these patches on the PM branch.
> 
> I used cyclictest to test lots of timer reprogramming, and also tested
> in both RET-while-idle and OFF-while-idle for low frequency timer
> reprogramming.
> 
> Acked-by: Kevin Hilman <khilman@deeprootsystems.com>

Thanks for testing, pushing them to l-o today and adding to
omap2-upstream queue.

Regards,

Tony