public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] OMAP3: PM: readability fix for IVA2 DPLL autoidle
@ 2008-11-25 15:23 Kevin Hilman
  2008-11-25 17:07 ` Paul Walmsley
  0 siblings, 1 reply; 3+ messages in thread
From: Kevin Hilman @ 2008-11-25 15:23 UTC (permalink / raw)
  To: linux-omap

No functional change, just a readability fix.

The symbolic name of the shift value used in writing
CM_AUTOIDLE_PLL_IVA2 referred values in the CM_CLKSTCTRL_IVA2
register.  Fix this to use the AUTOIDLE fields.

Signed-off-by: Kevin Hilman <khilman@deeprootsystems.com>
---
 arch/arm/mach-omap2/pm34xx.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c
index 804b3ac..05de1f7 100644
--- a/arch/arm/mach-omap2/pm34xx.c
+++ b/arch/arm/mach-omap2/pm34xx.c
@@ -501,9 +501,8 @@ static void __init prcm_setup_regs(void)
 	 * Set all plls to autoidle. This is needed until autoidle is
 	 * enabled by clockfw
 	 */
-	cm_write_mod_reg(1 << OMAP3430_CLKTRCTRL_IVA2_SHIFT,
-			 OMAP3430_IVA2_MOD,
-			 CM_AUTOIDLE2);
+	cm_write_mod_reg(1 << OMAP3430_AUTO_IVA2_DPLL_SHIFT,
+			 OMAP3430_IVA2_MOD, CM_AUTOIDLE2);
 	cm_write_mod_reg(1 << OMAP3430_AUTO_MPU_DPLL_SHIFT,
 			 MPU_MOD,
 			 CM_AUTOIDLE2);
-- 
1.6.0.3


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] OMAP3: PM: readability fix for IVA2 DPLL autoidle
  2008-11-25 15:23 [PATCH] OMAP3: PM: readability fix for IVA2 DPLL autoidle Kevin Hilman
@ 2008-11-25 17:07 ` Paul Walmsley
  2008-11-26 19:31   ` Tony Lindgren
  0 siblings, 1 reply; 3+ messages in thread
From: Paul Walmsley @ 2008-11-25 17:07 UTC (permalink / raw)
  To: Kevin Hilman; +Cc: linux-omap

On Tue, 25 Nov 2008, Kevin Hilman wrote:

> No functional change, just a readability fix.
> 
> The symbolic name of the shift value used in writing
> CM_AUTOIDLE_PLL_IVA2 referred values in the CM_CLKSTCTRL_IVA2
> register.  Fix this to use the AUTOIDLE fields.
> 
> Signed-off-by: Kevin Hilman <khilman@deeprootsystems.com>

Acked-by: Paul Walmsley <paul@pwsan.com>


- Paul

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] OMAP3: PM: readability fix for IVA2 DPLL autoidle
  2008-11-25 17:07 ` Paul Walmsley
@ 2008-11-26 19:31   ` Tony Lindgren
  0 siblings, 0 replies; 3+ messages in thread
From: Tony Lindgren @ 2008-11-26 19:31 UTC (permalink / raw)
  To: Paul Walmsley; +Cc: Kevin Hilman, linux-omap

* Paul Walmsley <paul@booyaka.com> [081125 09:07]:
> On Tue, 25 Nov 2008, Kevin Hilman wrote:
> 
> > No functional change, just a readability fix.
> > 
> > The symbolic name of the shift value used in writing
> > CM_AUTOIDLE_PLL_IVA2 referred values in the CM_CLKSTCTRL_IVA2
> > register.  Fix this to use the AUTOIDLE fields.
> > 
> > Signed-off-by: Kevin Hilman <khilman@deeprootsystems.com>
> 
> Acked-by: Paul Walmsley <paul@pwsan.com>

Pushing today.

Tony

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2008-11-26 19:31 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-25 15:23 [PATCH] OMAP3: PM: readability fix for IVA2 DPLL autoidle Kevin Hilman
2008-11-25 17:07 ` Paul Walmsley
2008-11-26 19:31   ` Tony Lindgren

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox