public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] OMAP3: Fixes for suspend / resume GPIO wake-up handling
@ 2008-11-26 11:47 Tero Kristo
  2008-11-26 18:56 ` Kevin Hilman
  0 siblings, 1 reply; 3+ messages in thread
From: Tero Kristo @ 2008-11-26 11:47 UTC (permalink / raw)
  To: linux-omap

Signed-off-by: Tero Kristo <tero.kristo@nokia.com>
---
 arch/arm/plat-omap/gpio.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/plat-omap/gpio.c b/arch/arm/plat-omap/gpio.c
index f4ec3af..62349fd 100644
--- a/arch/arm/plat-omap/gpio.c
+++ b/arch/arm/plat-omap/gpio.c
@@ -1585,7 +1585,7 @@ static int omap_gpio_suspend(struct sys_device *dev, pm_message_t mesg)
 #endif
 #if defined(CONFIG_ARCH_OMAP24XX) || defined(CONFIG_ARCH_OMAP34XX)
 		case METHOD_GPIO_24XX:
-			wake_status = bank->base + OMAP24XX_GPIO_SETWKUENA;
+			wake_status = bank->base + OMAP24XX_GPIO_WAKE_EN;
 			wake_clear = bank->base + OMAP24XX_GPIO_CLEARWKUENA;
 			wake_set = bank->base + OMAP24XX_GPIO_SETWKUENA;
 			break;
@@ -1608,7 +1608,7 @@ static int omap_gpio_resume(struct sys_device *dev)
 {
 	int i;
 
-	if (!cpu_is_omap24xx() && !cpu_is_omap16xx())
+	if (!cpu_class_is_omap2() && !cpu_is_omap16xx())
 		return 0;
 
 	for (i = 0; i < gpio_bank_count; i++) {
-- 
1.5.4.3


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] OMAP3: Fixes for suspend / resume GPIO wake-up handling
  2008-11-26 11:47 [PATCH] OMAP3: Fixes for suspend / resume GPIO wake-up handling Tero Kristo
@ 2008-11-26 18:56 ` Kevin Hilman
  2008-11-26 22:37   ` Tony Lindgren
  0 siblings, 1 reply; 3+ messages in thread
From: Kevin Hilman @ 2008-11-26 18:56 UTC (permalink / raw)
  To: Tero Kristo; +Cc: linux-omap

Tero Kristo <tero.kristo@nokia.com> writes:

> Signed-off-by: Tero Kristo <tero.kristo@nokia.com>
> ---
>  arch/arm/plat-omap/gpio.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)

Thanks, I'll pull this into the next PM branch, and this
can go straight into linux-omap.

Signed-off-by: Kevin Hilman <khilman@deeprootsystems.com>

> diff --git a/arch/arm/plat-omap/gpio.c b/arch/arm/plat-omap/gpio.c
> index f4ec3af..62349fd 100644
> --- a/arch/arm/plat-omap/gpio.c
> +++ b/arch/arm/plat-omap/gpio.c
> @@ -1585,7 +1585,7 @@ static int omap_gpio_suspend(struct sys_device *dev, pm_message_t mesg)
>  #endif
>  #if defined(CONFIG_ARCH_OMAP24XX) || defined(CONFIG_ARCH_OMAP34XX)
>  		case METHOD_GPIO_24XX:
> -			wake_status = bank->base + OMAP24XX_GPIO_SETWKUENA;
> +			wake_status = bank->base + OMAP24XX_GPIO_WAKE_EN;
>  			wake_clear = bank->base + OMAP24XX_GPIO_CLEARWKUENA;
>  			wake_set = bank->base + OMAP24XX_GPIO_SETWKUENA;
>  			break;
> @@ -1608,7 +1608,7 @@ static int omap_gpio_resume(struct sys_device *dev)
>  {
>  	int i;
>  
> -	if (!cpu_is_omap24xx() && !cpu_is_omap16xx())
> +	if (!cpu_class_is_omap2() && !cpu_is_omap16xx())
>  		return 0;
>  
>  	for (i = 0; i < gpio_bank_count; i++) {
> -- 
> 1.5.4.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] OMAP3: Fixes for suspend / resume GPIO wake-up handling
  2008-11-26 18:56 ` Kevin Hilman
@ 2008-11-26 22:37   ` Tony Lindgren
  0 siblings, 0 replies; 3+ messages in thread
From: Tony Lindgren @ 2008-11-26 22:37 UTC (permalink / raw)
  To: Kevin Hilman; +Cc: Tero Kristo, linux-omap

* Kevin Hilman <khilman@deeprootsystems.com> [081126 10:56]:
> Tero Kristo <tero.kristo@nokia.com> writes:
> 
> > Signed-off-by: Tero Kristo <tero.kristo@nokia.com>
> > ---
> >  arch/arm/plat-omap/gpio.c |    4 ++--
> >  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> Thanks, I'll pull this into the next PM branch, and this
> can go straight into linux-omap.
>
> Signed-off-by: Kevin Hilman <khilman@deeprootsystems.com>

Pushing to l-o and adding to omap-fixes queue.

Tony


> > diff --git a/arch/arm/plat-omap/gpio.c b/arch/arm/plat-omap/gpio.c
> > index f4ec3af..62349fd 100644
> > --- a/arch/arm/plat-omap/gpio.c
> > +++ b/arch/arm/plat-omap/gpio.c
> > @@ -1585,7 +1585,7 @@ static int omap_gpio_suspend(struct sys_device *dev, pm_message_t mesg)
> >  #endif
> >  #if defined(CONFIG_ARCH_OMAP24XX) || defined(CONFIG_ARCH_OMAP34XX)
> >  		case METHOD_GPIO_24XX:
> > -			wake_status = bank->base + OMAP24XX_GPIO_SETWKUENA;
> > +			wake_status = bank->base + OMAP24XX_GPIO_WAKE_EN;
> >  			wake_clear = bank->base + OMAP24XX_GPIO_CLEARWKUENA;
> >  			wake_set = bank->base + OMAP24XX_GPIO_SETWKUENA;
> >  			break;
> > @@ -1608,7 +1608,7 @@ static int omap_gpio_resume(struct sys_device *dev)
> >  {
> >  	int i;
> >  
> > -	if (!cpu_is_omap24xx() && !cpu_is_omap16xx())
> > +	if (!cpu_class_is_omap2() && !cpu_is_omap16xx())
> >  		return 0;
> >  
> >  	for (i = 0; i < gpio_bank_count; i++) {
> > -- 
> > 1.5.4.3
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2008-11-26 22:37 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-26 11:47 [PATCH] OMAP3: Fixes for suspend / resume GPIO wake-up handling Tero Kristo
2008-11-26 18:56 ` Kevin Hilman
2008-11-26 22:37   ` Tony Lindgren

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox