From: David Brownell <david-b@pacbell.net>
To: Manikandan Pillai <mani.pillai@ti.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH 3/3] musb: Remvoing twl4030 dependency for OMAP3EVM MUSB
Date: Thu, 27 Nov 2008 23:02:43 -0800 [thread overview]
Message-ID: <200811272302.43295.david-b@pacbell.net> (raw)
In-Reply-To: <1227850104-16166-1-git-send-email-mani.pillai@ti.com>
On Thursday 27 November 2008, Manikandan Pillai wrote:
> #if defined(CONFIG_ARCH_OMAP2430)
> omap_cfg_reg(AE5_2430_USB0HS_STP);
> + x = otg_get_transceiver();
> +#elif defined(CONFIG_MACH_OMAP3EVM)
> + x = kzalloc(sizeof *x, GFP_KERNEL);
> + if (!x)
> + return 0;
> + x->set_host = omap3_evm_otg_set_host;
> + x->set_peripheral = omap3_evm_otg_set_peripheral;
> + x->set_suspend = omap3_evm_otg_set_suspend;
> + otg_set_transceiver(x);
> #endif
This is obviously wrong. One does set_transceiver(),
the other does get_transceiver() ...
It seems that some boards need some kind of basic
OTG transceiver stub. The newish drivers/usb/otg
directory is the place to keep such stuff.
- Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2008-11-28 7:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-28 5:28 [PATCH 3/3] musb: Remvoing twl4030 dependency for OMAP3EVM MUSB Manikandan Pillai
2008-11-28 6:46 ` Felipe Balbi
2008-11-28 6:51 ` Gupta, Ajay Kumar
2008-11-28 7:08 ` Felipe Balbi
2008-11-28 7:02 ` David Brownell [this message]
2008-11-28 7:58 ` Gupta, Ajay Kumar
2008-11-28 17:25 ` David Brownell
2008-11-28 17:59 ` Felipe Balbi
2008-11-28 18:37 ` David Brownell
2008-11-28 19:43 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200811272302.43295.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=linux-omap@vger.kernel.org \
--cc=mani.pillai@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox