Re: [PATCH 1/3] Adding-support-framework for PR785 board.

[Felipe Balbi <me@felipebalbi.com>]

On Fri, Nov 28, 2008 at 11:11:29AM +0100, Koen Kooi wrote:
>> Yes... you should for example:
>>
>> static struct i2c_board_info omap3evm_i2c_board_info[] __initdata = {
>> ... (all devices but tps and twl) ...
>> };
>>
>> static struct i2c_board_info pr785_i2c_board_info[] __initdata = {
>> 	{
>> 		I2C_BOARD_INFO("tps62352_core_pwr", 0x4A),
>> 		.flags = I2C_CLIENT_WAKE,
>> 	}, {
>> 		I2C_BOARD_INFO("tps62353_mpu_pwr", 0x48),
>> 		.flags = I2C_CLIENT_WAKE,
>> 	},
>> };
>>
>> static struct i2c_board_info twl4030_i2c_board_info[] __initdata = {
>> 	{
>> 		I2C_BOARD_INFO("twl4030", 0x48),
>> 	},
>> };
>>
>> Then on init:
>>
>> ...
>>
>> omap_register_i2c_bus(1, omap3_evm_i2c_board_info,
>> 		ARRAY_SIZE(omap3evm_i2c_board_info);
>>
>> if (machine_is_pr785())
>> 	i2c_register_board_info(1, pr785_i2c_board_info,
>> 		ARRAY_SIZE(pr785_i2c_board_info));
>
> That's looks like unreachable code to me, since the pr785 is a  
> daughterboard of the omap3evm machine.

Hmm... that's news to me. But make it runtime check somehow. We can't
accept this kind of ifdefs in the i2c_board_info since it breaks multiomap.

And Tony has been pushing for it for quite a while, so let's not make
his life more difficult.

-- 
balbi