From: David Brownell <david-b@pacbell.net>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Linux and Kernel Video <video4linux-list@redhat.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"davinci-linux-open-source@linux.davincidsp.com"
<davinci-linux-open-source@linux.davincidsp.com>,
linux-kernel@vger.kernel.org,
Laurent Pinchart <laurent.pinchart@skynet.be>
Subject: Re: [PATCH v2] v4l2_device/v4l2_subdev: final (?) version
Date: Sat, 29 Nov 2008 18:56:51 -0800 [thread overview]
Message-ID: <200811291856.51900.david-b@pacbell.net> (raw)
In-Reply-To: <200811300006.22080.hverkuil@xs4all.nl>
On Saturday 29 November 2008, Hans Verkuil wrote:
> > > Are there some documented guidelines on when to use BUG_ON?
> >
> > Maybe there should be. I know I've seen flames from Linus on
> > the topic. Basically, treat it like a panic() where the system
> > must stop operation lest it catch fire or scribble all over the
> > (not-backed-up) disk ... if the system can keep running sanely,
> > then BUG() and friends are inappropriate.
>
> I think it would be good to have some document about this, since
> from what I've seen from a quick scan I'm not the only one who uses
> it incorrectly. There is no documentation in the asm-generic/bug.h
> header and there is also no documentation on this in the Documentation
> directory.
Fair enough ... but the basic advice is still going to be "strongly
avoid ever calling BUG()".
I'll send a patch along doing that.
- Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2008-11-30 2:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-29 17:52 [PATCH v2] v4l2_device/v4l2_subdev: final (?) version Hans Verkuil
2008-11-29 20:20 ` David Brownell
2008-11-29 21:46 ` Hans Verkuil
2008-11-29 22:22 ` David Brownell
2008-11-29 23:06 ` Hans Verkuil
2008-11-30 2:56 ` David Brownell [this message]
2008-11-29 23:31 ` Andy Walls
2008-11-30 0:40 ` Hans Verkuil
2008-11-30 2:49 ` Andy Walls
2008-11-30 10:52 ` Hans Verkuil
2008-12-01 5:34 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200811291856.51900.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=hverkuil@xs4all.nl \
--cc=laurent.pinchart@skynet.be \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox