[PATCH 0/1] Save sram context after changing MPU, DSP or core clocks

[PATCH 0/1] Save sram context after changing MPU, DSP or core clocks

[Peter 'p2' De Schrijver]

This patch saves the sram context again after a MPU,DSP or core clock
frequency change. This is necessary so the rom code can restore the correct
DPLL settings when resuming from off mode. Thanks to Rajendra Nayak for
suggesting the problem and coming up with the same fix at about the same time.

Peter 'p2' De Schrijver (1):
  Save sram context after changing MPU, DSP or core clocks

 arch/arm/mach-omap2/clock34xx.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

[PATCH 1/1] Save sram context after changing MPU, DSP or core clocks

[Peter 'p2' De Schrijver]

Signed-off-by: Peter 'p2' De Schrijver <peter.de-schrijver@nokia.com>
---
 arch/arm/mach-omap2/clock34xx.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-omap2/clock34xx.c b/arch/arm/mach-omap2/clock34xx.c
index d97d5a9..962ce56 100644
--- a/arch/arm/mach-omap2/clock34xx.c
+++ b/arch/arm/mach-omap2/clock34xx.c
@@ -911,6 +911,9 @@ printk("%s set to %luHz intended rate %luHz\n",dpll2_clk->name,clk_get_rate(dpll
 		clk_set_rate(dpll3_clk, prcm_vdd->rate);
 		curr_vdd2_prcm_set = prcm_vdd;
 	}
+
+	omap3_save_scratchpad_contents();
+
 	return 0;
 }
 
-- 
1.5.6.3

Re: [PATCH 0/1] Save sram context after changing MPU, DSP or core clocks

[Kevin Hilman]

"Peter 'p2' De Schrijver" <peter.de-schrijver@nokia.com> writes:

> This patch saves the sram context again after a MPU,DSP or core clock
> frequency change. This is necessary so the rom code can restore the correct
> DPLL settings when resuming from off mode. Thanks to Rajendra Nayak for
> suggesting the problem and coming up with the same fix at about the same time.
>

Thanks, pulling into next PM branch.

Kevin

RE: [PATCH 1/1] Save sram context after changing MPU, DSP or core clocks

[Tero.Kristo]

Hi Peter,

This patch causes linker error without CONFIG_PM option, should add
#ifdef:s around the call to omap3_save_scratchpad_contents();

-Tero

>-----Original Message-----
>From: linux-omap-owner@vger.kernel.org 
>[mailto:linux-omap-owner@vger.kernel.org] On Behalf Of ext 
>Peter 'p2' De Schrijver
>Sent: 19 November, 2008 13:45
>To: linux-omap@vger.kernel.org
>Cc: De-Schrijver Peter (Nokia-D/Helsinki)
>Subject: [PATCH 1/1] Save sram context after changing MPU, DSP 
>or core clocks
>
>
>Signed-off-by: Peter 'p2' De Schrijver <peter.de-schrijver@nokia.com>
>---
> arch/arm/mach-omap2/clock34xx.c |    3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
>diff --git a/arch/arm/mach-omap2/clock34xx.c 
>b/arch/arm/mach-omap2/clock34xx.c index d97d5a9..962ce56 100644
>--- a/arch/arm/mach-omap2/clock34xx.c
>+++ b/arch/arm/mach-omap2/clock34xx.c
>@@ -911,6 +911,9 @@ printk("%s set to %luHz intended rate 
>%luHz\n",dpll2_clk->name,clk_get_rate(dpll
> 		clk_set_rate(dpll3_clk, prcm_vdd->rate);
> 		curr_vdd2_prcm_set = prcm_vdd;
> 	}
>+
>+	omap3_save_scratchpad_contents();
>+
> 	return 0;
> }
> 
>--
>1.5.6.3
>
>--
>To unsubscribe from this list: send the line "unsubscribe 
>linux-omap" in the body of a message to 
>majordomo@vger.kernel.org More majordomo info at  
>http://vger.kernel.org/majordomo-info.html
>

Re: [PATCH 1/1] Save sram context after changing MPU, DSP or core clocks

[Peter 'p2' De Schrijver]

On Fri, Dec 05, 2008 at 11:49:03AM +0200, Kristo Tero (Nokia-D/Tampere) wrote:
> Hi Peter,
> 
> This patch causes linker error without CONFIG_PM option, should add
> #ifdef:s around the call to omap3_save_scratchpad_contents();
> 

That looks a bit ugly though :(

Cheers,

Peter

-- 
goa is a state of mind