From: Felipe Balbi <me@felipebalbi.com>
To: Tony Lindgren <tony@atomide.com>
Cc: "Aguirre Rodriguez, Sergio Alberto" <saaguirre@ti.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"video4linux-list@redhat.com" <video4linux-list@redhat.com>,
Sakari Ailus <sakari.ailus@nokia.com>,
"Tuukka.O Toivonen" <tuukka.o.toivonen@nokia.com>,
"Hiremath, Vaibhav" <hvaibhav@ti.com>,
"Nagalla, Hari" <hnagalla@ti.com>
Subject: Re: [REVIEW PATCH 04/14] OMAP: CAM: Add ISP Front end
Date: Mon, 15 Dec 2008 19:24:32 +0200 [thread overview]
Message-ID: <20081215172432.GG23324@frodo> (raw)
In-Reply-To: <20081215161240.GQ10664@atomide.com>
On Mon, Dec 15, 2008 at 08:12:41AM -0800, Tony Lindgren wrote:
> You should not need cpu_is_omapXXXX() macros in the drivers. Please
> set up the configuration in platform_data.
>
> Also, please pass the IORESOURCE from platform_data, and then ioremap
> it in the driver. That way you can use __raw_read/write instead of
> __omap_read/write.
just one reminder. IORESOURCE_* goes via struct resource. Then you use
res = platform_get_resource(pdev, IORESOURCE_MEM, 0); and ioremap()
afterwards.
Similar should be done for the IRQ, but using IORESOURCE_IRQ and
platform_get_irq(pdev, 0);
--
balbi
next prev parent reply other threads:[~2008-12-15 17:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-11 20:37 [REVIEW PATCH 04/14] OMAP: CAM: Add ISP Front end Aguirre Rodriguez, Sergio Alberto
2008-12-15 16:12 ` Tony Lindgren
2008-12-15 17:24 ` Felipe Balbi [this message]
2008-12-16 16:20 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081215172432.GG23324@frodo \
--to=me@felipebalbi.com \
--cc=hnagalla@ti.com \
--cc=hvaibhav@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=saaguirre@ti.com \
--cc=sakari.ailus@nokia.com \
--cc=tony@atomide.com \
--cc=tuukka.o.toivonen@nokia.com \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox