From: Tony Lindgren <tony@atomide.com>
To: "Aguirre Rodriguez, Sergio Alberto" <saaguirre@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"video4linux-list@redhat.com" <video4linux-list@redhat.com>,
Sakari Ailus <sakari.ailus@nokia.com>,
"Tuukka.O Toivonen" <tuukka.o.toivonen@nokia.com>,
"Hiremath, Vaibhav" <hvaibhav@ti.com>,
"Nagalla, Hari" <hnagalla@ti.com>
Subject: Re: [REVIEW PATCH 14/14] OMAP34XX: CAM: Add Sensors Support
Date: Mon, 15 Dec 2008 09:56:45 -0800 [thread overview]
Message-ID: <20081215175644.GW10664@atomide.com> (raw)
In-Reply-To: <A24693684029E5489D1D202277BE894415F3DAEB@dlee02.ent.ti.com>
* Aguirre Rodriguez, Sergio Alberto <saaguirre@ti.com> [081215 09:02]:
> > From: Tony Lindgren [mailto:tony@atomide.com]
> > * Aguirre Rodriguez, Sergio Alberto <saaguirre@ti.com> [081211 12:44]:
> > > + case V4L2_POWER_OFF:
> > > + /* Power Down Sequence */
> > > +#ifdef CONFIG_TWL4030_CORE
> > > + twl4030_i2c_write_u8(TWL4030_MODULE_PM_RECEIVER,
> > > + VAUX_DEV_GRP_NONE, TWL4030_VAUX2_DEV_GRP);
> > > +#else
> > > +#error "no power companion board defined!"
> > > +#endif
> >
> > These checks look unecessary. How about just handle it with Kconfig?
> >
> [Aguirre, Sergio] But how? Don't you think that if I do that, I'll tighten the sensor driver to this board only?
>
See what we've done with arch/arm/mach-omap2/mmc-twl4030.c for example
in linux-omap tree. The twl and mmc patches are on their way to the mainline
kernel too hopfully this merge window.
Regards,
Tony
next prev parent reply other threads:[~2008-12-15 17:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-11 20:38 [REVIEW PATCH 14/14] OMAP34XX: CAM: Add Sensors Support Aguirre Rodriguez, Sergio Alberto
2008-12-15 16:23 ` Tony Lindgren
2008-12-15 17:02 ` Aguirre Rodriguez, Sergio Alberto
2008-12-15 17:56 ` Tony Lindgren [this message]
2008-12-16 19:44 ` Aguirre Rodriguez, Sergio Alberto
2008-12-16 19:48 ` Aguirre Rodriguez, Sergio Alberto
2008-12-19 10:15 ` Hiremath, Vaibhav
-- strict thread matches above, loose matches on Subject: below --
2009-01-13 2:03 Aguirre Rodriguez, Sergio Alberto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081215175644.GW10664@atomide.com \
--to=tony@atomide.com \
--cc=hnagalla@ti.com \
--cc=hvaibhav@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=saaguirre@ti.com \
--cc=sakari.ailus@nokia.com \
--cc=tuukka.o.toivonen@nokia.com \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox