From: Felipe Balbi <me@felipebalbi.com>
To: "Pandita, Vikram" <vikram.pandita@ti.com>
Cc: "me@felipebalbi.com" <me@felipebalbi.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
linux-omap <linux-omap@vger.kernel.org>
Subject: Re: [PATCH v2] MUSB: fix wrongly created sysfs entry
Date: Mon, 15 Dec 2008 21:59:42 +0200 [thread overview]
Message-ID: <20081215195941.GA28753@frodo> (raw)
In-Reply-To: <FCCFB4CDC6E5564B9182F639FC356087025127B962@dbde02.ent.ti.com>
Hi,
On Tue, Dec 16, 2008 at 01:25:58AM +0530, Pandita, Vikram wrote:
> Agreed. In that case, we still need the following patch:
> Otherwise the srp entry does not get deleted on rmmod.
makes sense, can you just update one thing:
> Signed-off-by: Vikram Pandita <vikram.pandita@ti.com>
> diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
> index 5280dba..824ea57 100644
> --- a/drivers/usb/musb/musb_core.c
> +++ b/drivers/usb/musb/musb_core.c
> @@ -1829,7 +1829,7 @@ static void musb_free(struct musb *musb)
> #ifdef CONFIG_SYSFS
> device_remove_file(musb->controller, &dev_attr_mode);
> device_remove_file(musb->controller, &dev_attr_vbus);
> -#ifdef CONFIG_USB_MUSB_OTG
> +#ifdef CONFIG_USB_GADGET_MUSB_HDRC
> device_remove_file(musb->controller, &dev_attr_srp);
> #endif
> #endif
> @@ -2060,7 +2060,7 @@ bad_config:
> status = device_create_file(dev, &dev_attr_vbus);
> #ifdef CONFIG_USB_GADGET_MUSB_HDRC
> status = device_create_file(dev, &dev_attr_srp);
> -#endif /* CONFIG_USB_GADGET_MUSB_HDRC */
> +#endif
leave the comment there :-)
--
balbi
next prev parent reply other threads:[~2008-12-15 19:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1229272442.6775.3.camel@localhost.localdomain>
[not found] ` <49462232.10308@option.com>
[not found] ` <1229352834.12163.9.camel@localhost.localdomain>
[not found] ` <1229354799.22285.234.camel@violet>
[not found] ` <20081215154937.6e1bf0e1@lxorguk.ukuu.org.uk>
[not found] ` <1229356837.22285.239.camel@violet>
[not found] ` <1229357553.12163.55.camel@localhost.localdomain>
[not found] ` <20081215162505.4b11c9be@lxorguk.ukuu.org.uk>
[not found] ` <1229359592.12163.80.camel@localhost.localdomain>
[not found] ` <20081215171611.0b3877d5@lxorguk.ukuu.org.uk>
[not found] ` <1229362427.12163.94.camel@localhost.localdomain>
[not found] ` <1229363671.12163.109.camel@localhost.localdomain>
[not found] ` <20081215180740.02ef1667@lxorguk.ukuu.org.uk>
2008-12-15 19:19 ` [PATCH] MUSB: fix wrongly created sysfs entry Pandita, Vikram
[not found] ` <FCCFB4CDC6E5564B9182F639FC356087025127B95B-/tLxBxkBPtCIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2008-12-15 19:23 ` [PATCH v2] " Pandita, Vikram
2008-12-15 19:51 ` Felipe Balbi
2008-12-15 19:55 ` Pandita, Vikram
2008-12-15 19:59 ` Felipe Balbi [this message]
2008-12-15 20:05 ` [PATCH v3] MUSB: fix srp sysfs entry deletion Pandita, Vikram
2008-12-15 20:08 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081215195941.GA28753@frodo \
--to=me@felipebalbi.com \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=vikram.pandita@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox