From: Tony Lindgren <tony@atomide.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: Tomi Valkeinen <tomi.valkeinen@nokia.com>, linux-omap@vger.kernel.org
Subject: Re: [PATCH] OMAP: wait for pwrdm transition after clk_enable()
Date: Mon, 15 Dec 2008 14:47:18 -0800 [thread overview]
Message-ID: <20081215224717.GB19551@atomide.com> (raw)
In-Reply-To: <alpine.DEB.2.00.0812151536470.26754@utopia.booyaka.com>
* Paul Walmsley <paul@pwsan.com> [081215 14:37]:
> On Fri, 12 Dec 2008, Tomi Valkeinen wrote:
>
> > Enabling clock in a disabled power domain causes the power domain to be
> > turned on. However, the power transition is not always finished when
> > clk_enable() returns and this randomly crashes the kernel when an
> > interrupt happens right after the clk_enable, and the kernel tries to
> > read the irq status register for that domain.
> >
> > Why the irq status register is inaccessible, I don't know. Also it
> > doesn't seem to be related to the module being not powered up, but to
> > the transition itself.
> >
> > The same could perhaps happen after clk_disable also, but I have not
> > witnessed that.
> >
> > The problem affects at least dss, cam and sgx clocks.
> >
> > This change waits for the transition to be finished before returning
> > from omap2_clkdm_clk_enable().
> >
> > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@nokia.com>
>
> Acked-by: Paul Walmsley <paul@pwsan.com>
Pushing to l-o tree, and adding to omap-fixes queue for upstream.
Tony
prev parent reply other threads:[~2008-12-15 22:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-12 7:48 [PATCH] OMAP: wait for pwrdm transition after clk_enable() Tomi Valkeinen
2008-12-15 22:37 ` Paul Walmsley
2008-12-15 22:47 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081215224717.GB19551@atomide.com \
--to=tony@atomide.com \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=tomi.valkeinen@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox