From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH 1/1] OMAP3: DMA: Enable idlemodes for DMA OCP Date: Mon, 15 Dec 2008 16:07:42 -0800 Message-ID: <20081216000741.GD19551@atomide.com> References: <1228121725-14062-1-git-send-email-ext-kalle.jokiniemi@nokia.com> <1228121725-14062-2-git-send-email-ext-kalle.jokiniemi@nokia.com> <87zljgclj5.fsf@trdhcp146196.ntc.nokia.com> <1228128612.9951.555.camel@kj-ubuntu> <1228151015.9951.624.camel@kj-ubuntu> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mho-01-bos.mailhop.org ([63.208.196.178]:57409 "EHLO mho-01-bos.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753922AbYLPAHo (ORCPT ); Mon, 15 Dec 2008 19:07:44 -0500 Content-Disposition: inline In-Reply-To: <1228151015.9951.624.camel@kj-ubuntu> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Kalle Jokiniemi Cc: =?iso-8859-1?Q?H=F6gander?= Jouni , linux-omap@vger.kernel.org, khilman@deeprootsystems.com * Kalle Jokiniemi [081201 09:00]: > On ma, 2008-12-01 at 12:50 +0200, Kalle Jokiniemi wrote: > > On ma, 2008-12-01 at 11:06 +0200, H=F6gander Jouni wrote: > > > "ext Kalle Jokiniemi" writes: > > >=20 > > > > This patch enables MStandby smart-idle mode, autoidle smartidle= mode, > > > > and the autoidle bit for DMA4_OCP_SYSCONFIG. > > > > > > > > Signed-off-by: Kalle Jokiniemi > > > > --- > > > > arch/arm/plat-omap/dma.c | 13 +++++++++++++ > > > > arch/arm/plat-omap/include/mach/dma.h | 15 +++++++++++++++ > > > > 2 files changed, 28 insertions(+), 0 deletions(-) > > > > > > > > diff --git a/arch/arm/plat-omap/dma.c b/arch/arm/plat-omap/dma.= c > > > > index c4e5ba3..9d8d28c 100644 > > > > --- a/arch/arm/plat-omap/dma.c > > > > +++ b/arch/arm/plat-omap/dma.c > > > > @@ -2420,6 +2420,19 @@ static int __init omap_init_dma(void) > > > > if (cpu_class_is_omap2()) > > > > setup_irq(INT_24XX_SDMA_IRQ0, &omap24xx_dma_irq); > > > > =20 > > > > + /* Enable smartidle idlemodes and autoidle */ > > > > + if (cpu_is_omap34xx()) { > > >=20 > > > I think this can be done for omap2 also. > >=20 > > Probably true. If no other comments come today, I'll post a new pat= ch > > with this change. >=20 > Now that I re-checked, there is no SIDLEMODE for omap2. Also in omap2= , > setting MIDLEMODE to smartidle cannot be done if cam DMA is used. >=20 > So, I think the patch should be as it is, omap3 only. OK. Pushing to l-o tree and queuing for upstream. Regards, Tony >=20 > - Kalle >=20 > >=20 > > - Kalle > >=20 > > >=20 > > > > + u32 v =3D dma_read(OCP_SYSCONFIG); > > > > + v &=3D ~(DMA_SYSCONFIG_MIDLEMODE_MASK | > > > > + DMA_SYSCONFIG_SIDLEMODE_MASK | > > > > + DMA_SYSCONFIG_AUTOIDLE); > > > > + v |=3D (DMA_SYSCONFIG_MIDLEMODE(DMA_IDLEMODE_SMARTIDLE) | > > > > + DMA_SYSCONFIG_SIDLEMODE(DMA_IDLEMODE_SMARTIDLE) | > > > > + DMA_SYSCONFIG_AUTOIDLE); > > > > + dma_write(v , OCP_SYSCONFIG); > > > > + } > > > > + > > > > + > > > > /* FIXME: Update LCD DMA to work on 24xx */ > > > > if (cpu_class_is_omap1()) { > > > > r =3D request_irq(INT_DMA_LCD, lcd_dma_irq_handler, 0, > > > > diff --git a/arch/arm/plat-omap/include/mach/dma.h > > > > b/arch/arm/plat-omap/include/mach/dma.h > > >=20 -- To unsubscribe from this list: send the line "unsubscribe linux-omap" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html