* [PATCH 1/1] Default MUX configuration added - GPIO140-143, GPIO0 and GPIO9
@ 2008-12-16 5:31 Manikandan Pillai
2008-12-16 5:37 ` Pandita, Vikram
2009-01-08 12:06 ` Tony Lindgren
0 siblings, 2 replies; 5+ messages in thread
From: Manikandan Pillai @ 2008-12-16 5:31 UTC (permalink / raw)
To: linux-omap; +Cc: Manikandan Pillai
Default MUX configurations for GPIO on OMAP3 EVM boards are added.
Fixed for "_UP" naming convention for GPIOs comment.
Signed-off-by: Manikandan Pillai <mani.pillai@ti.com>
---
arch/arm/mach-omap2/mux.c | 13 +++++++++++++
arch/arm/plat-omap/include/mach/mux.h | 6 ++++++
2 files changed, 19 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2/mux.c b/arch/arm/mach-omap2/mux.c
index dacb41f..1556688 100644
--- a/arch/arm/mach-omap2/mux.c
+++ b/arch/arm/mach-omap2/mux.c
@@ -459,6 +459,19 @@ MUX_CFG_34XX("AH8_34XX_GPIO29", 0x5fa,
OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_INPUT)
MUX_CFG_34XX("J25_34XX_GPIO170", 0x1c6,
OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_INPUT)
+MUX_CFG_34XX("AF26_34XX_GPIO0", 0x1e0,
+ OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_OUTPUT)
+MUX_CFG_34XX("AF22_34XX_GPIO9", 0xa18,
+ OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_OUTPUT)
+MUX_CFG_34XX("AF6_34XX_GPIO140_UP", 0x16c,
+ OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_INPUT_PULLUP)
+MUX_CFG_34XX("AE6_34XX_GPIO141", 0x16e,
+ OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_OUTPUT)
+MUX_CFG_34XX("AF5_34XX_GPIO142", 0x170,
+ OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_OUTPUT)
+MUX_CFG_34XX("AE5_34XX_GPIO143", 0x172,
+ OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_OUTPUT)
+
};
#define OMAP34XX_PINS_SZ ARRAY_SIZE(omap34xx_pins)
diff --git a/arch/arm/plat-omap/include/mach/mux.h b/arch/arm/plat-omap/include/mach/mux.h
index f4362b8..67fddec 100644
--- a/arch/arm/plat-omap/include/mach/mux.h
+++ b/arch/arm/plat-omap/include/mach/mux.h
@@ -790,6 +790,12 @@ enum omap34xx_index {
*/
AH8_34XX_GPIO29,
J25_34XX_GPIO170,
+ AF26_34XX_GPIO0,
+ AF22_34XX_GPIO9,
+ AF6_34XX_GPIO140_UP,
+ AE6_34XX_GPIO141,
+ AF5_34XX_GPIO142,
+ AE5_34XX_GPIO143
};
struct omap_mux_cfg {
--
1.5.6
^ permalink raw reply related [flat|nested] 5+ messages in thread
* RE: [PATCH 1/1] Default MUX configuration added - GPIO140-143, GPIO0 and GPIO9
2008-12-16 5:31 [PATCH 1/1] Default MUX configuration added - GPIO140-143, GPIO0 and GPIO9 Manikandan Pillai
@ 2008-12-16 5:37 ` Pandita, Vikram
2008-12-16 10:24 ` Pillai, Manikandan
2009-01-08 12:06 ` Tony Lindgren
1 sibling, 1 reply; 5+ messages in thread
From: Pandita, Vikram @ 2008-12-16 5:37 UTC (permalink / raw)
To: Pillai, Manikandan, linux-omap@vger.kernel.org
>-----Original Message-----
>From: linux-omap-owner@vger.kernel.org [mailto:linux-omap-owner@vger.kernel.org] On Behalf Of Pillai,
>Manikandan
>Sent: Monday, December 15, 2008 11:31 PM
>To: linux-omap@vger.kernel.org
>Cc: Pillai, Manikandan
>Subject: [PATCH 1/1] Default MUX configuration added - GPIO140-143, GPIO0 and GPIO9
>
>Default MUX configurations for GPIO on OMAP3 EVM boards are added.
>Fixed for "_UP" naming convention for GPIOs comment.
Patch is fine but looks like
Mux framework seems to be not efficient.
"There is one GLOBAL table for all omap devices."
How maintainable is that?
Also care has to be taken to match the enum position with mux.c array location. This is error prone.
Mux tables should be per device basis.
Any thoughts.
>
>Signed-off-by: Manikandan Pillai <mani.pillai@ti.com>
>---
> arch/arm/mach-omap2/mux.c | 13 +++++++++++++
> arch/arm/plat-omap/include/mach/mux.h | 6 ++++++
> 2 files changed, 19 insertions(+), 0 deletions(-)
>
>diff --git a/arch/arm/mach-omap2/mux.c b/arch/arm/mach-omap2/mux.c
>index dacb41f..1556688 100644
>--- a/arch/arm/mach-omap2/mux.c
>+++ b/arch/arm/mach-omap2/mux.c
>@@ -459,6 +459,19 @@ MUX_CFG_34XX("AH8_34XX_GPIO29", 0x5fa,
> OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_INPUT)
> MUX_CFG_34XX("J25_34XX_GPIO170", 0x1c6,
> OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_INPUT)
>+MUX_CFG_34XX("AF26_34XX_GPIO0", 0x1e0,
>+ OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_OUTPUT)
>+MUX_CFG_34XX("AF22_34XX_GPIO9", 0xa18,
>+ OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_OUTPUT)
>+MUX_CFG_34XX("AF6_34XX_GPIO140_UP", 0x16c,
>+ OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_INPUT_PULLUP)
>+MUX_CFG_34XX("AE6_34XX_GPIO141", 0x16e,
>+ OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_OUTPUT)
>+MUX_CFG_34XX("AF5_34XX_GPIO142", 0x170,
>+ OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_OUTPUT)
>+MUX_CFG_34XX("AE5_34XX_GPIO143", 0x172,
>+ OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_OUTPUT)
>+
> };
>
> #define OMAP34XX_PINS_SZ ARRAY_SIZE(omap34xx_pins)
>diff --git a/arch/arm/plat-omap/include/mach/mux.h b/arch/arm/plat-omap/include/mach/mux.h
>index f4362b8..67fddec 100644
>--- a/arch/arm/plat-omap/include/mach/mux.h
>+++ b/arch/arm/plat-omap/include/mach/mux.h
>@@ -790,6 +790,12 @@ enum omap34xx_index {
> */
> AH8_34XX_GPIO29,
> J25_34XX_GPIO170,
>+ AF26_34XX_GPIO0,
>+ AF22_34XX_GPIO9,
>+ AF6_34XX_GPIO140_UP,
>+ AE6_34XX_GPIO141,
>+ AF5_34XX_GPIO142,
>+ AE5_34XX_GPIO143
> };
>
> struct omap_mux_cfg {
>--
>1.5.6
>
>--
>To unsubscribe from this list: send the line "unsubscribe linux-omap" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH 1/1] Default MUX configuration added - GPIO140-143, GPIO0 and GPIO9
2008-12-16 5:37 ` Pandita, Vikram
@ 2008-12-16 10:24 ` Pillai, Manikandan
2008-12-16 16:27 ` Tony Lindgren
0 siblings, 1 reply; 5+ messages in thread
From: Pillai, Manikandan @ 2008-12-16 10:24 UTC (permalink / raw)
To: Pandita, Vikram, linux-omap@vger.kernel.org
Hi Vikram,
Pls find my comments inlined.
-----Original Message-----
From: Pandita, Vikram
Sent: Tuesday, December 16, 2008 11:08 AM
To: Pillai, Manikandan; linux-omap@vger.kernel.org
Subject: RE: [PATCH 1/1] Default MUX configuration added - GPIO140-143, GPIO0 and GPIO9
>-----Original Message-----
>From: linux-omap-owner@vger.kernel.org [mailto:linux-omap-owner@vger.kernel.org] On Behalf Of Pillai,
>Manikandan
>Sent: Monday, December 15, 2008 11:31 PM
>To: linux-omap@vger.kernel.org
>Cc: Pillai, Manikandan
>Subject: [PATCH 1/1] Default MUX configuration added - GPIO140-143, GPIO0 and GPIO9
>
>Default MUX configurations for GPIO on OMAP3 EVM boards are added.
>Fixed for "_UP" naming convention for GPIOs comment.
Patch is fine but looks like
[Pillai, Manikandan] OK
Mux framework seems to be not efficient.
[Pillai, Manikandan] It's not efficient but I have just added the requirments for the new power board in the existing framework. Revamping the whole MUX logic
would be a good amount of work.
"There is one GLOBAL table for all omap devices."
How maintainable is that?
Also care has to be taken to match the enum position with mux.c array location. This is error prone.
Mux tables should be per device basis.
Any thoughts.
>
>Signed-off-by: Manikandan Pillai <mani.pillai@ti.com>
>---
> arch/arm/mach-omap2/mux.c | 13 +++++++++++++
> arch/arm/plat-omap/include/mach/mux.h | 6 ++++++
> 2 files changed, 19 insertions(+), 0 deletions(-)
>
>diff --git a/arch/arm/mach-omap2/mux.c b/arch/arm/mach-omap2/mux.c
>index dacb41f..1556688 100644
>--- a/arch/arm/mach-omap2/mux.c
>+++ b/arch/arm/mach-omap2/mux.c
>@@ -459,6 +459,19 @@ MUX_CFG_34XX("AH8_34XX_GPIO29", 0x5fa,
> OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_INPUT)
> MUX_CFG_34XX("J25_34XX_GPIO170", 0x1c6,
> OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_INPUT)
>+MUX_CFG_34XX("AF26_34XX_GPIO0", 0x1e0,
>+ OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_OUTPUT)
>+MUX_CFG_34XX("AF22_34XX_GPIO9", 0xa18,
>+ OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_OUTPUT)
>+MUX_CFG_34XX("AF6_34XX_GPIO140_UP", 0x16c,
>+ OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_INPUT_PULLUP)
>+MUX_CFG_34XX("AE6_34XX_GPIO141", 0x16e,
>+ OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_OUTPUT)
>+MUX_CFG_34XX("AF5_34XX_GPIO142", 0x170,
>+ OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_OUTPUT)
>+MUX_CFG_34XX("AE5_34XX_GPIO143", 0x172,
>+ OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_OUTPUT)
>+
> };
>
> #define OMAP34XX_PINS_SZ ARRAY_SIZE(omap34xx_pins)
>diff --git a/arch/arm/plat-omap/include/mach/mux.h b/arch/arm/plat-omap/include/mach/mux.h
>index f4362b8..67fddec 100644
>--- a/arch/arm/plat-omap/include/mach/mux.h
>+++ b/arch/arm/plat-omap/include/mach/mux.h
>@@ -790,6 +790,12 @@ enum omap34xx_index {
> */
> AH8_34XX_GPIO29,
> J25_34XX_GPIO170,
>+ AF26_34XX_GPIO0,
>+ AF22_34XX_GPIO9,
>+ AF6_34XX_GPIO140_UP,
>+ AE6_34XX_GPIO141,
>+ AF5_34XX_GPIO142,
>+ AE5_34XX_GPIO143
> };
>
> struct omap_mux_cfg {
>--
>1.5.6
>
>--
>To unsubscribe from this list: send the line "unsubscribe linux-omap" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] Default MUX configuration added - GPIO140-143, GPIO0 and GPIO9
2008-12-16 10:24 ` Pillai, Manikandan
@ 2008-12-16 16:27 ` Tony Lindgren
0 siblings, 0 replies; 5+ messages in thread
From: Tony Lindgren @ 2008-12-16 16:27 UTC (permalink / raw)
To: Pillai, Manikandan; +Cc: Pandita, Vikram, linux-omap@vger.kernel.org
* Pillai, Manikandan <mani.pillai@ti.com> [081216 02:24]:
> Hi Vikram,
>
> Pls find my comments inlined.
>
>
>
> -----Original Message-----
> From: Pandita, Vikram
> Sent: Tuesday, December 16, 2008 11:08 AM
> To: Pillai, Manikandan; linux-omap@vger.kernel.org
> Subject: RE: [PATCH 1/1] Default MUX configuration added - GPIO140-143, GPIO0 and GPIO9
>
>
> >-----Original Message-----
> >From: linux-omap-owner@vger.kernel.org [mailto:linux-omap-owner@vger.kernel.org] On Behalf Of Pillai,
> >Manikandan
> >Sent: Monday, December 15, 2008 11:31 PM
> >To: linux-omap@vger.kernel.org
> >Cc: Pillai, Manikandan
> >Subject: [PATCH 1/1] Default MUX configuration added - GPIO140-143, GPIO0 and GPIO9
> >
> >Default MUX configurations for GPIO on OMAP3 EVM boards are added.
> >Fixed for "_UP" naming convention for GPIOs comment.
>
> Patch is fine but looks like
> [Pillai, Manikandan] OK
> Mux framework seems to be not efficient.
> [Pillai, Manikandan] It's not efficient but I have just added the requirments for the new power board in the existing framework. Revamping the whole MUX logic
> would be a good amount of work.
>
> "There is one GLOBAL table for all omap devices."
> How maintainable is that?
> Also care has to be taken to match the enum position with mux.c array location. This is error prone.
>
> Mux tables should be per device basis.
> Any thoughts.
Yeah, well once we have the custom struct device, we should configure
the pins there. Some of the pins have multiple options and should be
configured in board-*.c files, but some devices have just one working
combination of pins.
So hopefully for most pins, by selecting the devices that the board has,
the devices would configure the pins for the board.
Regards,
Tony
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] Default MUX configuration added - GPIO140-143, GPIO0 and GPIO9
2008-12-16 5:31 [PATCH 1/1] Default MUX configuration added - GPIO140-143, GPIO0 and GPIO9 Manikandan Pillai
2008-12-16 5:37 ` Pandita, Vikram
@ 2009-01-08 12:06 ` Tony Lindgren
1 sibling, 0 replies; 5+ messages in thread
From: Tony Lindgren @ 2009-01-08 12:06 UTC (permalink / raw)
To: Manikandan Pillai; +Cc: linux-omap
* Manikandan Pillai <mani.pillai@ti.com> [081216 07:31]:
> Default MUX configurations for GPIO on OMAP3 EVM boards are added.
> Fixed for "_UP" naming convention for GPIOs comment.
Pushing to l-o tree, and adding to omap-upstream queue.
Tony
> Signed-off-by: Manikandan Pillai <mani.pillai@ti.com>
> ---
> arch/arm/mach-omap2/mux.c | 13 +++++++++++++
> arch/arm/plat-omap/include/mach/mux.h | 6 ++++++
> 2 files changed, 19 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/mux.c b/arch/arm/mach-omap2/mux.c
> index dacb41f..1556688 100644
> --- a/arch/arm/mach-omap2/mux.c
> +++ b/arch/arm/mach-omap2/mux.c
> @@ -459,6 +459,19 @@ MUX_CFG_34XX("AH8_34XX_GPIO29", 0x5fa,
> OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_INPUT)
> MUX_CFG_34XX("J25_34XX_GPIO170", 0x1c6,
> OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_INPUT)
> +MUX_CFG_34XX("AF26_34XX_GPIO0", 0x1e0,
> + OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_OUTPUT)
> +MUX_CFG_34XX("AF22_34XX_GPIO9", 0xa18,
> + OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_OUTPUT)
> +MUX_CFG_34XX("AF6_34XX_GPIO140_UP", 0x16c,
> + OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_INPUT_PULLUP)
> +MUX_CFG_34XX("AE6_34XX_GPIO141", 0x16e,
> + OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_OUTPUT)
> +MUX_CFG_34XX("AF5_34XX_GPIO142", 0x170,
> + OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_OUTPUT)
> +MUX_CFG_34XX("AE5_34XX_GPIO143", 0x172,
> + OMAP34XX_MUX_MODE4 | OMAP34XX_PIN_OUTPUT)
> +
> };
>
> #define OMAP34XX_PINS_SZ ARRAY_SIZE(omap34xx_pins)
> diff --git a/arch/arm/plat-omap/include/mach/mux.h b/arch/arm/plat-omap/include/mach/mux.h
> index f4362b8..67fddec 100644
> --- a/arch/arm/plat-omap/include/mach/mux.h
> +++ b/arch/arm/plat-omap/include/mach/mux.h
> @@ -790,6 +790,12 @@ enum omap34xx_index {
> */
> AH8_34XX_GPIO29,
> J25_34XX_GPIO170,
> + AF26_34XX_GPIO0,
> + AF22_34XX_GPIO9,
> + AF6_34XX_GPIO140_UP,
> + AE6_34XX_GPIO141,
> + AF5_34XX_GPIO142,
> + AE5_34XX_GPIO143
> };
>
> struct omap_mux_cfg {
> --
> 1.5.6
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-01-08 12:06 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-16 5:31 [PATCH 1/1] Default MUX configuration added - GPIO140-143, GPIO0 and GPIO9 Manikandan Pillai
2008-12-16 5:37 ` Pandita, Vikram
2008-12-16 10:24 ` Pillai, Manikandan
2008-12-16 16:27 ` Tony Lindgren
2009-01-08 12:06 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox