public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Jarkko Nikula <jarkko.nikula@nokia.com>
Cc: "Lopez Cruz, Misael" <x0052729@ti.com>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"Pandita, Vikram" <vikram.pandita@ti.com>
Subject: Re: [PATCH] ARM: OMAP3: Initialize XCCR and RCCR McBSP registers for McBSP DAI driver
Date: Thu, 18 Dec 2008 16:16:24 +0200	[thread overview]
Message-ID: <20081218141623.GG30366@atomide.com> (raw)
In-Reply-To: <20081218154916.62f4f449.jarkko.nikula@nokia.com>

* Jarkko Nikula <jarkko.nikula@nokia.com> [081218 15:49]:
> On Thu, 18 Dec 2008 15:41:37 +0200
> "ext Tony Lindgren" <tony@atomide.com> wrote:
> 
> > Hi,
> > 
> > * Lopez Cruz, Misael <x0052729@ti.com> [081218 12:16]:
> > > This patch enables XCCR and RCCR McBSP register writing in OMAP 24xx/34xx
> > > platforms. It also explicitly initializes those registers to their default
> > > values in ASoC McBSP DAI driver.
> > 
> > Can you please describe a bit what these registers do? It's impossible
> > for anybody to decipher without looking at the TRM right now.
> > 
> Agree.
> 
> > You can do the above with cpu_class_is_omap2() instead. Might be worth
> > checking that these registers are available on 2420 too.
> > 
> No they are not. These are new registers found in 2430 and OMAP3.

OK, so then it needs to be cpu_is_omap2430().. instead.

> > I agree with Jarkko's comment, the ASoC change should go via alsa list
> > as a separate patch.
> > 
> Probably -mm tree would speed up this since it requires change both in
> plat-omap and sound subsystems?

Well sounds like we should be able to get the plat-omap change merged
during the -rc cycle via omap-fixes branch.

Regards,

Tony

  reply	other threads:[~2008-12-18 14:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-18 10:15 [PATCH] ARM: OMAP3: Initialize XCCR and RCCR McBSP registers for McBSP DAI driver Lopez Cruz, Misael
2008-12-18 12:51 ` Jarkko Nikula
2008-12-18 13:41 ` Tony Lindgren
2008-12-18 13:49   ` Jarkko Nikula
2008-12-18 14:16     ` Tony Lindgren [this message]
2008-12-18 15:17   ` [PATCH] ARM: OMAP3: Initialize XCCR and RCCR McBSP registersfor " shekhar, chandra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081218141623.GG30366@atomide.com \
    --to=tony@atomide.com \
    --cc=jarkko.nikula@nokia.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=vikram.pandita@ti.com \
    --cc=x0052729@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox