From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Tony Lindgren <tony@atomide.com>
Cc: linux-arm-kernel@lists.arm.linux.org.uk,
linux-omap@vger.kernel.org,
"Nikula Jarkko (NRC/Helsinki)" <jarkko.nikula@nokia.com>
Subject: Re: [PATCH 2/2] ARM: OMAP: Fix gpio by switching to generic gpio calls, v2
Date: Wed, 7 Jan 2009 22:00:53 +0000 [thread overview]
Message-ID: <20090107220053.GD11471@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20090107175020.GU27566@atomide.com>
On Wed, Jan 07, 2009 at 07:50:21PM +0200, Tony Lindgren wrote:
> * Russell King - ARM Linux <linux@arm.linux.org.uk> [090107 18:18]:
> > On Wed, Jan 07, 2009 at 01:17:45PM +0200, Tony Lindgren wrote:
> > > - set_irq_type(OMAP_GPIO_IRQ(SW_ENTER_GPIO16), IRQ_TYPE_EDGE_RISING);
> > > - if (request_irq(OMAP_GPIO_IRQ(SW_ENTER_GPIO16), &apollon_sw_interrupt,
> > > + set_irq_type(gpio_to_irq(SW_ENTER_GPIO16), IRQ_TYPE_EDGE_RISING);
> > > + if (request_irq(gpio_to_irq(SW_ENTER_GPIO16), &apollon_sw_interrupt,
> >
> > NAK. I wonder how the f*** this got anywhere near the mainline kernel.
> > No no no no no. set_irq_type + request_irq is utter crap and should be
> > rejected whenever its seen. There's absolutely no need for it -
> > request_irq is sufficient. Get rid of this set_irq_type usage from
> > everywhere please.
>
> Blind search and replace? :) I've removed the GPIO key code as there's
> already a patch to do that cleaner with gpio_keys.
Revised patch is fine.
next prev parent reply other threads:[~2009-01-07 22:01 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-07 11:14 [PATCH 0/2] Fix omap builds Tony Lindgren
2009-01-07 11:16 ` [PATCH 1/2] ARM: OMAP: Fix missing includes Tony Lindgren
2009-01-07 11:17 ` [PATCH 2/2] ARM: OMAP: Fix gpio by switching to generic gpio calls Tony Lindgren
2009-01-07 11:37 ` Jarkko Nikula
2009-01-07 12:03 ` Tony Lindgren
2009-01-07 13:26 ` Adrian Hunter
2009-01-07 13:18 ` Tony Lindgren
2009-01-07 16:18 ` Russell King - ARM Linux
2009-01-07 17:50 ` [PATCH 2/2] ARM: OMAP: Fix gpio by switching to generic gpio calls, v2 Tony Lindgren
2009-01-07 22:00 ` Russell King - ARM Linux [this message]
2009-01-08 7:36 ` updated git pull request for omap compile fixes, mailbox and hsmmc Tony Lindgren
2009-01-10 11:05 ` Russell King - ARM Linux
2009-01-11 10:14 ` Russell King - ARM Linux
2009-01-12 6:24 ` Tony Lindgren
2009-01-12 16:43 ` Russell King - ARM Linux
2009-01-13 10:30 ` Tony Lindgren
2009-01-19 16:36 ` Russell King - ARM Linux
2009-01-23 0:45 ` Tony Lindgren
2009-01-12 6:28 ` Tony Lindgren
2009-01-10 11:02 ` [PATCH 2/2] ARM: OMAP: Fix gpio by switching to generic gpio calls Russell King - ARM Linux
2009-01-12 13:14 ` Tony Lindgren
2009-01-10 10:57 ` [PATCH 1/2] ARM: OMAP: Fix missing includes Russell King - ARM Linux
2009-01-10 15:56 ` Samuel Ortiz
2009-01-10 16:20 ` Russell King - ARM Linux
2009-01-10 17:40 ` Samuel Ortiz
2009-01-10 17:56 ` Russell King - ARM Linux
2009-01-12 6:45 ` Tony Lindgren
2009-01-10 21:21 ` David Brownell
2009-01-10 20:49 ` David Brownell
2009-01-11 0:01 ` Samuel Ortiz
2009-01-12 6:31 ` Tony Lindgren
2009-01-07 11:25 ` git pull request for omap compile fixes, mailbox and hsmmc for current merge window Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090107220053.GD11471@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=jarkko.nikula@nokia.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox