public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: "matti.halme@nokia.com" <matti.halme@nokia.com>
Cc: a.zummo@towertech.it, rtc-linux@googlegroups.com,
	linux-omap@vger.kernel.org
Subject: Re: [PATCH] Don't mask rtc-twl4030 alarm interrupts on shutdown
Date: Thu, 8 Jan 2009 14:24:08 +0200	[thread overview]
Message-ID: <20090108122407.GD27566@atomide.com> (raw)
In-Reply-To: <043E6D9F43E2D14682729D3AE18163F30293E71E@vaebe107.NOE.Nokia.com>

* matti.halme@nokia.com <matti.halme@nokia.com> [090107 09:10]:
> A triggering RTC alarm should be able to power on a device that has been
> powered off. This patch enables that on twl4030 by not masking the alarm
> interrupt at shutdown.

Looks like this is already queued up for mainline by Alessandro,
so pushing to linux-omap tree while waiting for it to fall down
from mainline.

Tony


> Signed-off-by: Matti Halme <matti.halme@nokia.com>
> ---
>  drivers/rtc/rtc-twl4030.c |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/rtc/rtc-twl4030.c b/drivers/rtc/rtc-twl4030.c
> index abe87a4..f5f6a97 100644
> --- a/drivers/rtc/rtc-twl4030.c
> +++ b/drivers/rtc/rtc-twl4030.c
> @@ -505,8 +505,9 @@ static int __devexit twl4030_rtc_remove(struct
> platform_device *pdev)
>  
>  static void twl4030_rtc_shutdown(struct platform_device *pdev)
>  {
> -	mask_rtc_irq_bit(BIT_RTC_INTERRUPTS_REG_IT_TIMER_M |
> -			 BIT_RTC_INTERRUPTS_REG_IT_ALARM_M);
> +	/* mask timer interrupts, but leave alarm interrupts on to
> enable
> +	   power-on when alarm is triggered */
> +	mask_rtc_irq_bit(BIT_RTC_INTERRUPTS_REG_IT_TIMER_M);
>  }
>  
>  #ifdef CONFIG_PM
> -- 
> 1.4.4.4
> 
> Regards,
> Matti Halme
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2009-01-08 12:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-07  7:10 [PATCH] Don't mask rtc-twl4030 alarm interrupts on shutdown matti.halme
2009-01-08 12:24 ` Tony Lindgren [this message]
     [not found] <043E6D9F43E2D14682729D3AE18163F3FD9B6C@vaebe107.NOE.Nokia.com>
2008-12-29 15:54 ` Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090108122407.GD27566@atomide.com \
    --to=tony@atomide.com \
    --cc=a.zummo@towertech.it \
    --cc=linux-omap@vger.kernel.org \
    --cc=matti.halme@nokia.com \
    --cc=rtc-linux@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox