Re: [PATCH OMAPZOOM] OMAP: DMA: Fix CCR programming for request line > 63

[Tony Lindgren <tony@atomide.com>]

* Pandita, Vikram <vikram.pandita@ti.com> [081111 15:34]:
> Pushed to zoom tree.

Sorry for the long delay with this. Pushing to l-o tree and
added to omap-fixes queue.

Tony


> >-----Original Message-----
> >From: Gadiyar, Anand
> >Sent: Monday, November 10, 2008 5:08 AM
> >To: linux-omap@vger.kernel.org
> >Cc: Pandita, Vikram; tony@atomide.com
> >Subject: [PATCH OMAPZOOM] OMAP: DMA: Fix CCR programming for request line > 63
> >
> >From: Anand Gadiyar <gadiyar@ti.com>
> >
> >Bug in existing code causes synchro control to be set +32 if request
> >line greater than 63 is used.
> >
> >Reported by Wenbiao Wang
> >
> >Signed-off-by: Anand Gadiyar <gadiyar@ti.com>
> >---
> >Patch generated against OMAPZOOM tree. Will apply against
> >linux-omap as well with an offset of 8 lines.
> >
> >diff --git a/arch/arm/plat-omap/dma.c b/arch/arm/plat-omap/dma.c
> >index 562089e..b38a362 100644
> >--- a/arch/arm/plat-omap/dma.c
> >+++ b/arch/arm/plat-omap/dma.c
> >@@ -287,10 +287,7 @@ void omap_set_dma_transfer_params(int lch, int data_type, int elem_count,
> >
> > 		val = dma_read(CCR(lch));
> > 		val &= ~(3 << 19);
> >-		if (dma_trigger > 63)
> >-			val |= 1 << 20;
> >-		if (dma_trigger > 31)
> >-			val |= 1 << 19;
> >+		val |= ((dma_trigger & ~(0x1f)) << 14);
> >
> > 		val &= ~(0x1f);
> > 		val |= (dma_trigger & 0x1f);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html