* [PATCH] OMAP2/3 McBSP: add temporary clockdomain fix for McBSP virtual clocks [not found] <20090108152853.20939.39831.stgit@localhost.localdomain> @ 2009-01-08 15:28 ` Paul Walmsley 2009-01-08 15:42 ` Tony Lindgren 0 siblings, 1 reply; 2+ messages in thread From: Paul Walmsley @ 2009-01-08 15:28 UTC (permalink / raw) To: linux-omap; +Cc: Paul Walmsley, Tony Lindgren, Eero Nurkkala The McBSP driver uses virtual clocks to handle enabling and disabling its hardware clocks. These virtual clocks have no associated clockdomain. After commit 60b8b431e47d8c5b8c02a2e4fa9af388aae20790, this prevents the McBSP clocks from registering correctly. Resolve this for the short term by using virt_opp_clkdm for these clocks. These McBSP virtual clocks should be removed, but such a fix would require significant changes to the McBSP drivers that would require testing on OMAP1, 2, and 3 platforms. Tested on 2430SDP and 3430SDP GP ES2.1. Signed-off-by: Paul Walmsley <paul@pwsan.com> Cc: Tony Lindgren <tony@atomide.com> Cc: Eero Nurkkala <ext-eero.nurkkala@nokia.com> --- arch/arm/mach-omap2/mcbsp.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-omap2/mcbsp.c b/arch/arm/mach-omap2/mcbsp.c index cae3ebe..b40b29a 100644 --- a/arch/arm/mach-omap2/mcbsp.c +++ b/arch/arm/mach-omap2/mcbsp.c @@ -77,6 +77,7 @@ static struct mcbsp_internal_clk omap_mcbsp_clks[] = { .clk = { .name = "mcbsp_clk", .id = 1, + .clkdm = { .name = "virt_opp_clkdm" }, .enable = omap_mcbsp_clk_enable, .disable = omap_mcbsp_clk_disable, }, @@ -85,6 +86,7 @@ static struct mcbsp_internal_clk omap_mcbsp_clks[] = { .clk = { .name = "mcbsp_clk", .id = 2, + .clkdm = { .name = "virt_opp_clkdm" }, .enable = omap_mcbsp_clk_enable, .disable = omap_mcbsp_clk_disable, }, @@ -93,6 +95,7 @@ static struct mcbsp_internal_clk omap_mcbsp_clks[] = { .clk = { .name = "mcbsp_clk", .id = 3, + .clkdm = { .name = "virt_opp_clkdm" }, .enable = omap_mcbsp_clk_enable, .disable = omap_mcbsp_clk_disable, }, @@ -101,6 +104,7 @@ static struct mcbsp_internal_clk omap_mcbsp_clks[] = { .clk = { .name = "mcbsp_clk", .id = 4, + .clkdm = { .name = "virt_opp_clkdm" }, .enable = omap_mcbsp_clk_enable, .disable = omap_mcbsp_clk_disable, }, @@ -109,6 +113,7 @@ static struct mcbsp_internal_clk omap_mcbsp_clks[] = { .clk = { .name = "mcbsp_clk", .id = 5, + .clkdm = { .name = "virt_opp_clkdm" }, .enable = omap_mcbsp_clk_enable, .disable = omap_mcbsp_clk_disable, }, ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] OMAP2/3 McBSP: add temporary clockdomain fix for McBSP virtual clocks 2009-01-08 15:28 ` [PATCH] OMAP2/3 McBSP: add temporary clockdomain fix for McBSP virtual clocks Paul Walmsley @ 2009-01-08 15:42 ` Tony Lindgren 0 siblings, 0 replies; 2+ messages in thread From: Tony Lindgren @ 2009-01-08 15:42 UTC (permalink / raw) To: Paul Walmsley; +Cc: linux-omap, Eero Nurkkala * Paul Walmsley <paul@pwsan.com> [090108 17:30]: > The McBSP driver uses virtual clocks to handle enabling and disabling > its hardware clocks. These virtual clocks have no associated > clockdomain. After commit 60b8b431e47d8c5b8c02a2e4fa9af388aae20790, > this prevents the McBSP clocks from registering correctly. > Resolve this for the short term by using virt_opp_clkdm for these clocks. > These McBSP virtual clocks should be removed, but such a fix would require > significant changes to the McBSP drivers that would require testing on > OMAP1, 2, and 3 platforms. > > Tested on 2430SDP and 3430SDP GP ES2.1. Thanks, pushing to l-o tree. Tony > Signed-off-by: Paul Walmsley <paul@pwsan.com> > Cc: Tony Lindgren <tony@atomide.com> > Cc: Eero Nurkkala <ext-eero.nurkkala@nokia.com> > --- > arch/arm/mach-omap2/mcbsp.c | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-omap2/mcbsp.c b/arch/arm/mach-omap2/mcbsp.c > index cae3ebe..b40b29a 100644 > --- a/arch/arm/mach-omap2/mcbsp.c > +++ b/arch/arm/mach-omap2/mcbsp.c > @@ -77,6 +77,7 @@ static struct mcbsp_internal_clk omap_mcbsp_clks[] = { > .clk = { > .name = "mcbsp_clk", > .id = 1, > + .clkdm = { .name = "virt_opp_clkdm" }, > .enable = omap_mcbsp_clk_enable, > .disable = omap_mcbsp_clk_disable, > }, > @@ -85,6 +86,7 @@ static struct mcbsp_internal_clk omap_mcbsp_clks[] = { > .clk = { > .name = "mcbsp_clk", > .id = 2, > + .clkdm = { .name = "virt_opp_clkdm" }, > .enable = omap_mcbsp_clk_enable, > .disable = omap_mcbsp_clk_disable, > }, > @@ -93,6 +95,7 @@ static struct mcbsp_internal_clk omap_mcbsp_clks[] = { > .clk = { > .name = "mcbsp_clk", > .id = 3, > + .clkdm = { .name = "virt_opp_clkdm" }, > .enable = omap_mcbsp_clk_enable, > .disable = omap_mcbsp_clk_disable, > }, > @@ -101,6 +104,7 @@ static struct mcbsp_internal_clk omap_mcbsp_clks[] = { > .clk = { > .name = "mcbsp_clk", > .id = 4, > + .clkdm = { .name = "virt_opp_clkdm" }, > .enable = omap_mcbsp_clk_enable, > .disable = omap_mcbsp_clk_disable, > }, > @@ -109,6 +113,7 @@ static struct mcbsp_internal_clk omap_mcbsp_clks[] = { > .clk = { > .name = "mcbsp_clk", > .id = 5, > + .clkdm = { .name = "virt_opp_clkdm" }, > .enable = omap_mcbsp_clk_enable, > .disable = omap_mcbsp_clk_disable, > }, > > ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-01-08 15:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20090108152853.20939.39831.stgit@localhost.localdomain>
2009-01-08 15:28 ` [PATCH] OMAP2/3 McBSP: add temporary clockdomain fix for McBSP virtual clocks Paul Walmsley
2009-01-08 15:42 ` Tony Lindgren
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox