From: Tony Lindgren <tony@atomide.com>
To: "Lopez Cruz, Misael" <x0052729@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"Pandita, Vikram" <vikram.pandita@ti.com>,
Jarkko Nikula <jarkko.nikula@nokia.com>
Subject: Re: [PATCH] ARM: OMAP3: Enable writing to XCCR and RCCR McBSP registers for OMAP 2430/34xx
Date: Fri, 9 Jan 2009 13:46:01 +0200 [thread overview]
Message-ID: <20090109114557.GH2536@atomide.com> (raw)
In-Reply-To: <2C7D3DF36ADFFC479B44490D912B616705A496D1E0@dlee07.ent.ti.com>
* Lopez Cruz, Misael <x0052729@ti.com> [090108 19:43]:
> > * Lopez Cruz, Misael <x0052729@ti.com> [081219 04:53]:
> > > This patch enables writing to McBSP Transmit Configuration Control
> > > Register (XCCR) and Receive Configuration Control Register
> > (RCCR) for
> > > 2430/34xx platforms. It also adds XCCR, RCCR entries in
> > McBSP register
> > > configuration structure and bit definitions for both registers.
> >
> > Pushing to l-o. Can you briefly describe what happens with
> > ASoC if these registers are not used? We may be able to send
> > this as a fix to mainline during the -rc cycle.
>
> If we enable the writing to those registers for 2430/34xx and don't set the default values (setting 0 as a consequence) in ASoC driver, the Transmit/Receive DMA mode gets disabled and the the transmission/reception doesn't happen, ending with a "write error: Input/Output error" when playing with 'aplay'.
Thanks, I'll add that to the commit in the omap-fixes queue.
Tony
next prev parent reply other threads:[~2009-01-09 11:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-19 2:53 [PATCH] ARM: OMAP3: Enable writing to XCCR and RCCR McBSP registers for OMAP 2430/34xx Lopez Cruz, Misael
2008-12-19 2:58 ` Lopez Cruz, Misael
2009-01-08 15:57 ` Tony Lindgren
2009-01-08 17:43 ` Lopez Cruz, Misael
2009-01-09 11:46 ` Tony Lindgren [this message]
2009-01-17 7:09 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090109114557.GH2536@atomide.com \
--to=tony@atomide.com \
--cc=jarkko.nikula@nokia.com \
--cc=linux-omap@vger.kernel.org \
--cc=vikram.pandita@ti.com \
--cc=x0052729@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox