From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: Questions about masking interrupts when disabling interrupts Date: Fri, 9 Jan 2009 14:04:28 +0200 Message-ID: <20090109120425.GK2536@atomide.com> References: <4d34a0a70901051859i792725b3t4563971070f886fc@mail.gmail.com> <20090107130504.GM27566@atomide.com> <4d34a0a70901071727m5fcc1ffvba81d28c970aaace@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mho-01-bos.mailhop.org ([63.208.196.178]:50861 "EHLO mho-01-bos.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752072AbZAIMEc (ORCPT ); Fri, 9 Jan 2009 07:04:32 -0500 Content-Disposition: inline In-Reply-To: <4d34a0a70901071727m5fcc1ffvba81d28c970aaace@mail.gmail.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Kim Kyuwon Cc: linux-omap@vger.kernel.org, =?utf-8?B?67CV6rK966+8?= , =?utf-8?B?7ZeI7ISx6rSA?= * Kim Kyuwon [090108 03:27]: > Thanks Tony very much for your reply! >=20 > On Wed, Jan 7, 2009 at 10:05 PM, Tony Lindgren wro= te: > > * =EA=B9=80=EA=B7=9C=EC=9B=90 [090106 04:59]: > >> Greetings, > >> > >> I'm enabling the Suspend-to-RAM state in our new OMAP3 Board. > >> But I had some problems because of USB Interrupt. > >> > >> Although I disabled USB interrupt by disable_irq() function while > >> entering the Suspend, > >> M_IRQ_92 irq continuously wake up the OMAP3430 Processor. > >> > >> So, I fixed this problem as following patch. > >> > >> My Questions are: > >> 1. Could anyone suggest the better solution for this problem? > > > > Maybe suspend the US=CE=92 too? :) >=20 > I confirmed musb_suspend() function was invoked while entering Suspen= d-to-RAM > state. musb_suspend() didn't disable USB interrupt, but only USB cloc= k. Devices > should be suspended with interrupts disabled > (/Documenttation/power/devices.txt - 412line) >=20 > So I modified musb_suspend() to disable USB interrupt > (I'm planning to send this patch very soon) > I even wrote 0 to PM_WKEN_USBHOST[EN_USBHOST] bit. But our OMAP3430 b= oard > still have woken up by USB interrupt, because disable_irq() didn't ma= sk the > interrupt. OK >=20 > > > >> 2. If there is no better solution, can I be applied this patch to = omap-tree? > > > > The patch looks OK to me, assuming the default enable calls unmask? > > >=20 > Right, default_enable() function(kernel/irq/chip.c 222line) calls unm= ask OK, pushing to l-o tree and adding to omap-fixes queue for mainline kernel. Tony >=20 > > Regards, > > > > Tony > > > >> > >> Thank you! > >> > >> commit bbb49321b161e6a9ff2b73326d4012d8eb8bbf23 > >> Author: Kim Kyuwon > >> Date: Tue Jan 6 10:11:46 2009 +0900 > >> > >> ARM: OMAP3: Mask interrupts when disabling interrupts > >> > >> By Ingo Molnar, interrupts are not masked by default. > >> (refer to 76d2160147f43f982dfe881404cfde9fd0a9da21) > >> > >> But if interrupts are not masked, the processor can wake up wh= ile in > >> Suspend-to-RAM state by an external interrupt. For example, if= an > >> OMAP3 board > >> is connected to Host PC by USB and entered to Suspend-to-RAM > >> state, it wake up > >> automatically by M_IRQ_92. The disable_irq() function can't di= sable the > >> interrupt in H/W level, So I modified arch/arm/mach-omap2/irq.= c > >> > >> Signed-off-by: Kim Kyuwon > >> > >> diff --git a/arch/arm/mach-omap2/irq.c b/arch/arm/mach-omap2/irq.c > >> index 110acb9..b44dcae 100644 > >> --- a/arch/arm/mach-omap2/irq.c > >> +++ b/arch/arm/mach-omap2/irq.c > >> @@ -123,6 +123,11 @@ static void omap_unmask_irq(unsigned int irq) > >> intc_bank_write_reg(1 << irq, &irq_banks[0], INTC_MIR_CLEAR0= + offset); > >> } > >> > >> +static void omap_disable_irq(unsigned int irq) > >> +{ > >> + omap_mask_irq(irq); > >> +} > >> + > >> static void omap_mask_ack_irq(unsigned int irq) > >> { > >> omap_mask_irq(irq); > >> @@ -134,6 +139,7 @@ static struct irq_chip omap_irq_chip =3D { > >> .ack =3D omap_mask_ack_irq, > >> .mask =3D omap_mask_irq, > >> .unmask =3D omap_unmask_irq, > >> + .disable =3D omap_disable_irq, > >> }; > >> > >> static void __init omap_irq_bank_init_one(struct omap_irq_bank *b= ank) > >> -- > >> Kim Kyuwon > >> -- > >> To unsubscribe from this list: send the line "unsubscribe linux-om= ap" in > >> the body of a message to majordomo@vger.kernel.org > >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > >=20 > Regards, > --=20 > Kim Kyuwon -- To unsubscribe from this list: send the line "unsubscribe linux-omap" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html