public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Samuel Ortiz <sameo@openedhand.com>
Cc: David Brownell <david-b@pacbell.net>,
	linux-arm-kernel@lists.arm.linux.org.uk,
	linux-omap@vger.kernel.org,
	Russell King - ARM Linux <linux@arm.linux.org.uk>
Subject: Re: [PATCH 1/2] ARM: OMAP: Fix missing includes
Date: Mon, 12 Jan 2009 08:31:26 +0200	[thread overview]
Message-ID: <20090112063125.GC4968@atomide.com> (raw)
In-Reply-To: <20090111000147.GB2683@sortiz.org>

* Samuel Ortiz <sameo@openedhand.com> [090111 01:59]:
> On Sat, Jan 10, 2009 at 12:49:26PM -0800, David Brownell wrote:
> > On Saturday 10 January 2009, Samuel Ortiz wrote:
> > > > --- a/drivers/mfd/twl4030-core.c
> > > > +++ b/drivers/mfd/twl4030-core.c
> > > > @@ -38,6 +38,7 @@
> > > >  #include <linux/i2c.h>
> > > >  #include <linux/i2c/twl4030.h>
> > > >  
> > > > +#include <mach/cpu.h>
> > > That will break the build on !ARM for this driver.
> > 
> > What needs to happen with twl4030-core.c is IMO this:
> > 
> >  - Near term:
> >      * revert 6354ab5c63bc986bf539026a1b289cc142f6e87c
> >        and just make the driver depend on HAVE_CLK
> Yep, I'll do that afer the merge window.
> 
> >      * #ifdef CONFIG_ARM do the #include <mach/cpu.h>
> Not too pretty, but a good enough compromise for me.
> I'll push that.

Thanks! I'll rework the other omap build fixes today.

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2009-01-12  6:31 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-07 11:14 [PATCH 0/2] Fix omap builds Tony Lindgren
2009-01-07 11:16 ` [PATCH 1/2] ARM: OMAP: Fix missing includes Tony Lindgren
2009-01-07 11:17   ` [PATCH 2/2] ARM: OMAP: Fix gpio by switching to generic gpio calls Tony Lindgren
2009-01-07 11:37     ` Jarkko Nikula
2009-01-07 12:03       ` Tony Lindgren
2009-01-07 13:26         ` Adrian Hunter
2009-01-07 13:18           ` Tony Lindgren
2009-01-07 16:18     ` Russell King - ARM Linux
2009-01-07 17:50       ` [PATCH 2/2] ARM: OMAP: Fix gpio by switching to generic gpio calls, v2 Tony Lindgren
2009-01-07 22:00         ` Russell King - ARM Linux
2009-01-08  7:36           ` updated git pull request for omap compile fixes, mailbox and hsmmc Tony Lindgren
2009-01-10 11:05             ` Russell King - ARM Linux
2009-01-11 10:14               ` Russell King - ARM Linux
2009-01-12  6:24                 ` Tony Lindgren
2009-01-12 16:43                   ` Russell King - ARM Linux
2009-01-13 10:30                     ` Tony Lindgren
2009-01-19 16:36                       ` Russell King - ARM Linux
2009-01-23  0:45                         ` Tony Lindgren
2009-01-12  6:28               ` Tony Lindgren
2009-01-10 11:02     ` [PATCH 2/2] ARM: OMAP: Fix gpio by switching to generic gpio calls Russell King - ARM Linux
2009-01-12 13:14       ` Tony Lindgren
2009-01-10 10:57   ` [PATCH 1/2] ARM: OMAP: Fix missing includes Russell King - ARM Linux
2009-01-10 15:56   ` Samuel Ortiz
2009-01-10 16:20     ` Russell King - ARM Linux
2009-01-10 17:40       ` Samuel Ortiz
2009-01-10 17:56         ` Russell King - ARM Linux
2009-01-12  6:45           ` Tony Lindgren
2009-01-10 21:21       ` David Brownell
2009-01-10 20:49     ` David Brownell
2009-01-11  0:01       ` Samuel Ortiz
2009-01-12  6:31         ` Tony Lindgren [this message]
2009-01-07 11:25 ` git pull request for omap compile fixes, mailbox and hsmmc for current merge window Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090112063125.GC4968@atomide.com \
    --to=tony@atomide.com \
    --cc=david-b@pacbell.net \
    --cc=linux-arm-kernel@lists.arm.linux.org.uk \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=sameo@openedhand.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox