Re: [PATCH v2] OMAP: Fix McBSP spin_lock deadlock.

[Tony Lindgren <tony@atomide.com>]

* stanley.miao <stanley.miao@windriver.com> [090112 12:34]:
> On Thu, 2009-01-08 at 15:33 +0200, Tony Lindgren wrote:
> > * stanley.miao <stanley.miao@windriver.com> [081107 15:47]:
> > > This solution keeps the virtual clock in place and enable the child
> > > clocks before enable the virtual clock. So, any comments ?
> > 
> > What if we just removed the custom clock and had a struct **clk
> > in struct omap_mcbsp that contains the clocks for each instance?
> 
> It works. This is what I did in my first patch. 

OK, sorry for all this going back and forth.. We still don't
have a good long term solution on how to handle different clocks..

> The difference is I add two struct *clk in struct omap_mcbsp.
> 
> struct omap_mcbsp {
> @@ -365,7 +366,8 @@ struct omap_mcbsp {
>         /* Protect the field .free, while checking if the mcbsp is in
> use */
>         spinlock_t lock;
>         struct omap_mcbsp_platform_data *pdata;
> -       struct clk *clk;
> +       struct clk *ick;
> +       struct clk *fck;
> 
> 
> If one struct **clk is better, I will resend the patch later.

Sounds like we should just apply your original patch, then figure
out a good long term approacth.

Can you please repost your first version of the patch?

Regards,

Tony