From: Felipe Balbi <me@felipebalbi.com>
To: Ajay Kumar Gupta <ajay.gupta@ti.com>
Cc: linux-omap@vger.kernel.org, david-b@pacbell.net, felipe.balbi@nokia.com
Subject: Re: [PATCH v2] usb: musb: fix bug in musbhsdma programming
Date: Tue, 13 Jan 2009 00:26:49 +0200 [thread overview]
Message-ID: <20090112222649.GL25493@frodo> (raw)
In-Reply-To: <1231475946-6810-1-git-send-email-ajay.gupta@ti.com>
On Fri, Jan 09, 2009 at 10:09:06AM +0530, Ajay Kumar Gupta wrote:
> Mode bit should be set based on function parameter "mode" of
> configure_channel() function.
>
> Signed-off-by: Ajay Kumar Gupta <ajay.gupta@ti.com>
Acked-by: Felipe Balbi <felipe.balbi@nokia.com>
> ---
> Original version of this patch is at,
> http://marc.info/?l=linux-usb&m=123141793611158&w=2
tony, this should go to l-o
>
> drivers/usb/musb/musbhsdma.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/usb/musb/musbhsdma.c b/drivers/usb/musb/musbhsdma.c
> index 75b15ce..8e44355 100644
> --- a/drivers/usb/musb/musbhsdma.c
> +++ b/drivers/usb/musb/musbhsdma.c
> @@ -136,7 +136,7 @@ static void configure_channel(struct dma_channel *channel,
> csr |= MUSB_HSDMA_BURSTMODE_INCR4;
>
> csr |= (musb_channel->epnum << MUSB_HSDMA_ENDPOINT_SHIFT)
> - | MUSB_HSDMA_MODE1
> + | mode ? MUSB_HSDMA_MODE1 : 0
> | MUSB_HSDMA_ENABLE
> | MUSB_HSDMA_IRQENABLE
> | (musb_channel->transmit
> --
> 1.5.6
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
balbi
next prev parent reply other threads:[~2009-01-12 22:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-09 4:39 [PATCH v2] usb: musb: fix bug in musbhsdma programming Ajay Kumar Gupta
2009-01-09 5:16 ` Gupta, Ajay Kumar
2009-01-12 22:26 ` Felipe Balbi [this message]
2009-01-13 4:31 ` Gupta, Ajay Kumar
2009-01-13 12:09 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090112222649.GL25493@frodo \
--to=me@felipebalbi.com \
--cc=ajay.gupta@ti.com \
--cc=david-b@pacbell.net \
--cc=felipe.balbi@nokia.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox