From mboxrd@z Thu Jan 1 00:00:00 1970 From: Felipe Balbi Subject: Re: [PATCH v2] usb: musb: fix bug in musbhsdma programming Date: Tue, 13 Jan 2009 00:26:49 +0200 Message-ID: <20090112222649.GL25493@frodo> References: <1231475946-6810-1-git-send-email-ajay.gupta@ti.com> Reply-To: me@felipebalbi.com Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from ns1.siteground211.com ([209.62.36.12]:56601 "EHLO serv01.siteground211.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758853AbZALW04 (ORCPT ); Mon, 12 Jan 2009 17:26:56 -0500 Content-Disposition: inline In-Reply-To: <1231475946-6810-1-git-send-email-ajay.gupta@ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Ajay Kumar Gupta Cc: linux-omap@vger.kernel.org, david-b@pacbell.net, felipe.balbi@nokia.com On Fri, Jan 09, 2009 at 10:09:06AM +0530, Ajay Kumar Gupta wrote: > Mode bit should be set based on function parameter "mode" of > configure_channel() function. > > Signed-off-by: Ajay Kumar Gupta Acked-by: Felipe Balbi > --- > Original version of this patch is at, > http://marc.info/?l=linux-usb&m=123141793611158&w=2 tony, this should go to l-o > > drivers/usb/musb/musbhsdma.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/usb/musb/musbhsdma.c b/drivers/usb/musb/musbhsdma.c > index 75b15ce..8e44355 100644 > --- a/drivers/usb/musb/musbhsdma.c > +++ b/drivers/usb/musb/musbhsdma.c > @@ -136,7 +136,7 @@ static void configure_channel(struct dma_channel *channel, > csr |= MUSB_HSDMA_BURSTMODE_INCR4; > > csr |= (musb_channel->epnum << MUSB_HSDMA_ENDPOINT_SHIFT) > - | MUSB_HSDMA_MODE1 > + | mode ? MUSB_HSDMA_MODE1 : 0 > | MUSB_HSDMA_ENABLE > | MUSB_HSDMA_IRQENABLE > | (musb_channel->transmit > -- > 1.5.6 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- balbi