* [PATCH] usb: musb: adding support for registering nop xceiv
@ 2009-01-08 10:53 Ajay Kumar Gupta
2009-01-12 22:29 ` Felipe Balbi
0 siblings, 1 reply; 6+ messages in thread
From: Ajay Kumar Gupta @ 2009-01-08 10:53 UTC (permalink / raw)
To: linux-omap; +Cc: david-b, felipe.balbi, Ajay Kumar Gupta
Adding support for registering nop usb transceiver for musb
platforms. Tested with OMAP35xx EVM having OTG phy ISP1504
which is autonomous and doesn't require any phy programming.
Signed-off-by: Ajay Kumar Gupta <ajay.gupta@ti.com>
---
arch/arm/mach-omap2/usb-musb.c | 19 +++++++++++++++++++
1 files changed, 19 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2/usb-musb.c b/arch/arm/mach-omap2/usb-musb.c
index 61c5709..c202256 100644
--- a/arch/arm/mach-omap2/usb-musb.c
+++ b/arch/arm/mach-omap2/usb-musb.c
@@ -155,10 +155,29 @@ static struct platform_device musb_device = {
};
#endif
+#ifdef CONFIG_NOP_USB_XCEIV
+static u64 nop_xceiv_dmamask = DMA_32BIT_MASK;
+
+static struct platform_device nop_xceiv_device = {
+ .name = "nop_usb_xceiv",
+ .id = -1,
+ .dev = {
+ .dma_mask = &nop_xceiv_dmamask,
+ .coherent_dma_mask = DMA_32BIT_MASK,
+ .platform_data = NULL,
+ },
+};
+#endif
void __init usb_musb_init(void)
{
#ifdef CONFIG_USB_MUSB_SOC
+#ifdef CONFIG_NOP_USB_XCEIV
+ if (platform_device_register(&nop_xceiv_device) < 0) {
+ printk(KERN_ERR "Unable to register NOP-XCEIV device\n");
+ return;
+ }
+#endif
if (platform_device_register(&musb_device) < 0) {
printk(KERN_ERR "Unable to register HS-USB (MUSB) device\n");
return;
--
1.5.6
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] usb: musb: adding support for registering nop xceiv
2009-01-08 10:53 [PATCH] usb: musb: adding support for registering nop xceiv Ajay Kumar Gupta
@ 2009-01-12 22:29 ` Felipe Balbi
2009-01-19 10:39 ` Gupta, Ajay Kumar
0 siblings, 1 reply; 6+ messages in thread
From: Felipe Balbi @ 2009-01-12 22:29 UTC (permalink / raw)
To: Ajay Kumar Gupta; +Cc: linux-omap, david-b, felipe.balbi
On Thu, Jan 08, 2009 at 04:23:56PM +0530, Ajay Kumar Gupta wrote:
> Adding support for registering nop usb transceiver for musb
> platforms. Tested with OMAP35xx EVM having OTG phy ISP1504
> which is autonomous and doesn't require any phy programming.
>
> Signed-off-by: Ajay Kumar Gupta <ajay.gupta@ti.com>
Tony, if Dave is ok with the nop-xceiv, we can apply this to l-o and
people who doesn't use twl4030/tlw5030 xceiv will have to select this
driver.
> ---
> arch/arm/mach-omap2/usb-musb.c | 19 +++++++++++++++++++
> 1 files changed, 19 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/usb-musb.c b/arch/arm/mach-omap2/usb-musb.c
> index 61c5709..c202256 100644
> --- a/arch/arm/mach-omap2/usb-musb.c
> +++ b/arch/arm/mach-omap2/usb-musb.c
> @@ -155,10 +155,29 @@ static struct platform_device musb_device = {
> };
> #endif
>
> +#ifdef CONFIG_NOP_USB_XCEIV
> +static u64 nop_xceiv_dmamask = DMA_32BIT_MASK;
> +
> +static struct platform_device nop_xceiv_device = {
> + .name = "nop_usb_xceiv",
> + .id = -1,
> + .dev = {
> + .dma_mask = &nop_xceiv_dmamask,
> + .coherent_dma_mask = DMA_32BIT_MASK,
> + .platform_data = NULL,
> + },
> +};
> +#endif
>
> void __init usb_musb_init(void)
> {
> #ifdef CONFIG_USB_MUSB_SOC
> +#ifdef CONFIG_NOP_USB_XCEIV
> + if (platform_device_register(&nop_xceiv_device) < 0) {
> + printk(KERN_ERR "Unable to register NOP-XCEIV device\n");
> + return;
> + }
> +#endif
> if (platform_device_register(&musb_device) < 0) {
> printk(KERN_ERR "Unable to register HS-USB (MUSB) device\n");
> return;
> --
> 1.5.6
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
balbi
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] usb: musb: adding support for registering nop xceiv
2009-01-12 22:29 ` Felipe Balbi
@ 2009-01-19 10:39 ` Gupta, Ajay Kumar
2009-02-20 16:41 ` Tony Lindgren
0 siblings, 1 reply; 6+ messages in thread
From: Gupta, Ajay Kumar @ 2009-01-19 10:39 UTC (permalink / raw)
To: me@felipebalbi.com
Cc: linux-omap@vger.kernel.org, david-b@pacbell.net,
felipe.balbi@nokia.com
> -----Original Message-----
> From: Felipe Balbi [mailto:me@felipebalbi.com]
> Sent: Tuesday, January 13, 2009 4:00 AM
> To: Gupta, Ajay Kumar
> Cc: linux-omap@vger.kernel.org; david-b@pacbell.net; felipe.balbi@nokia.com
> Subject: Re: [PATCH] usb: musb: adding support for registering nop xceiv
>
> On Thu, Jan 08, 2009 at 04:23:56PM +0530, Ajay Kumar Gupta wrote:
> > Adding support for registering nop usb transceiver for musb
> > platforms. Tested with OMAP35xx EVM having OTG phy ISP1504
> > which is autonomous and doesn't require any phy programming.
> >
> > Signed-off-by: Ajay Kumar Gupta <ajay.gupta@ti.com>
>
> Tony, if Dave is ok with the nop-xceiv, we can apply this to l-o and
> people who doesn't use twl4030/tlw5030 xceiv will have to select this
> driver.
Hi David,
Please review this one too.
Regards,
Ajay
>
> > ---
> > arch/arm/mach-omap2/usb-musb.c | 19 +++++++++++++++++++
> > 1 files changed, 19 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/arm/mach-omap2/usb-musb.c b/arch/arm/mach-omap2/usb-musb.c
> > index 61c5709..c202256 100644
> > --- a/arch/arm/mach-omap2/usb-musb.c
> > +++ b/arch/arm/mach-omap2/usb-musb.c
> > @@ -155,10 +155,29 @@ static struct platform_device musb_device = {
> > };
> > #endif
> >
> > +#ifdef CONFIG_NOP_USB_XCEIV
> > +static u64 nop_xceiv_dmamask = DMA_32BIT_MASK;
> > +
> > +static struct platform_device nop_xceiv_device = {
> > + .name = "nop_usb_xceiv",
> > + .id = -1,
> > + .dev = {
> > + .dma_mask = &nop_xceiv_dmamask,
> > + .coherent_dma_mask = DMA_32BIT_MASK,
> > + .platform_data = NULL,
> > + },
> > +};
> > +#endif
> >
> > void __init usb_musb_init(void)
> > {
> > #ifdef CONFIG_USB_MUSB_SOC
> > +#ifdef CONFIG_NOP_USB_XCEIV
> > + if (platform_device_register(&nop_xceiv_device) < 0) {
> > + printk(KERN_ERR "Unable to register NOP-XCEIV device\n");
> > + return;
> > + }
> > +#endif
> > if (platform_device_register(&musb_device) < 0) {
> > printk(KERN_ERR "Unable to register HS-USB (MUSB) device\n");
> > return;
> > --
> > 1.5.6
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
>
> --
> balbi
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] usb: musb: adding support for registering nop xceiv
2009-01-19 10:39 ` Gupta, Ajay Kumar
@ 2009-02-20 16:41 ` Tony Lindgren
2009-02-20 16:43 ` Felipe Balbi
2009-02-20 22:06 ` David Brownell
0 siblings, 2 replies; 6+ messages in thread
From: Tony Lindgren @ 2009-02-20 16:41 UTC (permalink / raw)
To: Gupta, Ajay Kumar
Cc: me@felipebalbi.com, linux-omap@vger.kernel.org,
david-b@pacbell.net, felipe.balbi@nokia.com
* Gupta, Ajay Kumar <ajay.gupta@ti.com> [090119 02:39]:
> > -----Original Message-----
> > From: Felipe Balbi [mailto:me@felipebalbi.com]
> > Sent: Tuesday, January 13, 2009 4:00 AM
> > To: Gupta, Ajay Kumar
> > Cc: linux-omap@vger.kernel.org; david-b@pacbell.net; felipe.balbi@nokia.com
> > Subject: Re: [PATCH] usb: musb: adding support for registering nop xceiv
> >
> > On Thu, Jan 08, 2009 at 04:23:56PM +0530, Ajay Kumar Gupta wrote:
> > > Adding support for registering nop usb transceiver for musb
> > > platforms. Tested with OMAP35xx EVM having OTG phy ISP1504
> > > which is autonomous and doesn't require any phy programming.
> > >
> > > Signed-off-by: Ajay Kumar Gupta <ajay.gupta@ti.com>
> >
> > Tony, if Dave is ok with the nop-xceiv, we can apply this to l-o and
> > people who doesn't use twl4030/tlw5030 xceiv will have to select this
> > driver.
>
> Hi David,
>
> Please review this one too.
According to Felipe this is in Greg's queue, so I'll apply this to
linux-omap to wait for it to fall down from mainline.
Tony
>
> Regards,
> Ajay
>
> >
> > > ---
> > > arch/arm/mach-omap2/usb-musb.c | 19 +++++++++++++++++++
> > > 1 files changed, 19 insertions(+), 0 deletions(-)
> > >
> > > diff --git a/arch/arm/mach-omap2/usb-musb.c b/arch/arm/mach-omap2/usb-musb.c
> > > index 61c5709..c202256 100644
> > > --- a/arch/arm/mach-omap2/usb-musb.c
> > > +++ b/arch/arm/mach-omap2/usb-musb.c
> > > @@ -155,10 +155,29 @@ static struct platform_device musb_device = {
> > > };
> > > #endif
> > >
> > > +#ifdef CONFIG_NOP_USB_XCEIV
> > > +static u64 nop_xceiv_dmamask = DMA_32BIT_MASK;
> > > +
> > > +static struct platform_device nop_xceiv_device = {
> > > + .name = "nop_usb_xceiv",
> > > + .id = -1,
> > > + .dev = {
> > > + .dma_mask = &nop_xceiv_dmamask,
> > > + .coherent_dma_mask = DMA_32BIT_MASK,
> > > + .platform_data = NULL,
> > > + },
> > > +};
> > > +#endif
> > >
> > > void __init usb_musb_init(void)
> > > {
> > > #ifdef CONFIG_USB_MUSB_SOC
> > > +#ifdef CONFIG_NOP_USB_XCEIV
> > > + if (platform_device_register(&nop_xceiv_device) < 0) {
> > > + printk(KERN_ERR "Unable to register NOP-XCEIV device\n");
> > > + return;
> > > + }
> > > +#endif
> > > if (platform_device_register(&musb_device) < 0) {
> > > printk(KERN_ERR "Unable to register HS-USB (MUSB) device\n");
> > > return;
> > > --
> > > 1.5.6
> > >
> > > --
> > > To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> > > the body of a message to majordomo@vger.kernel.org
> > > More majordomo info at http://vger.kernel.org/majordomo-info.html
> >
> > --
> > balbi
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] usb: musb: adding support for registering nop xceiv
2009-02-20 16:41 ` Tony Lindgren
@ 2009-02-20 16:43 ` Felipe Balbi
2009-02-20 22:06 ` David Brownell
1 sibling, 0 replies; 6+ messages in thread
From: Felipe Balbi @ 2009-02-20 16:43 UTC (permalink / raw)
To: Tony Lindgren
Cc: Gupta, Ajay Kumar, me@felipebalbi.com, linux-omap@vger.kernel.org,
david-b@pacbell.net, felipe.balbi@nokia.com
On Fri, Feb 20, 2009 at 08:41:40AM -0800, Tony Lindgren wrote:
> * Gupta, Ajay Kumar <ajay.gupta@ti.com> [090119 02:39]:
> > > -----Original Message-----
> > > From: Felipe Balbi [mailto:me@felipebalbi.com]
> > > Sent: Tuesday, January 13, 2009 4:00 AM
> > > To: Gupta, Ajay Kumar
> > > Cc: linux-omap@vger.kernel.org; david-b@pacbell.net; felipe.balbi@nokia.com
> > > Subject: Re: [PATCH] usb: musb: adding support for registering nop xceiv
> > >
> > > On Thu, Jan 08, 2009 at 04:23:56PM +0530, Ajay Kumar Gupta wrote:
> > > > Adding support for registering nop usb transceiver for musb
> > > > platforms. Tested with OMAP35xx EVM having OTG phy ISP1504
> > > > which is autonomous and doesn't require any phy programming.
> > > >
> > > > Signed-off-by: Ajay Kumar Gupta <ajay.gupta@ti.com>
> > >
> > > Tony, if Dave is ok with the nop-xceiv, we can apply this to l-o and
> > > people who doesn't use twl4030/tlw5030 xceiv will have to select this
> > > driver.
> >
> > Hi David,
> >
> > Please review this one too.
>
> According to Felipe this is in Greg's queue, so I'll apply this to
> linux-omap to wait for it to fall down from mainline.
well, the driver itself, not the usb-musb.c part. Well, this will help
boards with use ispXXXX transceivers to work :-)
--
balbi
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] usb: musb: adding support for registering nop xceiv
2009-02-20 16:41 ` Tony Lindgren
2009-02-20 16:43 ` Felipe Balbi
@ 2009-02-20 22:06 ` David Brownell
1 sibling, 0 replies; 6+ messages in thread
From: David Brownell @ 2009-02-20 22:06 UTC (permalink / raw)
To: Tony Lindgren
Cc: Gupta, Ajay Kumar, me@felipebalbi.com, linux-omap@vger.kernel.org,
felipe.balbi@nokia.com
On Friday 20 February 2009, Tony Lindgren wrote:
> >
> > Please review this one too.
>
> According to Felipe this is in Greg's queue, so I'll apply this to
> linux-omap to wait for it to fall down from mainline.
Yeah, I had some issues with it but it looks like the
simplest approach for now is to add patches on top of this.
- Dave
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2009-02-20 22:06 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-08 10:53 [PATCH] usb: musb: adding support for registering nop xceiv Ajay Kumar Gupta
2009-01-12 22:29 ` Felipe Balbi
2009-01-19 10:39 ` Gupta, Ajay Kumar
2009-02-20 16:41 ` Tony Lindgren
2009-02-20 16:43 ` Felipe Balbi
2009-02-20 22:06 ` David Brownell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox