* [PATCH v2] usb: musb: fix bug in musbhsdma programming
@ 2009-01-09 4:39 Ajay Kumar Gupta
2009-01-09 5:16 ` Gupta, Ajay Kumar
2009-01-12 22:26 ` Felipe Balbi
0 siblings, 2 replies; 5+ messages in thread
From: Ajay Kumar Gupta @ 2009-01-09 4:39 UTC (permalink / raw)
To: linux-omap; +Cc: david-b, felipe.balbi, Ajay Kumar Gupta
Mode bit should be set based on function parameter "mode" of
configure_channel() function.
Signed-off-by: Ajay Kumar Gupta <ajay.gupta@ti.com>
---
Original version of this patch is at,
http://marc.info/?l=linux-usb&m=123141793611158&w=2
drivers/usb/musb/musbhsdma.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/usb/musb/musbhsdma.c b/drivers/usb/musb/musbhsdma.c
index 75b15ce..8e44355 100644
--- a/drivers/usb/musb/musbhsdma.c
+++ b/drivers/usb/musb/musbhsdma.c
@@ -136,7 +136,7 @@ static void configure_channel(struct dma_channel *channel,
csr |= MUSB_HSDMA_BURSTMODE_INCR4;
csr |= (musb_channel->epnum << MUSB_HSDMA_ENDPOINT_SHIFT)
- | MUSB_HSDMA_MODE1
+ | mode ? MUSB_HSDMA_MODE1 : 0
| MUSB_HSDMA_ENABLE
| MUSB_HSDMA_IRQENABLE
| (musb_channel->transmit
--
1.5.6
^ permalink raw reply related [flat|nested] 5+ messages in thread
* RE: [PATCH v2] usb: musb: fix bug in musbhsdma programming
2009-01-09 4:39 [PATCH v2] usb: musb: fix bug in musbhsdma programming Ajay Kumar Gupta
@ 2009-01-09 5:16 ` Gupta, Ajay Kumar
2009-01-12 22:26 ` Felipe Balbi
1 sibling, 0 replies; 5+ messages in thread
From: Gupta, Ajay Kumar @ 2009-01-09 5:16 UTC (permalink / raw)
To: Gupta, Ajay Kumar, linux-omap@vger.kernel.org
Cc: david-b@pacbell.net, felipe.balbi@nokia.com
> diff --git a/drivers/usb/musb/musbhsdma.c b/drivers/usb/musb/musbhsdma.c
> index 75b15ce..8e44355 100644
> --- a/drivers/usb/musb/musbhsdma.c
> +++ b/drivers/usb/musb/musbhsdma.c
> @@ -136,7 +136,7 @@ static void configure_channel(struct dma_channel *channel,
> csr |= MUSB_HSDMA_BURSTMODE_INCR4;
>
> csr |= (musb_channel->epnum << MUSB_HSDMA_ENDPOINT_SHIFT)
> - | MUSB_HSDMA_MODE1
> + | mode ? MUSB_HSDMA_MODE1 : 0
Just found that above change should be within braces.
- | MUSB_HSDMA_MODE1
+ | (mode ? MUSB_HSDMA_MODE1 : 0)
-Ajay
> | MUSB_HSDMA_ENABLE
> | MUSB_HSDMA_IRQENABLE
> | (musb_channel->transmit
> --
> 1.5.6
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] usb: musb: fix bug in musbhsdma programming
2009-01-09 4:39 [PATCH v2] usb: musb: fix bug in musbhsdma programming Ajay Kumar Gupta
2009-01-09 5:16 ` Gupta, Ajay Kumar
@ 2009-01-12 22:26 ` Felipe Balbi
2009-01-13 4:31 ` Gupta, Ajay Kumar
1 sibling, 1 reply; 5+ messages in thread
From: Felipe Balbi @ 2009-01-12 22:26 UTC (permalink / raw)
To: Ajay Kumar Gupta; +Cc: linux-omap, david-b, felipe.balbi
On Fri, Jan 09, 2009 at 10:09:06AM +0530, Ajay Kumar Gupta wrote:
> Mode bit should be set based on function parameter "mode" of
> configure_channel() function.
>
> Signed-off-by: Ajay Kumar Gupta <ajay.gupta@ti.com>
Acked-by: Felipe Balbi <felipe.balbi@nokia.com>
> ---
> Original version of this patch is at,
> http://marc.info/?l=linux-usb&m=123141793611158&w=2
tony, this should go to l-o
>
> drivers/usb/musb/musbhsdma.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/usb/musb/musbhsdma.c b/drivers/usb/musb/musbhsdma.c
> index 75b15ce..8e44355 100644
> --- a/drivers/usb/musb/musbhsdma.c
> +++ b/drivers/usb/musb/musbhsdma.c
> @@ -136,7 +136,7 @@ static void configure_channel(struct dma_channel *channel,
> csr |= MUSB_HSDMA_BURSTMODE_INCR4;
>
> csr |= (musb_channel->epnum << MUSB_HSDMA_ENDPOINT_SHIFT)
> - | MUSB_HSDMA_MODE1
> + | mode ? MUSB_HSDMA_MODE1 : 0
> | MUSB_HSDMA_ENABLE
> | MUSB_HSDMA_IRQENABLE
> | (musb_channel->transmit
> --
> 1.5.6
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
balbi
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH v2] usb: musb: fix bug in musbhsdma programming
2009-01-12 22:26 ` Felipe Balbi
@ 2009-01-13 4:31 ` Gupta, Ajay Kumar
2009-01-13 12:09 ` Tony Lindgren
0 siblings, 1 reply; 5+ messages in thread
From: Gupta, Ajay Kumar @ 2009-01-13 4:31 UTC (permalink / raw)
To: me@felipebalbi.com
Cc: linux-omap@vger.kernel.org, david-b@pacbell.net,
felipe.balbi@nokia.com
> -----Original Message-----
> From: Felipe Balbi [mailto:me@felipebalbi.com]
> Sent: Tuesday, January 13, 2009 3:57 AM
> To: Gupta, Ajay Kumar
> Cc: linux-omap@vger.kernel.org; david-b@pacbell.net; felipe.balbi@nokia.com
> Subject: Re: [PATCH v2] usb: musb: fix bug in musbhsdma programming
>
> On Fri, Jan 09, 2009 at 10:09:06AM +0530, Ajay Kumar Gupta wrote:
> > Mode bit should be set based on function parameter "mode" of
> > configure_channel() function.
> >
> > Signed-off-by: Ajay Kumar Gupta <ajay.gupta@ti.com>
>
> Acked-by: Felipe Balbi <felipe.balbi@nokia.com>
>
> > ---
> > Original version of this patch is at,
> > http://marc.info/?l=linux-usb&m=123141793611158&w=2
>
> tony, this should go to l-o
Tony,
Please use below version refreshed against latest l-o git.
-Ajay
=========================== cut here ======================================
Mode bit should be set based on function parameter "mode" of
configure_channel() function.
Signed-off-by: Ajay Kumar Gupta <ajay.gupta@ti.com>
Acked-by: Felipe Balbi <felipe.balbi@nokia.com>
---
drivers/usb/musb/musbhsdma.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/usb/musb/musbhsdma.c b/drivers/usb/musb/musbhsdma.c index 75b15ce..4394bd3 100644
--- a/drivers/usb/musb/musbhsdma.c
+++ b/drivers/usb/musb/musbhsdma.c
@@ -136,7 +136,7 @@ static void configure_channel(struct dma_channel *channel,
csr |= MUSB_HSDMA_BURSTMODE_INCR4;
csr |= (musb_channel->epnum << MUSB_HSDMA_ENDPOINT_SHIFT)
- | MUSB_HSDMA_MODE1
+ | (mode ? MUSB_HSDMA_MODE1 : 0)
| MUSB_HSDMA_ENABLE
| MUSB_HSDMA_IRQENABLE
| (musb_channel->transmit
--
1.5.6
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] usb: musb: fix bug in musbhsdma programming
2009-01-13 4:31 ` Gupta, Ajay Kumar
@ 2009-01-13 12:09 ` Tony Lindgren
0 siblings, 0 replies; 5+ messages in thread
From: Tony Lindgren @ 2009-01-13 12:09 UTC (permalink / raw)
To: Gupta, Ajay Kumar
Cc: me@felipebalbi.com, linux-omap@vger.kernel.org,
david-b@pacbell.net, felipe.balbi@nokia.com
* Gupta, Ajay Kumar <ajay.gupta@ti.com> [090113 06:33]:
> > -----Original Message-----
> > From: Felipe Balbi [mailto:me@felipebalbi.com]
> > Sent: Tuesday, January 13, 2009 3:57 AM
> > To: Gupta, Ajay Kumar
> > Cc: linux-omap@vger.kernel.org; david-b@pacbell.net; felipe.balbi@nokia.com
> > Subject: Re: [PATCH v2] usb: musb: fix bug in musbhsdma programming
> >
> > On Fri, Jan 09, 2009 at 10:09:06AM +0530, Ajay Kumar Gupta wrote:
> > > Mode bit should be set based on function parameter "mode" of
> > > configure_channel() function.
> > >
> > > Signed-off-by: Ajay Kumar Gupta <ajay.gupta@ti.com>
> >
> > Acked-by: Felipe Balbi <felipe.balbi@nokia.com>
> >
> > > ---
> > > Original version of this patch is at,
> > > http://marc.info/?l=linux-usb&m=123141793611158&w=2
> >
> > tony, this should go to l-o
>
> Tony,
>
> Please use below version refreshed against latest l-o git.
Thanks, pushing today.
Tony
>
> -Ajay
> =========================== cut here ======================================
> Mode bit should be set based on function parameter "mode" of
> configure_channel() function.
>
> Signed-off-by: Ajay Kumar Gupta <ajay.gupta@ti.com>
> Acked-by: Felipe Balbi <felipe.balbi@nokia.com>
> ---
> drivers/usb/musb/musbhsdma.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/usb/musb/musbhsdma.c b/drivers/usb/musb/musbhsdma.c index 75b15ce..4394bd3 100644
> --- a/drivers/usb/musb/musbhsdma.c
> +++ b/drivers/usb/musb/musbhsdma.c
> @@ -136,7 +136,7 @@ static void configure_channel(struct dma_channel *channel,
> csr |= MUSB_HSDMA_BURSTMODE_INCR4;
>
> csr |= (musb_channel->epnum << MUSB_HSDMA_ENDPOINT_SHIFT)
> - | MUSB_HSDMA_MODE1
> + | (mode ? MUSB_HSDMA_MODE1 : 0)
> | MUSB_HSDMA_ENABLE
> | MUSB_HSDMA_IRQENABLE
> | (musb_channel->transmit
> --
> 1.5.6
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-01-13 12:09 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-09 4:39 [PATCH v2] usb: musb: fix bug in musbhsdma programming Ajay Kumar Gupta
2009-01-09 5:16 ` Gupta, Ajay Kumar
2009-01-12 22:26 ` Felipe Balbi
2009-01-13 4:31 ` Gupta, Ajay Kumar
2009-01-13 12:09 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox