public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: David Brownell <david-b@pacbell.net>
Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>,
	linux-arm-kernel@lists.arm.linux.org.uk,
	linux-omap@vger.kernel.org
Subject: Re: git-pull request for omap-fixes for 2.6.29-rc1 (Re: [PATCH 00/10] Omap fixes for 2.6.29-rc1)
Date: Sun, 18 Jan 2009 13:40:19 +0200	[thread overview]
Message-ID: <20090118114013.GD7976@atomide.com> (raw)
In-Reply-To: <200901171247.18153.david-b@pacbell.net>

* David Brownell <david-b@pacbell.net> [090117 22:47]:
> On Saturday 17 January 2009, Russell King - ARM Linux wrote:
> > Now that akpm pushed the usb_port_suspend() fix upstream, we move on
> > to the next breakage found by kautobuild, which for n770_defconfig is:
> > 
> > drivers/built-in.o: In function `ohci_omap_init':
> > hid-quirks.c:(.text+0x6c608): undefined reference to `otg_get_transceiver'
> > drivers/built-in.o: In function `omap_udc_probe':
> > hid-quirks.c:(.init.text+0x34c0): undefined reference to `otg_get_transceiver'
> > hid-quirks.c:(.init.text+0x3d40): undefined reference to `otg_put_transceiver'
> 
> Does this fix that problem?

Yes, that fixes it, Acked-by: Tony Lindgren <tony@atomide.com>.
I assume it will get merged via the USB tree, so not adding it to
omap-fixes.

FYI, I'll be flying back home soon so I probably won't be online 
until Tuesday at some point in case there are other fixes needed.

Tony


> ---
>  drivers/usb/host/Kconfig |    1 +
>  drivers/usb/otg/Kconfig  |    4 ++--
>  2 files changed, 3 insertions(+), 2 deletions(-)
> 
> --- a/drivers/usb/host/Kconfig
> +++ b/drivers/usb/host/Kconfig
> @@ -140,6 +140,7 @@ config USB_OHCI_HCD
>  	tristate "OHCI HCD support"
>  	depends on USB && USB_ARCH_HAS_OHCI
>  	select ISP1301_OMAP if MACH_OMAP_H2 || MACH_OMAP_H3
> +	select USB_OTG_UTILS if ARCH_OMAP
>  	---help---
>  	  The Open Host Controller Interface (OHCI) is a standard for accessing
>  	  USB 1.1 host controller hardware.  It does more in hardware than Intel's
> --- a/drivers/usb/otg/Kconfig
> +++ b/drivers/usb/otg/Kconfig
> @@ -6,14 +6,14 @@
>  
>  comment "OTG and related infrastructure"
>  
> -if USB || USB_GADGET
> -
>  config USB_OTG_UTILS
>  	bool
>  	help
>  	  Select this to make sure the build includes objects from
>  	  the OTG infrastructure directory.
>  
> +if USB || USB_GADGET
> +
>  #
>  # USB Transceiver Drivers
>  #
> 

  reply	other threads:[~2009-01-18 11:40 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-12 14:37 [PATCH 00/10] Omap fixes for 2.6.29-rc1 Tony Lindgren
2009-01-12 14:38 ` [PATCH 01/10] ARM: OMAP: Fix compile for various McBSP Tony Lindgren
2009-01-12 14:39 ` [PATCH 02/10] ARM: OMAP: Fix compile for palmte Tony Lindgren
2009-01-12 14:41 ` [PATCH 03/10] ARM: OMAP: Fix gpio by switching to generic gpio calls, v2 Tony Lindgren
2009-01-12 14:42 ` [PATCH 04/10] ARM: OMAP: Fix compile for beagle Tony Lindgren
2009-01-12 14:43 ` [PATCH 05/10] ARM: OMAP: Fix gpio.c compile on 15xx with CONFIG_DEBUGFS Tony Lindgren
2009-01-12 14:44 ` [PATCH 06/10] ARM: OMAP: Fix DMA CCR programming for request line > 63 Tony Lindgren
2009-01-12 14:59   ` Gadiyar, Anand
2009-01-12 15:35     ` Tony Lindgren
2009-01-12 15:58       ` Russell King - ARM Linux
2009-01-12 16:01       ` Russell King - ARM Linux
2009-01-12 16:10         ` [PATCH 06/10] ARM: OMAP: Fix DMA CCR programming for request line > 63, v2 Tony Lindgren
2009-01-12 16:16           ` Russell King - ARM Linux
2009-01-12 16:40             ` Tony Lindgren
2009-01-12 16:42               ` Russell King - ARM Linux
2009-01-15 12:08                 ` Tony Lindgren
2009-01-12 14:46 ` [PATCH 07/10] ARM: OMAP: remove duplicated #include's Tony Lindgren
2009-01-12 14:47 ` [PATCH 08/10] ARM: OMAP: Fix OSK ASoC by registering I2C board info for tlvaic23 Tony Lindgren
2009-01-12 14:48 ` [PATCH 09/10] ARM: OMAP: Fix ASoC by enabling writes to XCCR and RCCR McBSP registers Tony Lindgren
2009-01-12 14:50 ` [PATCH 10/10] ARM: OMAP: Remove unused platform devices for old ALSA code Tony Lindgren
2009-01-15 12:11   ` Tony Lindgren
2009-01-15 13:10     ` [PATCH 10/10] ARM: OMAP: Remove unused platform devices, v3 Tony Lindgren
2009-01-15 12:13   ` [PATCH 11/10] ARM: OMAP: Fix compile for h3 MMC Tony Lindgren
2009-01-13 14:35 ` git-pull request for omap-fixes for 2.6.29-rc1 (Re: [PATCH 00/10] Omap fixes for 2.6.29-rc1) Tony Lindgren
2009-01-15 10:37   ` Russell King - ARM Linux
2009-01-15 11:13     ` David Brownell
2009-01-15 11:26     ` Tony Lindgren
2009-01-15 12:40       ` Russell King - ARM Linux
2009-01-15 13:15         ` Felipe Balbi
2009-01-15 13:34           ` Russell King - ARM Linux
2009-01-15 14:49             ` Alan Stern
2009-01-15 15:16               ` Russell King - ARM Linux
2009-01-15 13:37         ` Tony Lindgren
2009-01-15 13:49           ` Russell King - ARM Linux
2009-01-17 14:26             ` Russell King - ARM Linux
2009-01-17 20:47               ` David Brownell
2009-01-18 11:40                 ` Tony Lindgren [this message]
2009-01-18 11:42                   ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090118114013.GD7976@atomide.com \
    --to=tony@atomide.com \
    --cc=david-b@pacbell.net \
    --cc=linux-arm-kernel@lists.arm.linux.org.uk \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox