Beagle defconfig broken in mainline

Beagle defconfig broken in mainline

[Gadiyar, Anand]

I'm not sure if this has been reported before. I just tried compiling mainline for the beagleboard and got this error.

- Anand

  CC      arch/arm/mach-omap2/board-omap3beagle.o
arch/arm/mach-omap2/board-omap3beagle.c: In function 'beagle_twl_gpio_setup':
arch/arm/mach-omap2/board-omap3beagle.c:132: error: 'TWL4030_GPIO_MAX' undeclared (first use in this function)
arch/arm/mach-omap2/board-omap3beagle.c:132: error: (Each undeclared identifier is reported only once
arch/arm/mach-omap2/board-omap3beagle.c:132: error: for each function it appears in.)
arch/arm/mach-omap2/board-omap3beagle.c: At top level:
arch/arm/mach-omap2/board-omap3beagle.c:141: error: variable 'beagle_gpio_data' has initializer but incomplete type
arch/arm/mach-omap2/board-omap3beagle.c:142: error: unknown field 'gpio_base' specified in initializer
arch/arm/mach-omap2/board-omap3beagle.c:142: warning: excess elements in struct initializer
arch/arm/mach-omap2/board-omap3beagle.c:142: warning: (near initialization for 'beagle_gpio_data')
arch/arm/mach-omap2/board-omap3beagle.c:143: error: unknown field 'irq_base' specified in initializer
arch/arm/mach-omap2/board-omap3beagle.c:143: warning: excess elements in struct initializer
arch/arm/mach-omap2/board-omap3beagle.c:143: warning: (near initialization for 'beagle_gpio_data')
arch/arm/mach-omap2/board-omap3beagle.c:144: error: unknown field 'irq_end' specified in initializer
arch/arm/mach-omap2/board-omap3beagle.c:144: warning: excess elements in struct initializer
arch/arm/mach-omap2/board-omap3beagle.c:144: warning: (near initialization for 'beagle_gpio_data')
arch/arm/mach-omap2/board-omap3beagle.c:145: error: unknown field 'use_leds' specified in initializer
arch/arm/mach-omap2/board-omap3beagle.c:145: warning: excess elements in struct initializer
arch/arm/mach-omap2/board-omap3beagle.c:145: warning: (near initialization for 'beagle_gpio_data')
arch/arm/mach-omap2/board-omap3beagle.c:146: error: unknown field 'pullups' specified in initializer
arch/arm/mach-omap2/board-omap3beagle.c:146: warning: excess elements in struct initializer
arch/arm/mach-omap2/board-omap3beagle.c:146: warning: (near initialization for 'beagle_gpio_data')
arch/arm/mach-omap2/board-omap3beagle.c:147: error: unknown field 'pulldowns' specified in initializer
arch/arm/mach-omap2/board-omap3beagle.c:148: warning: excess elements in struct initializer
arch/arm/mach-omap2/board-omap3beagle.c:148: warning: (near initialization for 'beagle_gpio_data')
arch/arm/mach-omap2/board-omap3beagle.c:149: error: unknown field 'setup' specified in initializer
arch/arm/mach-omap2/board-omap3beagle.c:149: warning: excess elements in struct initializer
arch/arm/mach-omap2/board-omap3beagle.c:149: warning: (near initialization for 'beagle_gpio_data')
arch/arm/mach-omap2/board-omap3beagle.c:152: error: variable 'beagle_twldata' has initializer but incomplete type
arch/arm/mach-omap2/board-omap3beagle.c:153: error: unknown field 'irq_base' specified in initializer
arch/arm/mach-omap2/board-omap3beagle.c:153: warning: excess elements in struct initializer
arch/arm/mach-omap2/board-omap3beagle.c:153: warning: (near initialization for 'beagle_twldata')
arch/arm/mach-omap2/board-omap3beagle.c:154: error: unknown field 'irq_end' specified in initializer
arch/arm/mach-omap2/board-omap3beagle.c:154: warning: excess elements in struct initializer
arch/arm/mach-omap2/board-omap3beagle.c:154: warning: (near initialization for 'beagle_twldata')
arch/arm/mach-omap2/board-omap3beagle.c:157: error: unknown field 'gpio' specified in initializer
arch/arm/mach-omap2/board-omap3beagle.c:157: warning: excess elements in struct initializer
arch/arm/mach-omap2/board-omap3beagle.c:157: warning: (near initialization for 'beagle_twldata')
arch/arm/mach-omap2/board-omap3beagle.c: In function 'omap3_beagle_init':
arch/arm/mach-omap2/board-omap3beagle.c:308: error: 'gpio' undeclared (first use in this function)
make[1]: *** [arch/arm/mach-omap2/board-omap3beagle.o] Error 1
make: *** [arch/arm/mach-omap2] Error 2

Re: Beagle defconfig broken in mainline

[David Brownell]

From: David Brownell <dbrownell@users.sourceforge.net>
Subject: arch/arm/mach-omap2/board-omap3beagle.c buildfix

  CC      arch/arm/mach-omap2/board-omap3beagle.o
arch/arm/mach-omap2/board-omap3beagle.c: In function 'beagle_twl_gpio_setup':
arch/arm/mach-omap2/board-omap3beagle.c:132: error: 'TWL4030_GPIO_MAX' undeclared (first use in this function)
... many errors ...
arch/arm/mach-omap2/board-omap3beagle.c:308: error: 'gpio' undeclared (first use in this function)
make[1]: *** [arch/arm/mach-omap2/board-omap3beagle.o] Error 1

Reported-by: Anand Gadiyar <gadiyar@ti.com>
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
---
Against MAINLINE 2.6.29-rc2

 arch/arm/mach-omap2/board-omap3beagle.c |    9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

--- a/arch/arm/mach-omap2/board-omap3beagle.c
+++ b/arch/arm/mach-omap2/board-omap3beagle.c
@@ -28,6 +28,8 @@
 #include <linux/mtd/partitions.h>
 #include <linux/mtd/nand.h>
 
+#include <linux/i2c/twl4030.h>
+
 #include <mach/hardware.h>
 #include <asm/mach-types.h>
 #include <asm/mach/arch.h>
@@ -120,6 +122,9 @@ static int beagle_twl_gpio_setup(struct 
 		unsigned gpio, unsigned ngpio)
 {
 	/* gpio + 0 is "mmc0_cd" (input/IRQ) */
+	omap_cfg_reg(AH8_34XX_GPIO29);
+	mmc[0].gpio_cd = gpio + 0;
+	twl4030_mmc_init(mmc);
 
 	/* REVISIT: need ehci-omap hooks for external VBUS
 	 * power switch and overcurrent detect
@@ -304,10 +309,6 @@ static void __init omap3_beagle_init(voi
 	omap_board_config_size = ARRAY_SIZE(omap3_beagle_config);
 	omap_serial_init();
 
-	omap_cfg_reg(AH8_34XX_GPIO29);
-	mmc[0].gpio_cd = gpio + 0;
-	twl4030_mmc_init(mmc);
-
 	omap_cfg_reg(J25_34XX_GPIO170);
 	gpio_request(170, "DVI_nPD");
 	/* REVISIT leave DVI powered down until it's needed ... */

Re: Beagle defconfig broken in mainline

[Tony Lindgren]

* David Brownell <david-b@pacbell.net> [090118 13:57]:
> From: David Brownell <dbrownell@users.sourceforge.net>
> Subject: arch/arm/mach-omap2/board-omap3beagle.c buildfix
> 
>   CC      arch/arm/mach-omap2/board-omap3beagle.o
> arch/arm/mach-omap2/board-omap3beagle.c: In function 'beagle_twl_gpio_setup':
> arch/arm/mach-omap2/board-omap3beagle.c:132: error: 'TWL4030_GPIO_MAX' undeclared (first use in this function)
> ... many errors ...
> arch/arm/mach-omap2/board-omap3beagle.c:308: error: 'gpio' undeclared (first use in this function)
> make[1]: *** [arch/arm/mach-omap2/board-omap3beagle.o] Error 1

Similar patch (and other compile fixes) is already queued up via
omap-fixes branch, should get into the mainline within next few days.

Tony

> Reported-by: Anand Gadiyar <gadiyar@ti.com>
> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
> ---
> Against MAINLINE 2.6.29-rc2
> 
>  arch/arm/mach-omap2/board-omap3beagle.c |    9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> --- a/arch/arm/mach-omap2/board-omap3beagle.c
> +++ b/arch/arm/mach-omap2/board-omap3beagle.c
> @@ -28,6 +28,8 @@
>  #include <linux/mtd/partitions.h>
>  #include <linux/mtd/nand.h>
>  
> +#include <linux/i2c/twl4030.h>
> +
>  #include <mach/hardware.h>
>  #include <asm/mach-types.h>
>  #include <asm/mach/arch.h>
> @@ -120,6 +122,9 @@ static int beagle_twl_gpio_setup(struct 
>  		unsigned gpio, unsigned ngpio)
>  {
>  	/* gpio + 0 is "mmc0_cd" (input/IRQ) */
> +	omap_cfg_reg(AH8_34XX_GPIO29);
> +	mmc[0].gpio_cd = gpio + 0;
> +	twl4030_mmc_init(mmc);
>  
>  	/* REVISIT: need ehci-omap hooks for external VBUS
>  	 * power switch and overcurrent detect
> @@ -304,10 +309,6 @@ static void __init omap3_beagle_init(voi
>  	omap_board_config_size = ARRAY_SIZE(omap3_beagle_config);
>  	omap_serial_init();
>  
> -	omap_cfg_reg(AH8_34XX_GPIO29);
> -	mmc[0].gpio_cd = gpio + 0;
> -	twl4030_mmc_init(mmc);
> -
>  	omap_cfg_reg(J25_34XX_GPIO170);
>  	gpio_request(170, "DVI_nPD");
>  	/* REVISIT leave DVI powered down until it's needed ... */
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html