From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: "stanley.miao" <stanley.miao@windriver.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: BUG: LDP - smc911x region too small
Date: Tue, 20 Jan 2009 08:31:21 +0000 [thread overview]
Message-ID: <20090120083121.GA11157@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1232433403.31748.8.camel@localhost>
On Tue, Jan 20, 2009 at 02:36:43PM +0800, stanley.miao wrote:
> On Mon, 2009-01-19 at 22:37 +0000, Russell King - ARM Linux wrote:
> > At the moment:
> >
> > ldp_smc911x_resources[0].start = cs_mem_base + 0x0;
> > ldp_smc911x_resources[0].end = cs_mem_base + 0xf;
> >
> > However, the SMC911x driver wants to claim 256 bytes from this region.
> > Indeed, its register set definitions appears to indicate that its needs
> > more than 16 bytes of address space.
> >
> > So, the question is what is the right fix?
> >
> > Unfortunately, fixing this will cause problems with the SMSC911x patches,
> > so I'd like to get an answer on this sooner rather than later please.
>
> Here should be 0x100. Fixing this won't cause problems with smsc911x
> patches.
Yes it will - if it gets fixed in the -rc series for the smc911x driver
your patches will conflict.
There's more which needs fixing though - no platform data is being passed
so the smc911x driver still fails to initialise.
next prev parent reply other threads:[~2009-01-20 8:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-19 22:37 BUG: LDP - smc911x region too small Russell King - ARM Linux
2009-01-20 6:36 ` stanley.miao
2009-01-20 8:31 ` Russell King - ARM Linux [this message]
2009-02-02 22:41 ` Woodruff, Richard
2009-02-03 9:01 ` stanley.miao
2009-02-03 9:00 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090120083121.GA11157@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-omap@vger.kernel.org \
--cc=stanley.miao@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox