Re: [PATCH] usb: musb: adding nop usb transceiver

[David Brownell <david-b@pacbell.net>]

On Thursday 08 January 2009, Ajay Kumar Gupta wrote:
> OP transceiver is used by all the usb transceiver which are mostly
> autonomous and doesn't require any programming or which are built
> into the usb ip itself.NOP transceiver only allocates the memory
> for struct xceiv and calls otg_set_transceiver() so function call
> to otg_get_transceiver() will return a valid ransceiver.
> 
> NOP transceiver device is required to be registered using
> platform_device_register() in platform files.
> 
> Signed-off-by: Ajay Kumar Gupta <ajay.gupta@ti.com>

We'll need something like this, yes.

This one looks to need a bit of tweaking yet though ...
probably that could be done after merge.  The state can
need changing after one of the drivers is unregistered;
using __exit not __devexit is likely wrong (especially
given your MUSB patchlet); xceiv_to_nop() should be
an inline function; check otg_set_transceiver() value;
don't bother with dev_info(); and I'm not quite sure
of the methods.

Plus I think it's probably best to include a utility
that board init code can call to register the NOP
transceiver device ... instead of cloning that bit of
code (in your second patch) into every board-*.c file
that needs it.

- Dave