From: Felipe Balbi <me-uiRdBs8odbtmTBlB0Cgj/Q@public.gmane.org>
To: David Brownell <david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
Cc: felipe.balbi-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org,
Ajay Kumar Gupta <ajay.gupta-l0cyMroinI0@public.gmane.org>,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] usb: musb: fix bug in musbhsdma programming
Date: Fri, 23 Jan 2009 20:38:14 +0200 [thread overview]
Message-ID: <20090123183814.GV440@frodo> (raw)
In-Reply-To: <200901231036.04376.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
On Fri, Jan 23, 2009 at 10:36:04AM -0800, David Brownell wrote:
> On Friday 23 January 2009, Felipe Balbi wrote:
> > On Thu, Jan 08, 2009 at 06:01:36PM +0530, Ajay Kumar Gupta wrote:
> > > Mode bit should be set based on function parameter "mode" of
> > > configure_channel() function.
> > >
> > > Signed-off-by: Ajay Kumar Gupta <ajay.gupta-l0cyMroinI0@public.gmane.org>
> >
> > Acked-by: Felipe Balbi <felipe.balbi-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
>
> NAK -- interpretation of the MODE parameter is correct
> (though it's not clear to me that the callers set it right),
> but this won't apply to current GIT since the code differs.
hmmm.. don't get what you mean. If mode parameter in channel_program()
is true, that means channel->desired_mode should be true and we're
trying to kick mode1 dma, isn't it ??
But true, should be re-issued
--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-01-23 18:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-08 12:31 [PATCH] usb: musb: fix bug in musbhsdma programming Ajay Kumar Gupta
2009-01-23 10:18 ` Felipe Balbi
2009-01-23 18:36 ` David Brownell
[not found] ` <200901231036.04376.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
2009-01-23 18:38 ` Felipe Balbi [this message]
2009-01-23 18:50 ` David Brownell
2009-01-24 3:04 ` Gupta, Ajay Kumar
[not found] ` <19F8576C6E063C45BE387C64729E739403FA6CCD3A-/tLxBxkBPtCIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2009-01-24 4:31 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090123183814.GV440@frodo \
--to=me-uirdbs8odbtmtblb0cgj/q@public.gmane.org \
--cc=ajay.gupta-l0cyMroinI0@public.gmane.org \
--cc=david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org \
--cc=felipe.balbi-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox