* [PATCH 0/3] Hacks to make Nokia N800 compile
@ 2009-01-22 13:18 Kalle Valo
2009-01-22 13:19 ` [PATCH 1/3] n800-bt: include board-nokia.h Kalle Valo
` (3 more replies)
0 siblings, 4 replies; 22+ messages in thread
From: Kalle Valo @ 2009-01-22 13:18 UTC (permalink / raw)
To: linux-omap
In currently linux-omap tree n800_defconfig doesn't compile because of few
compiler and linker errors. Here are the fixes/hacks which I use. I'll send
them in case anyone else is interested them.
---
Kalle Valo (3):
Disable linux-omap version of menelaus
tsub6010: fix omap compile
n800-bt: include board-nokia.h
arch/arm/mach-omap2/board-n800-bt.c | 1 +
drivers/i2c/chips/Makefile | 1 -
drivers/usb/musb/tusb6010_omap.c | 4 ++--
3 files changed, 3 insertions(+), 3 deletions(-)
^ permalink raw reply [flat|nested] 22+ messages in thread* [PATCH 1/3] n800-bt: include board-nokia.h
2009-01-22 13:18 [PATCH 0/3] Hacks to make Nokia N800 compile Kalle Valo
@ 2009-01-22 13:19 ` Kalle Valo
2009-01-23 2:10 ` Tony Lindgren
2009-01-22 13:19 ` [PATCH 2/3] tsub6010: fix omap compile Kalle Valo
` (2 subsequent siblings)
3 siblings, 1 reply; 22+ messages in thread
From: Kalle Valo @ 2009-01-22 13:19 UTC (permalink / raw)
To: linux-omap
Fixes compilation error:
arch/arm/mach-omap2/board-n800-bt.c: In function 'n800_bt_init':
arch/arm/mach-omap2/board-n800-bt.c:36: error: 'OMAP_TAG_NOKIA_BT' undeclared (first use in this function)
arch/arm/mach-omap2/board-n800-bt.c:36: error: (Each undeclared identifier is reported only once
arch/arm/mach-omap2/board-n800-bt.c:36: error: for each function it appears in.)
arch/arm/mach-omap2/board-n800-bt.c:36: error: invalid application of 'sizeof' to incomplete type 'struct omap_bluetooth_config'
Signed-off-by: Kalle Valo <kalle.valo@nokia.com>
---
arch/arm/mach-omap2/board-n800-bt.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2/board-n800-bt.c b/arch/arm/mach-omap2/board-n800-bt.c
index 61afd2b..da3a7bb 100644
--- a/arch/arm/mach-omap2/board-n800-bt.c
+++ b/arch/arm/mach-omap2/board-n800-bt.c
@@ -22,6 +22,7 @@
#include <linux/kernel.h>
#include <linux/platform_device.h>
#include <mach/board.h>
+#include <mach/board-nokia.h>
static struct platform_device n800_bt_device = {
.name = "hci_h4p",
^ permalink raw reply related [flat|nested] 22+ messages in thread* Re: [PATCH 1/3] n800-bt: include board-nokia.h
2009-01-22 13:19 ` [PATCH 1/3] n800-bt: include board-nokia.h Kalle Valo
@ 2009-01-23 2:10 ` Tony Lindgren
0 siblings, 0 replies; 22+ messages in thread
From: Tony Lindgren @ 2009-01-23 2:10 UTC (permalink / raw)
To: Kalle Valo; +Cc: linux-omap
* Kalle Valo <kalle.valo@nokia.com> [090122 05:20]:
> Fixes compilation error:
>
> arch/arm/mach-omap2/board-n800-bt.c: In function 'n800_bt_init':
> arch/arm/mach-omap2/board-n800-bt.c:36: error: 'OMAP_TAG_NOKIA_BT' undeclared (first use in this function)
> arch/arm/mach-omap2/board-n800-bt.c:36: error: (Each undeclared identifier is reported only once
> arch/arm/mach-omap2/board-n800-bt.c:36: error: for each function it appears in.)
> arch/arm/mach-omap2/board-n800-bt.c:36: error: invalid application of 'sizeof' to incomplete type 'struct omap_bluetooth_config'
Thanks, pushing to l-o.
Tony
> Signed-off-by: Kalle Valo <kalle.valo@nokia.com>
> ---
>
> arch/arm/mach-omap2/board-n800-bt.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/board-n800-bt.c b/arch/arm/mach-omap2/board-n800-bt.c
> index 61afd2b..da3a7bb 100644
> --- a/arch/arm/mach-omap2/board-n800-bt.c
> +++ b/arch/arm/mach-omap2/board-n800-bt.c
> @@ -22,6 +22,7 @@
> #include <linux/kernel.h>
> #include <linux/platform_device.h>
> #include <mach/board.h>
> +#include <mach/board-nokia.h>
>
> static struct platform_device n800_bt_device = {
> .name = "hci_h4p",
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH 2/3] tsub6010: fix omap compile
2009-01-22 13:18 [PATCH 0/3] Hacks to make Nokia N800 compile Kalle Valo
2009-01-22 13:19 ` [PATCH 1/3] n800-bt: include board-nokia.h Kalle Valo
@ 2009-01-22 13:19 ` Kalle Valo
2009-01-23 2:10 ` Tony Lindgren
2009-01-22 13:19 ` [PATCH 3/3] Disable linux-omap version of menelaus Kalle Valo
2009-01-22 20:53 ` [PATCH 0/3] Hacks to make Nokia N800 compile green
3 siblings, 1 reply; 22+ messages in thread
From: Kalle Valo @ 2009-01-22 13:19 UTC (permalink / raw)
To: linux-omap
drivers/usb/musb/tusb6010_omap.c:18:26: error: asm/arch/dma.h: No such file or directory
drivers/usb/musb/tusb6010_omap.c:19:26: error: asm/arch/mux.h: No such file or directory
Signed-off-by: Kalle Valo <kalle.valo@nokia.com>
---
drivers/usb/musb/tusb6010_omap.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/musb/tusb6010_omap.c b/drivers/usb/musb/tusb6010_omap.c
index 52f7f29..7e073a0 100644
--- a/drivers/usb/musb/tusb6010_omap.c
+++ b/drivers/usb/musb/tusb6010_omap.c
@@ -15,8 +15,8 @@
#include <linux/usb.h>
#include <linux/platform_device.h>
#include <linux/dma-mapping.h>
-#include <asm/arch/dma.h>
-#include <asm/arch/mux.h>
+#include <mach/dma.h>
+#include <mach/mux.h>
#include "musb_core.h"
^ permalink raw reply related [flat|nested] 22+ messages in thread
* Re: [PATCH 2/3] tsub6010: fix omap compile
2009-01-22 13:19 ` [PATCH 2/3] tsub6010: fix omap compile Kalle Valo
@ 2009-01-23 2:10 ` Tony Lindgren
2009-01-23 12:14 ` Felipe Balbi
0 siblings, 1 reply; 22+ messages in thread
From: Tony Lindgren @ 2009-01-23 2:10 UTC (permalink / raw)
To: Kalle Valo; +Cc: linux-omap, Felipe Balbi
* Kalle Valo <kalle.valo@nokia.com> [090122 05:21]:
> drivers/usb/musb/tusb6010_omap.c:18:26: error: asm/arch/dma.h: No such file or directory
> drivers/usb/musb/tusb6010_omap.c:19:26: error: asm/arch/mux.h: No such file or directory
Not touching this, Felipe needs to queue this up via linux-usb list.
Tony
>
> Signed-off-by: Kalle Valo <kalle.valo@nokia.com>
> ---
>
> drivers/usb/musb/tusb6010_omap.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/musb/tusb6010_omap.c b/drivers/usb/musb/tusb6010_omap.c
> index 52f7f29..7e073a0 100644
> --- a/drivers/usb/musb/tusb6010_omap.c
> +++ b/drivers/usb/musb/tusb6010_omap.c
> @@ -15,8 +15,8 @@
> #include <linux/usb.h>
> #include <linux/platform_device.h>
> #include <linux/dma-mapping.h>
> -#include <asm/arch/dma.h>
> -#include <asm/arch/mux.h>
> +#include <mach/dma.h>
> +#include <mach/mux.h>
>
> #include "musb_core.h"
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH 2/3] tsub6010: fix omap compile
2009-01-23 2:10 ` Tony Lindgren
@ 2009-01-23 12:14 ` Felipe Balbi
2009-01-23 14:04 ` Kalle Valo
0 siblings, 1 reply; 22+ messages in thread
From: Felipe Balbi @ 2009-01-23 12:14 UTC (permalink / raw)
To: ext Tony Lindgren; +Cc: Kalle Valo, linux-omap, Felipe Balbi
On Thu, Jan 22, 2009 at 06:10:52PM -0800, Tony Lindgren wrote:
> * Kalle Valo <kalle.valo@nokia.com> [090122 05:21]:
> > drivers/usb/musb/tusb6010_omap.c:18:26: error: asm/arch/dma.h: No such file or directory
> > drivers/usb/musb/tusb6010_omap.c:19:26: error: asm/arch/mux.h: No such file or directory
>
> Not touching this, Felipe needs to queue this up via linux-usb list.
sure, kalle, could you resend to linux-usb@vger.kernel.org ??
also, sure to Cc me
--
balbi
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH 2/3] tsub6010: fix omap compile
2009-01-23 12:14 ` Felipe Balbi
@ 2009-01-23 14:04 ` Kalle Valo
2009-01-23 13:57 ` Felipe Balbi
0 siblings, 1 reply; 22+ messages in thread
From: Kalle Valo @ 2009-01-23 14:04 UTC (permalink / raw)
To: felipe.balbi; +Cc: Tony Lindgren, linux-omap
Felipe Balbi <felipe.balbi@nokia.com> writes:
> On Thu, Jan 22, 2009 at 06:10:52PM -0800, Tony Lindgren wrote:
>> * Kalle Valo <kalle.valo@nokia.com> [090122 05:21]:
>> > drivers/usb/musb/tusb6010_omap.c:18:26: error: asm/arch/dma.h: No such file or directory
>> > drivers/usb/musb/tusb6010_omap.c:19:26: error: asm/arch/mux.h: No such file or directory
>>
>> Not touching this, Felipe needs to queue this up via linux-usb list.
>
> sure, kalle, could you resend to linux-usb@vger.kernel.org ??
Ok, I will.
> also, sure to Cc me
Tá bom :)
--
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH 3/3] Disable linux-omap version of menelaus
2009-01-22 13:18 [PATCH 0/3] Hacks to make Nokia N800 compile Kalle Valo
2009-01-22 13:19 ` [PATCH 1/3] n800-bt: include board-nokia.h Kalle Valo
2009-01-22 13:19 ` [PATCH 2/3] tsub6010: fix omap compile Kalle Valo
@ 2009-01-22 13:19 ` Kalle Valo
2009-01-22 13:15 ` Felipe Balbi
2009-01-22 20:53 ` [PATCH 0/3] Hacks to make Nokia N800 compile green
3 siblings, 1 reply; 22+ messages in thread
From: Kalle Valo @ 2009-01-22 13:19 UTC (permalink / raw)
To: linux-omap
Fixes linker errors like this:
drivers/i2c/built-in.o: In function `menelaus_set_vdcdc':
lp5521.c:(.text+0x3910): multiple definition of `menelaus_set_vdcdc'
drivers/mfd/built-in.o:menelaus.c:(.text+0x95c): first defined here
drivers/i2c/built-in.o: In function `menelaus_set_vio':
lp5521.c:(.text+0x3990): multiple definition of `menelaus_set_vio'
Signed-off-by: Kalle Valo <kalle.valo@nokia.com>
---
drivers/i2c/chips/Makefile | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/i2c/chips/Makefile b/drivers/i2c/chips/Makefile
index b451369..d8bef8c 100644
--- a/drivers/i2c/chips/Makefile
+++ b/drivers/i2c/chips/Makefile
@@ -18,7 +18,6 @@ obj-$(CONFIG_SENSORS_PCA9539) += pca9539.o
obj-$(CONFIG_SENSORS_PCF8574) += pcf8574.o
obj-$(CONFIG_PCF8575) += pcf8575.o
obj-$(CONFIG_SENSORS_PCF8591) += pcf8591.o
-obj-$(CONFIG_MENELAUS) += menelaus.o
obj-$(CONFIG_SENSORS_TSL2550) += tsl2550.o
obj-$(CONFIG_TWL4030_POWEROFF) += twl4030-poweroff.o
obj-$(CONFIG_TWL4030_PWRBUTTON) += twl4030-pwrbutton.o
^ permalink raw reply related [flat|nested] 22+ messages in thread
* Re: [PATCH 3/3] Disable linux-omap version of menelaus
2009-01-22 13:19 ` [PATCH 3/3] Disable linux-omap version of menelaus Kalle Valo
@ 2009-01-22 13:15 ` Felipe Balbi
2009-01-23 2:23 ` Tony Lindgren
0 siblings, 1 reply; 22+ messages in thread
From: Felipe Balbi @ 2009-01-22 13:15 UTC (permalink / raw)
To: ext Kalle Valo; +Cc: linux-omap
On Thu, Jan 22, 2009 at 03:19:20PM +0200, Kalle Valo wrote:
> Fixes linker errors like this:
>
> drivers/i2c/built-in.o: In function `menelaus_set_vdcdc':
> lp5521.c:(.text+0x3910): multiple definition of `menelaus_set_vdcdc'
> drivers/mfd/built-in.o:menelaus.c:(.text+0x95c): first defined here
> drivers/i2c/built-in.o: In function `menelaus_set_vio':
> lp5521.c:(.text+0x3990): multiple definition of `menelaus_set_vio'
>
> Signed-off-by: Kalle Valo <kalle.valo@nokia.com>
> ---
>
> drivers/i2c/chips/Makefile | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/i2c/chips/Makefile b/drivers/i2c/chips/Makefile
> index b451369..d8bef8c 100644
> --- a/drivers/i2c/chips/Makefile
> +++ b/drivers/i2c/chips/Makefile
> @@ -18,7 +18,6 @@ obj-$(CONFIG_SENSORS_PCA9539) += pca9539.o
> obj-$(CONFIG_SENSORS_PCF8574) += pcf8574.o
> obj-$(CONFIG_PCF8575) += pcf8575.o
> obj-$(CONFIG_SENSORS_PCF8591) += pcf8591.o
> -obj-$(CONFIG_MENELAUS) += menelaus.o
and mmc is broken again
--
balbi
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH 3/3] Disable linux-omap version of menelaus
2009-01-22 13:15 ` Felipe Balbi
@ 2009-01-23 2:23 ` Tony Lindgren
2009-01-23 19:21 ` Felipe Balbi
2009-01-26 11:35 ` Kalle Valo
0 siblings, 2 replies; 22+ messages in thread
From: Tony Lindgren @ 2009-01-23 2:23 UTC (permalink / raw)
To: Felipe Balbi; +Cc: ext Kalle Valo, linux-omap
* Felipe Balbi <felipe.balbi@nokia.com> [090122 05:27]:
> On Thu, Jan 22, 2009 at 03:19:20PM +0200, Kalle Valo wrote:
> > Fixes linker errors like this:
> >
> > drivers/i2c/built-in.o: In function `menelaus_set_vdcdc':
> > lp5521.c:(.text+0x3910): multiple definition of `menelaus_set_vdcdc'
> > drivers/mfd/built-in.o:menelaus.c:(.text+0x95c): first defined here
> > drivers/i2c/built-in.o: In function `menelaus_set_vio':
> > lp5521.c:(.text+0x3990): multiple definition of `menelaus_set_vio'
> >
> > Signed-off-by: Kalle Valo <kalle.valo@nokia.com>
> > ---
> >
> > drivers/i2c/chips/Makefile | 1 -
> > 1 files changed, 0 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/i2c/chips/Makefile b/drivers/i2c/chips/Makefile
> > index b451369..d8bef8c 100644
> > --- a/drivers/i2c/chips/Makefile
> > +++ b/drivers/i2c/chips/Makefile
> > @@ -18,7 +18,6 @@ obj-$(CONFIG_SENSORS_PCA9539) += pca9539.o
> > obj-$(CONFIG_SENSORS_PCF8574) += pcf8574.o
> > obj-$(CONFIG_PCF8575) += pcf8575.o
> > obj-$(CONFIG_SENSORS_PCF8591) += pcf8591.o
> > -obj-$(CONFIG_MENELAUS) += menelaus.o
I'll also remove drivers/i2c/chips/menelaus.c.
> and mmc is broken again
Hmm..
Tony
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH 3/3] Disable linux-omap version of menelaus
2009-01-23 2:23 ` Tony Lindgren
@ 2009-01-23 19:21 ` Felipe Balbi
2009-01-23 19:23 ` Tony Lindgren
2009-01-26 11:35 ` Kalle Valo
1 sibling, 1 reply; 22+ messages in thread
From: Felipe Balbi @ 2009-01-23 19:21 UTC (permalink / raw)
To: Tony Lindgren; +Cc: Felipe Balbi, ext Kalle Valo, linux-omap
On Thu, Jan 22, 2009 at 06:23:34PM -0800, Tony Lindgren wrote:
> * Felipe Balbi <felipe.balbi@nokia.com> [090122 05:27]:
> > On Thu, Jan 22, 2009 at 03:19:20PM +0200, Kalle Valo wrote:
> > > Fixes linker errors like this:
> > >
> > > drivers/i2c/built-in.o: In function `menelaus_set_vdcdc':
> > > lp5521.c:(.text+0x3910): multiple definition of `menelaus_set_vdcdc'
> > > drivers/mfd/built-in.o:menelaus.c:(.text+0x95c): first defined here
> > > drivers/i2c/built-in.o: In function `menelaus_set_vio':
> > > lp5521.c:(.text+0x3990): multiple definition of `menelaus_set_vio'
> > >
> > > Signed-off-by: Kalle Valo <kalle.valo@nokia.com>
> > > ---
> > >
> > > drivers/i2c/chips/Makefile | 1 -
> > > 1 files changed, 0 insertions(+), 1 deletions(-)
> > >
> > > diff --git a/drivers/i2c/chips/Makefile b/drivers/i2c/chips/Makefile
> > > index b451369..d8bef8c 100644
> > > --- a/drivers/i2c/chips/Makefile
> > > +++ b/drivers/i2c/chips/Makefile
> > > @@ -18,7 +18,6 @@ obj-$(CONFIG_SENSORS_PCA9539) += pca9539.o
> > > obj-$(CONFIG_SENSORS_PCF8574) += pcf8574.o
> > > obj-$(CONFIG_PCF8575) += pcf8575.o
> > > obj-$(CONFIG_SENSORS_PCF8591) += pcf8591.o
> > > -obj-$(CONFIG_MENELAUS) += menelaus.o
>
> I'll also remove drivers/i2c/chips/menelaus.c.
why, did this driver make its way to mainline with a different name then
??
Where did Jean move it ?
--
balbi
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH 3/3] Disable linux-omap version of menelaus
2009-01-23 19:21 ` Felipe Balbi
@ 2009-01-23 19:23 ` Tony Lindgren
2009-01-23 19:27 ` Felipe Balbi
0 siblings, 1 reply; 22+ messages in thread
From: Tony Lindgren @ 2009-01-23 19:23 UTC (permalink / raw)
To: Felipe Balbi; +Cc: Felipe Balbi, ext Kalle Valo, linux-omap
* Felipe Balbi <me@felipebalbi.com> [090123 11:22]:
> On Thu, Jan 22, 2009 at 06:23:34PM -0800, Tony Lindgren wrote:
> > * Felipe Balbi <felipe.balbi@nokia.com> [090122 05:27]:
> > > On Thu, Jan 22, 2009 at 03:19:20PM +0200, Kalle Valo wrote:
> > > > Fixes linker errors like this:
> > > >
> > > > drivers/i2c/built-in.o: In function `menelaus_set_vdcdc':
> > > > lp5521.c:(.text+0x3910): multiple definition of `menelaus_set_vdcdc'
> > > > drivers/mfd/built-in.o:menelaus.c:(.text+0x95c): first defined here
> > > > drivers/i2c/built-in.o: In function `menelaus_set_vio':
> > > > lp5521.c:(.text+0x3990): multiple definition of `menelaus_set_vio'
> > > >
> > > > Signed-off-by: Kalle Valo <kalle.valo@nokia.com>
> > > > ---
> > > >
> > > > drivers/i2c/chips/Makefile | 1 -
> > > > 1 files changed, 0 insertions(+), 1 deletions(-)
> > > >
> > > > diff --git a/drivers/i2c/chips/Makefile b/drivers/i2c/chips/Makefile
> > > > index b451369..d8bef8c 100644
> > > > --- a/drivers/i2c/chips/Makefile
> > > > +++ b/drivers/i2c/chips/Makefile
> > > > @@ -18,7 +18,6 @@ obj-$(CONFIG_SENSORS_PCA9539) += pca9539.o
> > > > obj-$(CONFIG_SENSORS_PCF8574) += pcf8574.o
> > > > obj-$(CONFIG_PCF8575) += pcf8575.o
> > > > obj-$(CONFIG_SENSORS_PCF8591) += pcf8591.o
> > > > -obj-$(CONFIG_MENELAUS) += menelaus.o
> >
> > I'll also remove drivers/i2c/chips/menelaus.c.
>
> why, did this driver make its way to mainline with a different name then
> ??
>
> Where did Jean move it ?
Dave has been busy again.. 88e75cc347f66bc20e3c2b920431fc07253d69be.
Tony
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH 3/3] Disable linux-omap version of menelaus
2009-01-23 2:23 ` Tony Lindgren
2009-01-23 19:21 ` Felipe Balbi
@ 2009-01-26 11:35 ` Kalle Valo
2009-01-26 21:40 ` David Brownell
1 sibling, 1 reply; 22+ messages in thread
From: Kalle Valo @ 2009-01-26 11:35 UTC (permalink / raw)
To: Tony Lindgren; +Cc: Felipe Balbi, linux-omap
Tony Lindgren <tony@atomide.com> writes:
>> > diff --git a/drivers/i2c/chips/Makefile b/drivers/i2c/chips/Makefile
>> > index b451369..d8bef8c 100644
>> > --- a/drivers/i2c/chips/Makefile
>> > +++ b/drivers/i2c/chips/Makefile
>> > @@ -18,7 +18,6 @@ obj-$(CONFIG_SENSORS_PCA9539) += pca9539.o
>> > obj-$(CONFIG_SENSORS_PCF8574) += pcf8574.o
>> > obj-$(CONFIG_PCF8575) += pcf8575.o
>> > obj-$(CONFIG_SENSORS_PCF8591) += pcf8591.o
>> > -obj-$(CONFIG_MENELAUS) += menelaus.o
>
> I'll also remove drivers/i2c/chips/menelaus.c.
Thanks. It's nice to see drivers going to upstream.
--
Kalle Valo
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH 3/3] Disable linux-omap version of menelaus
2009-01-26 11:35 ` Kalle Valo
@ 2009-01-26 21:40 ` David Brownell
2009-01-26 21:52 ` Tony Lindgren
0 siblings, 1 reply; 22+ messages in thread
From: David Brownell @ 2009-01-26 21:40 UTC (permalink / raw)
To: Kalle Valo; +Cc: Tony Lindgren, Felipe Balbi, linux-omap
On Monday 26 January 2009, Kalle Valo wrote:
> > I'll also remove drivers/i2c/chips/menelaus.c.
>
> Thanks. It's nice to see drivers going to upstream.
That driver has been upstream for quite a long time now.
This change was just helping scrub drivers/i2c/chips,
since it's going away.
That means all drivers which the OMAP tree has in that
directory should be pushed upstream, or at least moved
to a better home, soon ... :)
- Dave
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH 3/3] Disable linux-omap version of menelaus
2009-01-26 21:40 ` David Brownell
@ 2009-01-26 21:52 ` Tony Lindgren
2009-01-26 23:17 ` David Brownell
0 siblings, 1 reply; 22+ messages in thread
From: Tony Lindgren @ 2009-01-26 21:52 UTC (permalink / raw)
To: David Brownell; +Cc: Kalle Valo, Felipe Balbi, linux-omap
* David Brownell <david-b@pacbell.net> [090126 13:41]:
> On Monday 26 January 2009, Kalle Valo wrote:
> > > I'll also remove drivers/i2c/chips/menelaus.c.
> >
> > Thanks. It's nice to see drivers going to upstream.
>
> That driver has been upstream for quite a long time now.
> This change was just helping scrub drivers/i2c/chips,
> since it's going away.
>
> That means all drivers which the OMAP tree has in that
> directory should be pushed upstream, or at least moved
> to a better home, soon ... :)
Or else we'll just remove them until somebody patches them back
against the mainline tree.
Tony
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH 3/3] Disable linux-omap version of menelaus
2009-01-26 21:52 ` Tony Lindgren
@ 2009-01-26 23:17 ` David Brownell
2009-01-26 23:19 ` Felipe Balbi
0 siblings, 1 reply; 22+ messages in thread
From: David Brownell @ 2009-01-26 23:17 UTC (permalink / raw)
To: Tony Lindgren; +Cc: Kalle Valo, Felipe Balbi, linux-omap
On Monday 26 January 2009, Tony Lindgren wrote:
> >
> > That means all drivers which the OMAP tree has in that
> > directory should be pushed upstream, or at least moved
> > to a better home, soon ... :)
>
> Or else we'll just remove them until somebody patches them back
> against the mainline tree.
Right:
- lp5521.c
- tsl2563.c
- twl4030-madc.c
- twl4030-poweroff.c
- twl4030-pwrbutton.c
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH 3/3] Disable linux-omap version of menelaus
2009-01-26 23:17 ` David Brownell
@ 2009-01-26 23:19 ` Felipe Balbi
2009-01-26 23:27 ` Tony Lindgren
0 siblings, 1 reply; 22+ messages in thread
From: Felipe Balbi @ 2009-01-26 23:19 UTC (permalink / raw)
To: David Brownell; +Cc: Tony Lindgren, Kalle Valo, Felipe Balbi, linux-omap
On Mon, Jan 26, 2009 at 03:17:03PM -0800, David Brownell wrote:
> On Monday 26 January 2009, Tony Lindgren wrote:
> > >
> > > That means all drivers which the OMAP tree has in that
> > > directory should be pushed upstream, or at least moved
> > > to a better home, soon ... :)
> >
> > Or else we'll just remove them until somebody patches them back
> > against the mainline tree.
>
> Right:
>
> - lp5521.c
> - tsl2563.c
at least these two I had patched them and moved to other locations,
looks the patches weren't applied.
--
balbi
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH 3/3] Disable linux-omap version of menelaus
2009-01-26 23:19 ` Felipe Balbi
@ 2009-01-26 23:27 ` Tony Lindgren
2009-01-26 23:31 ` Felipe Balbi
0 siblings, 1 reply; 22+ messages in thread
From: Tony Lindgren @ 2009-01-26 23:27 UTC (permalink / raw)
To: Felipe Balbi; +Cc: David Brownell, Kalle Valo, Felipe Balbi, linux-omap
* Felipe Balbi <me@felipebalbi.com> [090126 15:19]:
> On Mon, Jan 26, 2009 at 03:17:03PM -0800, David Brownell wrote:
> > On Monday 26 January 2009, Tony Lindgren wrote:
> > > >
> > > > That means all drivers which the OMAP tree has in that
> > > > directory should be pushed upstream, or at least moved
> > > > to a better home, soon ... :)
> > >
> > > Or else we'll just remove them until somebody patches them back
> > > against the mainline tree.
> >
> > Right:
> >
> > - lp5521.c
> > - tsl2563.c
>
> at least these two I had patched them and moved to other locations,
> looks the patches weren't applied.
Maybe try to send them to the right drivers lists for mainline
integration?
Tony
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH 3/3] Disable linux-omap version of menelaus
2009-01-26 23:27 ` Tony Lindgren
@ 2009-01-26 23:31 ` Felipe Balbi
0 siblings, 0 replies; 22+ messages in thread
From: Felipe Balbi @ 2009-01-26 23:31 UTC (permalink / raw)
To: Tony Lindgren
Cc: Felipe Balbi, David Brownell, Kalle Valo, Felipe Balbi,
linux-omap
On Mon, Jan 26, 2009 at 03:27:50PM -0800, Tony Lindgren wrote:
> * Felipe Balbi <me@felipebalbi.com> [090126 15:19]:
> > On Mon, Jan 26, 2009 at 03:17:03PM -0800, David Brownell wrote:
> > > On Monday 26 January 2009, Tony Lindgren wrote:
> > > > >
> > > > > That means all drivers which the OMAP tree has in that
> > > > > directory should be pushed upstream, or at least moved
> > > > > to a better home, soon ... :)
> > > >
> > > > Or else we'll just remove them until somebody patches them back
> > > > against the mainline tree.
> > >
> > > Right:
> > >
> > > - lp5521.c
> > > - tsl2563.c
> >
> > at least these two I had patched them and moved to other locations,
> > looks the patches weren't applied.
>
> Maybe try to send them to the right drivers lists for mainline
> integration?
but then you'd have to drop them from l-o ;-)
--
balbi
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH 0/3] Hacks to make Nokia N800 compile
2009-01-22 13:18 [PATCH 0/3] Hacks to make Nokia N800 compile Kalle Valo
` (2 preceding siblings ...)
2009-01-22 13:19 ` [PATCH 3/3] Disable linux-omap version of menelaus Kalle Valo
@ 2009-01-22 20:53 ` green
3 siblings, 0 replies; 22+ messages in thread
From: green @ 2009-01-22 20:53 UTC (permalink / raw)
To: linux-omap
[-- Attachment #1: Type: text/plain, Size: 303 bytes --]
On Thu, 2009-01-22, 022, Kalle Valo wrote:
> In currently linux-omap tree n800_defconfig doesn't compile because of few
> compiler and linker errors. Here are the fixes/hacks which I use. I'll send
> them in case anyone else is interested them.
Thanks; I hope to try this again soon on an N810.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 22+ messages in thread
end of thread, other threads:[~2009-01-26 23:32 UTC | newest]
Thread overview: 22+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-22 13:18 [PATCH 0/3] Hacks to make Nokia N800 compile Kalle Valo
2009-01-22 13:19 ` [PATCH 1/3] n800-bt: include board-nokia.h Kalle Valo
2009-01-23 2:10 ` Tony Lindgren
2009-01-22 13:19 ` [PATCH 2/3] tsub6010: fix omap compile Kalle Valo
2009-01-23 2:10 ` Tony Lindgren
2009-01-23 12:14 ` Felipe Balbi
2009-01-23 14:04 ` Kalle Valo
2009-01-23 13:57 ` Felipe Balbi
2009-01-22 13:19 ` [PATCH 3/3] Disable linux-omap version of menelaus Kalle Valo
2009-01-22 13:15 ` Felipe Balbi
2009-01-23 2:23 ` Tony Lindgren
2009-01-23 19:21 ` Felipe Balbi
2009-01-23 19:23 ` Tony Lindgren
2009-01-23 19:27 ` Felipe Balbi
2009-01-26 11:35 ` Kalle Valo
2009-01-26 21:40 ` David Brownell
2009-01-26 21:52 ` Tony Lindgren
2009-01-26 23:17 ` David Brownell
2009-01-26 23:19 ` Felipe Balbi
2009-01-26 23:27 ` Tony Lindgren
2009-01-26 23:31 ` Felipe Balbi
2009-01-22 20:53 ` [PATCH 0/3] Hacks to make Nokia N800 compile green
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox