Re: [PATCH] usb: musb: adding nop usb transceiver

[David Brownell <david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>]

On Thursday 29 January 2009, Gupta, Ajay Kumar wrote:
> > We'll need something like this, yes.
> > This one looks to need a bit of tweaking yet though ...
> > probably that could be done after merge.  
> 
> > The state can need changing after one of the drivers is unregistered;
> 
> I didn't get this comment.

Basically, that almost all of the OTG state machine must be
handled outside of this code.  It's a bit of a puzzle how to
partition that state machine between the drivers that need
to collaborate on it.  At this point I don't think there can
be a single model that applies everywhere ... but maybe one
could evolve over time.


> done. Added this nop_xceiv_register() which can be called from
> board-init files to register NOP.
> 
> Please review the modified patch version below.

Well, I count *two* patches.  :)

I'll tweak this one a bit.  It's pretty close.  That
registration function should have a usb_*() prefix
and not be declared in an MUSB-only header, since it
could potentially be used with other OTG hardware.

Thanks.

- Dave


--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html