public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Dominic Curran <dcurran@ti.com>
To: linux-omap <linux-omap@vger.kernel.org>
Cc: klimov.linux@gmail.com
Subject: [OMAPZOOM][PATCH] ISP: Fix printk's error messages.
Date: Mon, 2 Feb 2009 11:32:49 -0600	[thread overview]
Message-ID: <200902021132.50290.dcurran@ti.com> (raw)

From: Dominic Curran <dcurran@ti.com>
Subject: [OMAPZOOM][PATCH] ISP: Fix printk's error messages.

This patch adds CRLF characters to some printk's.
Added 'ISP_ERR' at beginning of message a thats how other printks are formated in 
this module.
Reported-by: Alexey Klimov <klimov.linux@gmail.com>

Signed-off-by: Dominic Curran <dcurran@ti.com>
---
 drivers/media/video/isp/isp.c |    7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

Index: omapzoom04/drivers/media/video/isp/isp.c
===================================================================
--- omapzoom04.orig/drivers/media/video/isp/isp.c
+++ omapzoom04/drivers/media/video/isp/isp.c
@@ -1175,13 +1175,14 @@ u32 isp_buf_allocation(void)
 	buff_addr = (void *) vmalloc(ISP_BUFFER_MAX_SIZE);
 
 	if (!buff_addr) {
-		printk(KERN_ERR "Cannot allocate memory ");
+		printk(KERN_ERR "ISP_ERR: Cannot allocate "
+			"ISP_WORKAROUND memory\n");
 		return -ENOMEM;
 	}
 
 	sglist_alloc = videobuf_vmalloc_to_sg(buff_addr, ISP_BUFFER_MAX_PAGES);
 	if (!sglist_alloc) {
-		printk(KERN_ERR "videobuf_vmalloc_to_sg error");
+		printk(KERN_ERR "ISP_ERR: videobuf_vmalloc_to_sg failed\n");
 		return -ENOMEM;
 	}
 	num_sc = dma_map_sg(NULL, sglist_alloc, ISP_BUFFER_MAX_PAGES, 1);
@@ -1196,7 +1197,7 @@ u32 isp_buf_mmap(void)
 {
 	buff_addr_mapped = ispmmu_map_sg(sglist_alloc, ISP_BUFFER_MAX_PAGES);
 	if (!buff_addr_mapped) {
-		printk(KERN_ERR "ispmmu_map_sg mapping failed ");
+		printk(KERN_ERR "ISP_ERR: ispmmu_map_sg mapping failed\n");
 		return -ENOMEM;
 	}
 	isppreview_set_outaddr(buff_addr_mapped);

                 reply	other threads:[~2009-02-02 17:33 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200902021132.50290.dcurran@ti.com \
    --to=dcurran@ti.com \
    --cc=klimov.linux@gmail.com \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox