From: David Brownell <david-b@pacbell.net>
To: Joonyoung Shim <dofmind@gmail.com>
Cc: Tony Lindgren <tony@atomide.com>,
linux-arm-kernel@lists.arm.linux.org.uk,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH] twl4030-gpio: Fix getting the value of the TWL4030 GPIO output pin
Date: Sat, 7 Feb 2009 00:00:48 -0800 [thread overview]
Message-ID: <200902070000.49089.david-b@pacbell.net> (raw)
In-Reply-To: <4e1455be0902062213o769a4d15ha0c892508839dbad@mail.gmail.com>
On Friday 06 February 2009, Joonyoung Shim wrote:
> If TWL4030 GPIO pin is output, must read the value from REG_GPIODATAOUTx
> register in twl4030_get_gpio_datainout().
Why "must"? The goal is to return the *actual* value of the pin,
not the intended one. When an external signal overwhelms the drive
capability of that GPIO -- just a couple mA -- the correct value
to return can't be the value written in the output register.
Plus, this patch won't even link ... you changed the name of the
function at its definition, but not at its use points.
NAK, unless you can show there's a real bug this addresses...
- Dave
next prev parent reply other threads:[~2009-02-07 8:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-07 6:13 [PATCH] twl4030-gpio: Fix getting the value of the TWL4030 GPIO output pin Joonyoung Shim
2009-02-07 8:00 ` David Brownell [this message]
2009-02-09 13:02 ` Joonyoung Shim
2009-02-12 2:16 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200902070000.49089.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=dofmind@gmail.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox