From: David Brownell <david-b@pacbell.net>
To: Grazvydas Ignotas <notasas@gmail.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH] hsmmc: Add MMC3 support
Date: Sun, 8 Feb 2009 11:41:56 -0800 [thread overview]
Message-ID: <200902081141.56632.david-b@pacbell.net> (raw)
In-Reply-To: <1233050022-5769-1-git-send-email-notasas@gmail.com>
On Tuesday 27 January 2009, Grazvydas Ignotas wrote:
> Device connected to MMC3 is assumed to be self-powered, so
> set_power() function is empty. It can't be omited because
> host driver requires it. Array size for hsmmc[] is specified
> because hsmmc[2].name is needed for MMC3 name.
Just for the record ... this should eventually be handled
using the regulator framework, which will also help with the
decoupling of hsmmc setup from twl4030 setup.
So for example if a given slot is hooked up to an SDIO
chip with a hard-wired 3v3 supply (Pandora MMC3, and
Overo MMC2) then it'd have a fixed voltage regulator;
and the HSMMC driver would just use that. (It would
get a "can't do that" error on disable though.)
- Dave
>
> Also fix a leak which happens if invalid controller id
> is passed.
>
> Signed-off-by: Grazvydas Ignotas <notasas@gmail.com>
> ---
> This patch applies on top of David Brownell's recent 2 patches.
next prev parent reply other threads:[~2009-02-08 19:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-27 9:53 [PATCH] hsmmc: Add MMC3 support Grazvydas Ignotas
2009-02-08 19:41 ` David Brownell [this message]
2009-02-20 20:16 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200902081141.56632.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=dbrownell@users.sourceforge.net \
--cc=linux-omap@vger.kernel.org \
--cc=notasas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox