From: Mark Brown <broonie-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
To: Kalle Jokiniemi
<kalle.jokiniemi-sMOQStClEysAvxtiuMwx3w@public.gmane.org>
Cc: David Brownell <david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>,
Liam Girdwood <lrg-kDsPt+C1G03kYMGBc/C6ZA@public.gmane.org>,
lkml <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
OMAP <linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [patch 2.6.29-rc3-git 2/2] USB: disable twl4030 USB regulators when cable unplugged
Date: Tue, 10 Feb 2009 15:19:03 +0000 [thread overview]
Message-ID: <20090210151902.GA31365@sirena.org.uk> (raw)
In-Reply-To: <1234271294.17391.12.camel@ubuntu>
On Tue, Feb 10, 2009 at 03:08:14PM +0200, Kalle Jokiniemi wrote:
> A bug has been discovered here. If the twl-regulator is not compiled in,
> the twl4030-usb fails while trying to access the reg-fw interfaces (and
reg-fw is the regulator framework?
> not checking error values). Also it's bit confusing how we get different
> error values if reg_fw is not compiled (no error) vs. reg_fw is
> compiled, but twl_regulator is not... (error)
The general model is that if you've got regulator API support enabled
then you'll have the relevant regulator drivers enabled. The support
for compiling out the core is intended to allow configurations that
don't use regulators at all. This is a bit restrictive but works well
for most users.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-02-10 15:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-08 18:52 [patch 2.6.29-rc3-git 2/2] USB: disable twl4030 USB regulators when cable unplugged David Brownell
2009-02-10 13:08 ` Kalle Jokiniemi
2009-02-10 15:19 ` Mark Brown [this message]
[not found] ` <200902081053.00255.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
2009-02-10 14:06 ` Kalle Jokiniemi
2009-02-10 19:52 ` David Brownell
[not found] ` <200902101152.59526.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
2009-02-11 6:25 ` Kalle Jokiniemi
2009-02-26 22:16 ` Liam Girdwood
[not found] ` <1235686596.31223.106.camel-Pyf+wNJ1SdNifHs85vQuMtBc4/FLrbF6@public.gmane.org>
2009-02-26 22:40 ` David Brownell
[not found] ` <200902261440.04129.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
2009-02-27 6:19 ` Kalle Jokiniemi
2009-02-27 12:29 ` Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090210151902.GA31365@sirena.org.uk \
--to=broonie-gfdadszt00ze9xe1eozjha@public.gmane.org \
--cc=david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org \
--cc=kalle.jokiniemi-sMOQStClEysAvxtiuMwx3w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lrg-kDsPt+C1G03kYMGBc/C6ZA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox