Re: omap_apollon_2420_defconfig

[David Brownell <david-b@pacbell.net>]

On Monday 09 February 2009, Kyungmin Park wrote:
> Hi,
> 
> In the previous patch, it's only fixed host side. But apollon case, it
> only used udc, so udc configuration should select USB_OTG_UTILS also.
> 
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>

Acked-by: David Brownell <dbrownell@users.sourceforge.net>

... Greg, this should be a 2.6.29-rc patch (buildfix).

> ---
> diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
> index 3219d13..b26d6e6 100644
> --- a/drivers/usb/gadget/Kconfig
> +++ b/drivers/usb/gadget/Kconfig
> @@ -191,6 +191,7 @@ config USB_GADGET_OMAP
>  	boolean "OMAP USB Device Controller"
>  	depends on ARCH_OMAP
>  	select ISP1301_OMAP if MACH_OMAP_H2 || MACH_OMAP_H3 || MACH_OMAP_H4_OTG
> +	select USB_OTG_UTILS if ARCH_OMAP
>  	help
>  	   Many Texas Instruments OMAP processors have flexible full
>  	   speed USB device controllers, with support for up to 30
> 
> 
> On Tue, Feb 10, 2009 at 5:53 AM, Tony Lindgren <tony@atomide.com> wrote:
> > * Russell King - ARM Linux <linux@arm.linux.org.uk> [090209 11:27]:
> >> It would be nice to get the last OMAP defconfig in mainline working.
> >> It's broken since 2.6.29-rc2-git3 due to this persistent problem:
> >>
> >> drivers/built-in.o: In function `omap_udc_probe':
> >> omap.c:(.init.text+0x30cc): undefined reference to `otg_get_transceiver'
> >> omap.c:(.init.text+0x38a4): undefined reference to `otg_put_transceiver'
> >
> > Hmm, looks like 2bf5fa13fc8e34d7b86307b99f64a24cb7a83852 did not fix it.
> > Dave, do you already have a patch for this?
> >
> > Regards,
> >
> > Tony
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> >
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
>