PM branch updates: 3430sdp and omap3evm results

PM branch updates: 3430sdp and omap3evm results

[Kevin Hilman]

Hello,

I've updated the PM branch with a couple of fixes that get it working
on the 3430SDP.

For it to work on the SDP, you need the latest u-boot from the
omapzoom u-boot tree[1].  This fixes the problems I was having with
the D2D clockdomain remaining active or hanging upon clock disable.

For omap3evm, it is not hitting retention because it uses the GPIO
debounce feature for the touchscreen and the GPIO debounce clocks are
not disabled in idle or suspend.  As a temporary hack, you can test
the patch below[2] which simply doesn't call the gpio debounce
functions for the touchscreen.  In the meantime, I'm working on a
patch to disable the debounce clocks on idle.

Kevin

[1] git://git.omapzoom.org/repo/u-boot.git

[2]
da7df18bc7f5648ac7fe6e674065ca5899ff8d3d
 arch/arm/mach-omap2/board-omap3evm.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-omap2/board-omap3evm.c b/arch/arm/mach-omap2/board-omap3evm.c
index 6fbbe95..18a07b5 100644
--- a/arch/arm/mach-omap2/board-omap3evm.c
+++ b/arch/arm/mach-omap2/board-omap3evm.c
@@ -176,8 +176,8 @@ static void ads7846_dev_init(void)
 
 	gpio_direction_input(OMAP3_EVM_TS_GPIO);
 
-	omap_set_gpio_debounce(OMAP3_EVM_TS_GPIO, 1);
-	omap_set_gpio_debounce_time(OMAP3_EVM_TS_GPIO, 0xa);
+/* 	omap_set_gpio_debounce(OMAP3_EVM_TS_GPIO, 1); */
+/* 	omap_set_gpio_debounce_time(OMAP3_EVM_TS_GPIO, 0xa); */
 }
 

Re: PM branch updates: 3430sdp and omap3evm results

[Koen Kooi]

[-- Attachment #1: Type: text/plain, Size: 1833 bytes --]


Op 27 jan 2009, om 19:16 heeft Kevin Hilman het volgende geschreven:

> Hello,
>
> I've updated the PM branch with a couple of fixes that get it working
> on the 3430SDP.

Any chance of the beagle cpufreq patch ending up in the branch?

regards,

Koen


>
>
> For it to work on the SDP, you need the latest u-boot from the
> omapzoom u-boot tree[1].  This fixes the problems I was having with
> the D2D clockdomain remaining active or hanging upon clock disable.
>
> For omap3evm, it is not hitting retention because it uses the GPIO
> debounce feature for the touchscreen and the GPIO debounce clocks are
> not disabled in idle or suspend.  As a temporary hack, you can test
> the patch below[2] which simply doesn't call the gpio debounce
> functions for the touchscreen.  In the meantime, I'm working on a
> patch to disable the debounce clocks on idle.
>
> Kevin
>
> [1] git://git.omapzoom.org/repo/u-boot.git
>
> [2]
> da7df18bc7f5648ac7fe6e674065ca5899ff8d3d
> arch/arm/mach-omap2/board-omap3evm.c |    4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/board-omap3evm.c b/arch/arm/mach- 
> omap2/board-omap3evm.c
> index 6fbbe95..18a07b5 100644
> --- a/arch/arm/mach-omap2/board-omap3evm.c
> +++ b/arch/arm/mach-omap2/board-omap3evm.c
> @@ -176,8 +176,8 @@ static void ads7846_dev_init(void)
>
> 	gpio_direction_input(OMAP3_EVM_TS_GPIO);
>
> -	omap_set_gpio_debounce(OMAP3_EVM_TS_GPIO, 1);
> -	omap_set_gpio_debounce_time(OMAP3_EVM_TS_GPIO, 0xa);
> +/* 	omap_set_gpio_debounce(OMAP3_EVM_TS_GPIO, 1); */
> +/* 	omap_set_gpio_debounce_time(OMAP3_EVM_TS_GPIO, 0xa); */
> }
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux- 
> omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>


[-- Attachment #2: Dit deel van het bericht is digitaal ondertekend --]
[-- Type: application/pgp-signature, Size: 186 bytes --]

Re: PM branch updates: 3430sdp and omap3evm results

[Kevin Hilman]

Koen Kooi <k.kooi@student.utwente.nl> writes:

> Op 27 jan 2009, om 19:16 heeft Kevin Hilman het volgende geschreven:
>
>> Hello,
>>
>> I've updated the PM branch with a couple of fixes that get it working
>> on the 3430SDP.
>
> Any chance of the beagle cpufreq patch ending up in the branch?
>

Yes, a 100% chance.  :)

I reworked the version you sent me to use a common header for the
rates since it was shared between beagle and SDP.

Just pushed it to my pm branch[1].

NOTE: Tony's tree wont sync yet for while, so I recomment you pull
straight from mine.  Also, I just pushed this, so the git.kernel.org
mirrors might take some time to sync up as well.

The tip of the branch should now be:
OMAP3: PM: add common OPP definitions and use them on Beagle

Kevin

[1] http://git.kernel.org/?p=linux/kernel/git/khilman/linux-omap-pm.git;a=summary
>>
>>
>> For it to work on the SDP, you need the latest u-boot from the
>> omapzoom u-boot tree[1].  This fixes the problems I was having with
>> the D2D clockdomain remaining active or hanging upon clock disable.
>>
>> For omap3evm, it is not hitting retention because it uses the GPIO
>> debounce feature for the touchscreen and the GPIO debounce clocks are
>> not disabled in idle or suspend.  As a temporary hack, you can test
>> the patch below[2] which simply doesn't call the gpio debounce
>> functions for the touchscreen.  In the meantime, I'm working on a
>> patch to disable the debounce clocks on idle.
>>
>> Kevin
>>
>> [1] git://git.omapzoom.org/repo/u-boot.git
>>
>> [2]
>> da7df18bc7f5648ac7fe6e674065ca5899ff8d3d
>> arch/arm/mach-omap2/board-omap3evm.c |    4 ++--
>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/mach-omap2/board-omap3evm.c b/arch/arm/mach- 
>> omap2/board-omap3evm.c
>> index 6fbbe95..18a07b5 100644
>> --- a/arch/arm/mach-omap2/board-omap3evm.c
>> +++ b/arch/arm/mach-omap2/board-omap3evm.c
>> @@ -176,8 +176,8 @@ static void ads7846_dev_init(void)
>>
>> 	gpio_direction_input(OMAP3_EVM_TS_GPIO);
>>
>> -	omap_set_gpio_debounce(OMAP3_EVM_TS_GPIO, 1);
>> -	omap_set_gpio_debounce_time(OMAP3_EVM_TS_GPIO, 0xa);
>> +/* 	omap_set_gpio_debounce(OMAP3_EVM_TS_GPIO, 1); */
>> +/* 	omap_set_gpio_debounce_time(OMAP3_EVM_TS_GPIO, 0xa); */
>> }
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux- 
>> omap" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>

Re: PM branch updates: 3430sdp and omap3evm results

[Koen Kooi]

[-- Attachment #1: Type: text/plain, Size: 2719 bytes --]


Op 27 jan 2009, om 20:52 heeft Kevin Hilman het volgende geschreven:

> Koen Kooi <k.kooi@student.utwente.nl> writes:
>
>> Op 27 jan 2009, om 19:16 heeft Kevin Hilman het volgende geschreven:
>>
>>> Hello,
>>>
>>> I've updated the PM branch with a couple of fixes that get it  
>>> working
>>> on the 3430SDP.
>>
>> Any chance of the beagle cpufreq patch ending up in the branch?
>>
>
> Yes, a 100% chance.  :)
>
> I reworked the version you sent me to use a common header for the
> rates since it was shared between beagle and SDP.
>
> Just pushed it to my pm branch[1].

Thanks! I checked 15 minutes ago, just before you pushed it :)

regards,

Koen

>
>
> NOTE: Tony's tree wont sync yet for while, so I recomment you pull
> straight from mine.  Also, I just pushed this, so the git.kernel.org
> mirrors might take some time to sync up as well.
>
> The tip of the branch should now be:
> OMAP3: PM: add common OPP definitions and use them on Beagle
>
> Kevin
>
> [1] http://git.kernel.org/?p=linux/kernel/git/khilman/linux-omap-pm.git;a=summary
>>>
>>>
>>> For it to work on the SDP, you need the latest u-boot from the
>>> omapzoom u-boot tree[1].  This fixes the problems I was having with
>>> the D2D clockdomain remaining active or hanging upon clock disable.
>>>
>>> For omap3evm, it is not hitting retention because it uses the GPIO
>>> debounce feature for the touchscreen and the GPIO debounce clocks  
>>> are
>>> not disabled in idle or suspend.  As a temporary hack, you can test
>>> the patch below[2] which simply doesn't call the gpio debounce
>>> functions for the touchscreen.  In the meantime, I'm working on a
>>> patch to disable the debounce clocks on idle.
>>>
>>> Kevin
>>>
>>> [1] git://git.omapzoom.org/repo/u-boot.git
>>>
>>> [2]
>>> da7df18bc7f5648ac7fe6e674065ca5899ff8d3d
>>> arch/arm/mach-omap2/board-omap3evm.c |    4 ++--
>>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/arch/arm/mach-omap2/board-omap3evm.c b/arch/arm/mach-
>>> omap2/board-omap3evm.c
>>> index 6fbbe95..18a07b5 100644
>>> --- a/arch/arm/mach-omap2/board-omap3evm.c
>>> +++ b/arch/arm/mach-omap2/board-omap3evm.c
>>> @@ -176,8 +176,8 @@ static void ads7846_dev_init(void)
>>>
>>> 	gpio_direction_input(OMAP3_EVM_TS_GPIO);
>>>
>>> -	omap_set_gpio_debounce(OMAP3_EVM_TS_GPIO, 1);
>>> -	omap_set_gpio_debounce_time(OMAP3_EVM_TS_GPIO, 0xa);
>>> +/* 	omap_set_gpio_debounce(OMAP3_EVM_TS_GPIO, 1); */
>>> +/* 	omap_set_gpio_debounce_time(OMAP3_EVM_TS_GPIO, 0xa); */
>>> }
>>>
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe linux-
>>> omap" in
>>> the body of a message to majordomo@vger.kernel.org
>>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>>
>


[-- Attachment #2: Dit deel van het bericht is digitaal ondertekend --]
[-- Type: application/pgp-signature, Size: 186 bytes --]

Re: PM branch updates: 3430sdp and omap3evm results

[Ramesh Gupta Guntha]

Hi Kevin,


On 1/27/09, Kevin Hilman <khilman@deeprootsystems.com> wrote:
> Hello,
>
> I've updated the PM branch with a couple of fixes that get it working
> on the 3430SDP.
>
> For it to work on the SDP, you need the latest u-boot from the
> omapzoom u-boot tree[1].  This fixes the problems I was having with
> the D2D clockdomain remaining active or hanging upon clock disable.

I have tested this on my 3430SDP, I am seeing all domains hitting the off mode.

But I am seeing some issues while waking up iva domain after suspend.

There are couple of cases.

1. after booting the kernel
I run
echo 1 > /sys/power/clocks_off_while_idle
echo 1 > /sys/power/voltage_off_while_idle
echo 1 > /sys/power/enable_off_mode

and
echo mem > /sys/power/state
# echo mem > /sys/power/state
<6>PM: Syncing filesystems ... PM: Syncing filesystems ... done.
done.
Freezing user space processes ... Freezing user space processes ... (elapsed 0.0
0 seconds) (elapsed 0.00 seconds) done.
done.
Freezing remaining freezable tasks ... Freezing remaining freezable tasks ... (e
lapsed 0.00 seconds) (elapsed 0.00 seconds) done.done.

Suspending console(s) (use no_console_suspend to debug)
Suspending console(s) (use no_console_suspend to debug)
<6>Successfully put all powerdomains to target state
Successfully put all powerdomains to target state
Restarting tasks ... Restarting tasks ... done.
done.
#

If I install bridgedriver and enable iva2 clock I am getting below messages
clock: dpll2_ck failed transition to 'locked'

<3>clock: dpll2_ck failed transition to 'locked'
clock: dpll2_ck failed transition to 'locked'
<3>clock: dpll2_ck failed transition to 'locked'
clock: dpll2_ck failed transition to 'locked'

2. I run below commands as soon as kernel is booted.
echo 1 > /sys/power/clocks_off_while_idle
echo 1 > /sys/power/voltage_off_while_idle
echo 1 > /sys/power/enable_off_mode

installed bridge driver, loaded an dsp image(which also enables
iva2_ck, gpt6_ick/fck, mail box clocks)



I run system suspend, I am seeing all powerdomains enters into OFF
mode, but after this I am not able to wakeup iva domain, I reenabled
clocks but no use.

3. Without the option
echo 1 > /sys/power/clocks_off_while_idle every thing works fine but
perdomain is not hitting the off mode.


Please let me know any thoghts on these issues I am seeing.

-- 
Thanks
Ramesh Gupta G

Re: PM branch updates: 3430sdp and omap3evm results

[Ramesh Gupta Guntha]

Hi,

 I am able to resolve all other issues with this pm branch except one issue,

I am not able to enable the iva2 clock once system is suspended and
resumed, I am getting below messages.
>
> <3>clock: dpll2_ck failed transition to 'locked'
> clock: dpll2_ck failed transition to 'locked'
> <3>clock: dpll2_ck failed transition to 'locked'
> clock: dpll2_ck failed transition to 'locked'

Once after booting ( without adding bridgedriver/ installing bridgedriver)
CM_CLKEN_PLL_IVA2 value shows as 0x37 indicates IVA2 DPLL in locked mode.

once after system suspend the value is not restored I am seeing that as
 0x11 indicates IVA2 DPLL is low power stop mode.

Can any one please provide your inputs on the above error? I tried
reconfiguring the CM_CLKEN_PLL_IVA2 to lock mode but still I am seeing
the same messages as above while enabling iva2 clock.

thanks & regards
Ramesh Gupta G

Re: PM branch updates: 3430sdp and omap3evm results

[Kevin Hilman]

Ramesh Gupta Guntha <grgupta77@gmail.com> writes:

> Hi,
>
>  I am able to resolve all other issues with this pm branch except one issue,
>
> I am not able to enable the iva2 clock once system is suspended and
> resumed, I am getting below messages.
>>
>> <3>clock: dpll2_ck failed transition to 'locked'
>> clock: dpll2_ck failed transition to 'locked'
>> <3>clock: dpll2_ck failed transition to 'locked'
>> clock: dpll2_ck failed transition to 'locked'
>
> Once after booting ( without adding bridgedriver/ installing bridgedriver)
> CM_CLKEN_PLL_IVA2 value shows as 0x37 indicates IVA2 DPLL in locked mode.
>
> once after system suspend the value is not restored I am seeing that as
>  0x11 indicates IVA2 DPLL is low power stop mode.
>
> Can any one please provide your inputs on the above error? I tried
> reconfiguring the CM_CLKEN_PLL_IVA2 to lock mode but still I am seeing
> the same messages as above while enabling iva2 clock.

Are you suspending into retention or off-mode?

Kevin

Re: PM branch updates: 3430sdp and omap3evm results

[Ramesh Gupta Guntha]

Kevin,


On 2/4/09, Kevin Hilman <khilman@deeprootsystems.com> wrote:
> Ramesh Gupta Guntha <grgupta77@gmail.com> writes:
>
> > Hi,
> >
> >  I am able to resolve all other issues with this pm branch except one issue,
> >
> > I am not able to enable the iva2 clock once system is suspended and
> > resumed, I am getting below messages.
> >>
> >> <3>clock: dpll2_ck failed transition to 'locked'
> >> clock: dpll2_ck failed transition to 'locked'
> >> <3>clock: dpll2_ck failed transition to 'locked'
> >> clock: dpll2_ck failed transition to 'locked'
> >
> > Once after booting ( without adding bridgedriver/ installing bridgedriver)
> > CM_CLKEN_PLL_IVA2 value shows as 0x37 indicates IVA2 DPLL in locked mode.
> >
> > once after system suspend the value is not restored I am seeing that as
> >  0x11 indicates IVA2 DPLL is low power stop mode.
> >
> > Can any one please provide your inputs on the above error? I tried
> > reconfiguring the CM_CLKEN_PLL_IVA2 to lock mode but still I am seeing
> > the same messages as above while enabling iva2 clock.
>
> Are you suspending into retention or off-mode?

I am suspending into Off mode.

regards
Ramesh Gupta G

Re: PM branch updates: 3430sdp and omap3evm results

[Kevin Hilman]

Ramesh Gupta Guntha <grgupta77@gmail.com> writes:

> Kevin,
>
>
> On 2/4/09, Kevin Hilman <khilman@deeprootsystems.com> wrote:
>> Ramesh Gupta Guntha <grgupta77@gmail.com> writes:
>>
>> > Hi,
>> >
>> >  I am able to resolve all other issues with this pm branch except one issue,
>> >
>> > I am not able to enable the iva2 clock once system is suspended and
>> > resumed, I am getting below messages.
>> >>
>> >> <3>clock: dpll2_ck failed transition to 'locked'
>> >> clock: dpll2_ck failed transition to 'locked'
>> >> <3>clock: dpll2_ck failed transition to 'locked'
>> >> clock: dpll2_ck failed transition to 'locked'
>> >
>> > Once after booting ( without adding bridgedriver/ installing bridgedriver)
>> > CM_CLKEN_PLL_IVA2 value shows as 0x37 indicates IVA2 DPLL in locked mode.
>> >
>> > once after system suspend the value is not restored I am seeing that as
>> >  0x11 indicates IVA2 DPLL is low power stop mode.
>> >
>> > Can any one please provide your inputs on the above error? I tried
>> > reconfiguring the CM_CLKEN_PLL_IVA2 to lock mode but still I am seeing
>> > the same messages as above while enabling iva2 clock.
>>
>> Are you suspending into retention or off-mode?
>
> I am suspending into Off mode.
>

Do you see this problem when only going into retention?

If not, sounds like we're missing some registers being saved/restored
across off-mode.

Kevin

Re: PM branch updates: 3430sdp and omap3evm results

[Ramesh Gupta Guntha]

Hi Kevin,


On 2/4/09, Kevin Hilman <khilman@deeprootsystems.com> wrote:
> Ramesh Gupta Guntha <grgupta77@gmail.com> writes:
>
> > Kevin,
> >
> >
> > On 2/4/09, Kevin Hilman <khilman@deeprootsystems.com> wrote:
> >> Ramesh Gupta Guntha <grgupta77@gmail.com> writes:
> >>
> >> > Hi,
> >> >
> >> >  I am able to resolve all other issues with this pm branch except one issue,
> >> >
> >> > I am not able to enable the iva2 clock once system is suspended and
> >> > resumed, I am getting below messages.
> >> >>
> >> >> <3>clock: dpll2_ck failed transition to 'locked'
> >> >> clock: dpll2_ck failed transition to 'locked'
> >> >> <3>clock: dpll2_ck failed transition to 'locked'
> >> >> clock: dpll2_ck failed transition to 'locked'
> >> >
> >> > Once after booting ( without adding bridgedriver/ installing bridgedriver)
> >> > CM_CLKEN_PLL_IVA2 value shows as 0x37 indicates IVA2 DPLL in locked mode.
> >> >
> >> > once after system suspend the value is not restored I am seeing that as
> >> >  0x11 indicates IVA2 DPLL is low power stop mode.
> >> >
> >> > Can any one please provide your inputs on the above error? I tried
> >> > reconfiguring the CM_CLKEN_PLL_IVA2 to lock mode but still I am seeing
> >> > the same messages as above while enabling iva2 clock.
> >>
> >> Are you suspending into retention or off-mode?
> >
> > I am suspending into Off mode.
> >
>
> Do you see this problem when only going into retention?
>
> If not, sounds like we're missing some registers being saved/restored
> across off-mode.

I am seeing this issue only with OFF mode , retention works fine for me,
yeah, looks like some registers are not restored properly across off mode.
please let me know your inputs on this.

-- 
Thanks
Ramesh Gupta G

Re: PM branch updates: 3430sdp and omap3evm results

[Kevin Hilman]

Ramesh Gupta Guntha <grgupta77@gmail.com> writes:

> Hi Kevin,
>
>
> On 2/4/09, Kevin Hilman <khilman@deeprootsystems.com> wrote:
>> Ramesh Gupta Guntha <grgupta77@gmail.com> writes:
>>
>> > Kevin,
>> >
>> >
>> > On 2/4/09, Kevin Hilman <khilman@deeprootsystems.com> wrote:
>> >> Ramesh Gupta Guntha <grgupta77@gmail.com> writes:
>> >>
>> >> > Hi,
>> >> >
>> >> >  I am able to resolve all other issues with this pm branch except one issue,
>> >> >
>> >> > I am not able to enable the iva2 clock once system is suspended and
>> >> > resumed, I am getting below messages.
>> >> >>
>> >> >> <3>clock: dpll2_ck failed transition to 'locked'
>> >> >> clock: dpll2_ck failed transition to 'locked'
>> >> >> <3>clock: dpll2_ck failed transition to 'locked'
>> >> >> clock: dpll2_ck failed transition to 'locked'
>> >> >
>> >> > Once after booting ( without adding bridgedriver/ installing bridgedriver)
>> >> > CM_CLKEN_PLL_IVA2 value shows as 0x37 indicates IVA2 DPLL in locked mode.
>> >> >
>> >> > once after system suspend the value is not restored I am seeing that as
>> >> >  0x11 indicates IVA2 DPLL is low power stop mode.
>> >> >
>> >> > Can any one please provide your inputs on the above error? I tried
>> >> > reconfiguring the CM_CLKEN_PLL_IVA2 to lock mode but still I am seeing
>> >> > the same messages as above while enabling iva2 clock.
>> >>
>> >> Are you suspending into retention or off-mode?
>> >
>> > I am suspending into Off mode.
>> >
>>
>> Do you see this problem when only going into retention?
>>
>> If not, sounds like we're missing some registers being saved/restored
>> across off-mode.
>
> I am seeing this issue only with OFF mode , retention works fine for me,
> yeah, looks like some registers are not restored properly across off mode.
> please let me know your inputs on this.
>

I have just updated the PM branch with a fix from Jouni to
save/restore CM_CLKSEL1_PLL_IVA2.

Can you try the latest PM branch?

Thanks,

Kevin

Re: PM branch updates: 3430sdp and omap3evm results

[Ramesh Gupta Guntha]

Kevin,
I applied the patch maually at my end and tested, this works fine for
me. anyway I will try with pm branch .

thanks
Ramesh Gupta G
On 2/5/09, Kevin Hilman <khilman@deeprootsystems.com> wrote:
> Ramesh Gupta Guntha <grgupta77@gmail.com> writes:
>
> > Hi Kevin,
> >
> >
> > On 2/4/09, Kevin Hilman <khilman@deeprootsystems.com> wrote:
> >> Ramesh Gupta Guntha <grgupta77@gmail.com> writes:
> >>
> >> > Kevin,
> >> >
> >> >
> >> > On 2/4/09, Kevin Hilman <khilman@deeprootsystems.com> wrote:
> >> >> Ramesh Gupta Guntha <grgupta77@gmail.com> writes:
> >> >>
> >> >> > Hi,
> >> >> >
> >> >> >  I am able to resolve all other issues with this pm branch except one issue,
> >> >> >
> >> >> > I am not able to enable the iva2 clock once system is suspended and
> >> >> > resumed, I am getting below messages.
> >> >> >>
> >> >> >> <3>clock: dpll2_ck failed transition to 'locked'
> >> >> >> clock: dpll2_ck failed transition to 'locked'
> >> >> >> <3>clock: dpll2_ck failed transition to 'locked'
> >> >> >> clock: dpll2_ck failed transition to 'locked'
> >> >> >
> >> >> > Once after booting ( without adding bridgedriver/ installing bridgedriver)
> >> >> > CM_CLKEN_PLL_IVA2 value shows as 0x37 indicates IVA2 DPLL in locked mode.
> >> >> >
> >> >> > once after system suspend the value is not restored I am seeing that as
> >> >> >  0x11 indicates IVA2 DPLL is low power stop mode.
> >> >> >
> >> >> > Can any one please provide your inputs on the above error? I tried
> >> >> > reconfiguring the CM_CLKEN_PLL_IVA2 to lock mode but still I am seeing
> >> >> > the same messages as above while enabling iva2 clock.
> >> >>
> >> >> Are you suspending into retention or off-mode?
> >> >
> >> > I am suspending into Off mode.
> >> >
> >>
> >> Do you see this problem when only going into retention?
> >>
> >> If not, sounds like we're missing some registers being saved/restored
> >> across off-mode.
> >
> > I am seeing this issue only with OFF mode , retention works fine for me,
> > yeah, looks like some registers are not restored properly across off mode.
> > please let me know your inputs on this.
> >
>
> I have just updated the PM branch with a fix from Jouni to
> save/restore CM_CLKSEL1_PLL_IVA2.
>
> Can you try the latest PM branch?
>
> Thanks,
>
> Kevin
>


-- 
Thanks
Ramesh Gupta G

Re: PM branch updates: 3430sdp and omap3evm results

[Ramesh Gupta Guntha]

Kevin,
I pulled git kernel today but still I am not seeing this patch in pm
branch, looks like this patch is missing in the pm branch. Can you
please recheck the same?

thanks
Ramesh Gupta G


On 2/5/09, Ramesh Gupta Guntha <grgupta77@gmail.com> wrote:
> Kevin,
> I applied the patch maually at my end and tested, this works fine for
> me. anyway I will try with pm branch .
>
> thanks
> Ramesh Gupta G
> On 2/5/09, Kevin Hilman <khilman@deeprootsystems.com> wrote:
> > Ramesh Gupta Guntha <grgupta77@gmail.com> writes:
> >
> > > Hi Kevin,
> > >
> > >
> > > On 2/4/09, Kevin Hilman <khilman@deeprootsystems.com> wrote:
> > >> Ramesh Gupta Guntha <grgupta77@gmail.com> writes:
> > >>
> > >> > Kevin,
> > >> >
> > >> >
> > >> > On 2/4/09, Kevin Hilman <khilman@deeprootsystems.com> wrote:
> > >> >> Ramesh Gupta Guntha <grgupta77@gmail.com> writes:
> > >> >>
> > >> >> > Hi,
> > >> >> >
> > >> >> >  I am able to resolve all other issues with this pm branch except one issue,
> > >> >> >
> > >> >> > I am not able to enable the iva2 clock once system is suspended and
> > >> >> > resumed, I am getting below messages.
> > >> >> >>
> > >> >> >> <3>clock: dpll2_ck failed transition to 'locked'
> > >> >> >> clock: dpll2_ck failed transition to 'locked'
> > >> >> >> <3>clock: dpll2_ck failed transition to 'locked'
> > >> >> >> clock: dpll2_ck failed transition to 'locked'
> > >> >> >
> > >> >> > Once after booting ( without adding bridgedriver/ installing bridgedriver)
> > >> >> > CM_CLKEN_PLL_IVA2 value shows as 0x37 indicates IVA2 DPLL in locked mode.
> > >> >> >
> > >> >> > once after system suspend the value is not restored I am seeing that as
> > >> >> >  0x11 indicates IVA2 DPLL is low power stop mode.
> > >> >> >
> > >> >> > Can any one please provide your inputs on the above error? I tried
> > >> >> > reconfiguring the CM_CLKEN_PLL_IVA2 to lock mode but still I am seeing
> > >> >> > the same messages as above while enabling iva2 clock.
> > >> >>
> > >> >> Are you suspending into retention or off-mode?
> > >> >
> > >> > I am suspending into Off mode.
> > >> >
> > >>
> > >> Do you see this problem when only going into retention?
> > >>
> > >> If not, sounds like we're missing some registers being saved/restored
> > >> across off-mode.
> > >
> > > I am seeing this issue only with OFF mode , retention works fine for me,
> > > yeah, looks like some registers are not restored properly across off mode.
> > > please let me know your inputs on this.
> > >
> >
> > I have just updated the PM branch with a fix from Jouni to
> > save/restore CM_CLKSEL1_PLL_IVA2.
> >
> > Can you try the latest PM branch?
> >
> > Thanks,
> >
> > Kevin
> >
>
>
> --
> Thanks
> Ramesh Gupta G
>


-- 
Thanks
Ramesh Gupta G

Re: PM branch updates: 3430sdp and omap3evm results

[Kevin Hilman]

Ramesh Gupta Guntha <grgupta77@gmail.com> writes:

> Kevin,
> I pulled git kernel today but still I am not seeing this patch in pm
> branch, looks like this patch is missing in the pm branch. Can you
> please recheck the same?

Hi Ramesh,

It looks like Tony's tree is not sync'ing with my PM branch anymore.
I will check with Tony.

In the mean-time, you could try to pull directly from my git repo[1]

Kevin

[1] git://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-omap-pm.git

>
>
> On 2/5/09, Ramesh Gupta Guntha <grgupta77@gmail.com> wrote:
>> Kevin,
>> I applied the patch maually at my end and tested, this works fine for
>> me. anyway I will try with pm branch .
>>
>> thanks
>> Ramesh Gupta G
>> On 2/5/09, Kevin Hilman <khilman@deeprootsystems.com> wrote:
>> > Ramesh Gupta Guntha <grgupta77@gmail.com> writes:
>> >
>> > > Hi Kevin,
>> > >
>> > >
>> > > On 2/4/09, Kevin Hilman <khilman@deeprootsystems.com> wrote:
>> > >> Ramesh Gupta Guntha <grgupta77@gmail.com> writes:
>> > >>
>> > >> > Kevin,
>> > >> >
>> > >> >
>> > >> > On 2/4/09, Kevin Hilman <khilman@deeprootsystems.com> wrote:
>> > >> >> Ramesh Gupta Guntha <grgupta77@gmail.com> writes:
>> > >> >>
>> > >> >> > Hi,
>> > >> >> >
>> > >> >> >  I am able to resolve all other issues with this pm branch except one issue,
>> > >> >> >
>> > >> >> > I am not able to enable the iva2 clock once system is suspended and
>> > >> >> > resumed, I am getting below messages.
>> > >> >> >>
>> > >> >> >> <3>clock: dpll2_ck failed transition to 'locked'
>> > >> >> >> clock: dpll2_ck failed transition to 'locked'
>> > >> >> >> <3>clock: dpll2_ck failed transition to 'locked'
>> > >> >> >> clock: dpll2_ck failed transition to 'locked'
>> > >> >> >
>> > >> >> > Once after booting ( without adding bridgedriver/ installing bridgedriver)
>> > >> >> > CM_CLKEN_PLL_IVA2 value shows as 0x37 indicates IVA2 DPLL in locked mode.
>> > >> >> >
>> > >> >> > once after system suspend the value is not restored I am seeing that as
>> > >> >> >  0x11 indicates IVA2 DPLL is low power stop mode.
>> > >> >> >
>> > >> >> > Can any one please provide your inputs on the above error? I tried
>> > >> >> > reconfiguring the CM_CLKEN_PLL_IVA2 to lock mode but still I am seeing
>> > >> >> > the same messages as above while enabling iva2 clock.
>> > >> >>
>> > >> >> Are you suspending into retention or off-mode?
>> > >> >
>> > >> > I am suspending into Off mode.
>> > >> >
>> > >>
>> > >> Do you see this problem when only going into retention?
>> > >>
>> > >> If not, sounds like we're missing some registers being saved/restored
>> > >> across off-mode.
>> > >
>> > > I am seeing this issue only with OFF mode , retention works fine for me,
>> > > yeah, looks like some registers are not restored properly across off mode.
>> > > please let me know your inputs on this.
>> > >
>> >
>> > I have just updated the PM branch with a fix from Jouni to
>> > save/restore CM_CLKSEL1_PLL_IVA2.
>> >
>> > Can you try the latest PM branch?
>> >
>> > Thanks,
>> >
>> > Kevin
>> >
>>
>>
>> --
>> Thanks
>> Ramesh Gupta G
>>
>
>
> -- 
> Thanks
> Ramesh Gupta G

Re: PM branch updates: 3430sdp and omap3evm results

[Tony Lindgren]

* Kevin Hilman <khilman@deeprootsystems.com> [090210 14:30]:
> Ramesh Gupta Guntha <grgupta77@gmail.com> writes:
> 
> > Kevin,
> > I pulled git kernel today but still I am not seeing this patch in pm
> > branch, looks like this patch is missing in the pm branch. Can you
> > please recheck the same?
> 
> Hi Ramesh,
> 
> It looks like Tony's tree is not sync'ing with my PM branch anymore.
> I will check with Tony.

Is there still a problem? I have not changed anything on that for few
weeks.

Regards,

Tony




> In the mean-time, you could try to pull directly from my git repo[1]
> 
> Kevin
> 
> [1] git://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-omap-pm.git

<snip>

Re: PM branch updates: 3430sdp and omap3evm results

[Ramesh Gupta Guntha]

Hi Tony,

On 2/12/09, Tony Lindgren <tony@atomide.com> wrote:
> * Kevin Hilman <khilman@deeprootsystems.com> [090210 14:30]:
> > Ramesh Gupta Guntha <grgupta77@gmail.com> writes:
> >
> > > Kevin,
> > > I pulled git kernel today but still I am not seeing this patch in pm
> > > branch, looks like this patch is missing in the pm branch. Can you
> > > please recheck the same?
> >
> > Hi Ramesh,
> >
> > It looks like Tony's tree is not sync'ing with my PM branch anymore.
> > I will check with Tony.
>
> Is there still a problem? I have not changed anything on that for few
> weeks.

I didn't try from your tree today, When I checked it 2 days back those
patches were not synced. I will try and let you know.

Regards
Ramesh Gupta G

Re: PM branch updates: 3430sdp and omap3evm results

[Ramesh Gupta Guntha]

Hi Tony,

On 2/12/09, Ramesh Gupta Guntha <grgupta77@gmail.com> wrote:
> Hi Tony,
>
> On 2/12/09, Tony Lindgren <tony@atomide.com> wrote:
> > * Kevin Hilman <khilman@deeprootsystems.com> [090210 14:30]:
> > > Ramesh Gupta Guntha <grgupta77@gmail.com> writes:
> > >
> > > > Kevin,
> > > > I pulled git kernel today but still I am not seeing this patch in pm
> > > > branch, looks like this patch is missing in the pm branch. Can you
> > > > please recheck the same?
> > >
> > > Hi Ramesh,
> > >
> > > It looks like Tony's tree is not sync'ing with my PM branch anymore.
> > > I will check with Tony.
> >
> > Is there still a problem? I have not changed anything on that for few
> > weeks.

Now I am seeing this patch in pm branch.

regards
Ramesh Gupta G

RE: PM branch updates: 3430sdp and omap3evm results

[jouni.hogander]

>-----Original Message-----
>From: linux-omap-owner@vger.kernel.org
>[mailto:linux-omap-owner@vger.kernel.org] On Behalf Of ext Kevin Hilman
>Sent: 04.02.2009 08:10
>To: Ramesh Gupta Guntha
>Cc: linux-omap@vger.kernel.org
>Subject: Re: PM branch updates: 3430sdp and omap3evm results
>
>Ramesh Gupta Guntha <grgupta77@gmail.com> writes:
>
>> Kevin,
>>
>>
>> On 2/4/09, Kevin Hilman <khilman@deeprootsystems.com> wrote:
>>> Ramesh Gupta Guntha <grgupta77@gmail.com> writes:
>>>
>>> > Hi,
>>> >
>>> >  I am able to resolve all other issues with this pm branch except
>>> > one issue,
>>> >
>>> > I am not able to enable the iva2 clock once system is
>suspended and
>>> > resumed, I am getting below messages.
>>> >>
>>> >> <3>clock: dpll2_ck failed transition to 'locked'
>>> >> clock: dpll2_ck failed transition to 'locked'
>>> >> <3>clock: dpll2_ck failed transition to 'locked'
>>> >> clock: dpll2_ck failed transition to 'locked'
>>> >
>>> > Once after booting ( without adding bridgedriver/ installing
>>> > bridgedriver)
>>> > CM_CLKEN_PLL_IVA2 value shows as 0x37 indicates IVA2 DPLL
>in locked mode.
>>> >
>>> > once after system suspend the value is not restored I am seeing
>>> > that as
>>> >  0x11 indicates IVA2 DPLL is low power stop mode.
>>> >
>>> > Can any one please provide your inputs on the above
>error? I tried
>>> > reconfiguring the CM_CLKEN_PLL_IVA2 to lock mode but still I am
>>> > seeing the same messages as above while enabling iva2 clock.
>>>
>>> Are you suspending into retention or off-mode?
>>
>> I am suspending into Off mode.
>>
>
>Do you see this problem when only going into retention?
>
>If not, sounds like we're missing some registers being
>saved/restored across off-mode.

This remids me about another issue which is with DPLL5. ROM code is not currently saving/restoring that. Maybe there is similar situation with DPLL2.

>
>Kevin
>--
>To unsubscribe from this list: send the line "unsubscribe
>linux-omap" in the body of a message to
>majordomo@vger.kernel.org More majordomo info at
>http://vger.kernel.org/majordomo-info.html
>