[PATCH] Fix compile error in usb-musb.c

[PATCH] Fix compile error in usb-musb.c

[Gadiyar, Anand]

From: Anand Gadiyar <gadiyar@ti.com>

Fix this compile error

  CC      arch/arm/mach-omap2/usb-musb.o
arch/arm/mach-omap2/usb-musb.c:47: error: 'INT_243X_HS_USB_MC' undeclared here (not in a function)
arch/arm/mach-omap2/usb-musb.c:51: error: 'INT_243X_HS_USB_DMA' undeclared here (not in a function)
make[1]: *** [arch/arm/mach-omap2/usb-musb.o] Error 1

Signed-off-by: Anand Gadiyar <gadiyar@ti.com>
Reported-by: David Brownell <david-b@pacbell.net>
---
diff --git a/arch/arm/mach-omap2/usb-musb.c b/arch/arm/mach-omap2/usb-musb.c
index 61c5709..5d79f89 100644
--- a/arch/arm/mach-omap2/usb-musb.c
+++ b/arch/arm/mach-omap2/usb-musb.c
@@ -28,6 +28,7 @@
 #include <linux/usb/musb.h>
 
 #include <mach/hardware.h>
+#include <mach/irqs.h>
 #include <mach/pm.h>
 #include <mach/mux.h>
 #include <mach/usb.h>

Re: [PATCH] Fix compile error in usb-musb.c

[Tony Lindgren]

* Gadiyar, Anand <gadiyar@ti.com> [090115 20:48]:
> From: Anand Gadiyar <gadiyar@ti.com>
> 
> Fix this compile error

This one should go via the usb list too.

Acked-by: Tony Lindgren <tony@atomide.com>


>   CC      arch/arm/mach-omap2/usb-musb.o
> arch/arm/mach-omap2/usb-musb.c:47: error: 'INT_243X_HS_USB_MC' undeclared here (not in a function)
> arch/arm/mach-omap2/usb-musb.c:51: error: 'INT_243X_HS_USB_DMA' undeclared here (not in a function)
> make[1]: *** [arch/arm/mach-omap2/usb-musb.o] Error 1
> 
> Signed-off-by: Anand Gadiyar <gadiyar@ti.com>
> Reported-by: David Brownell <david-b@pacbell.net>
> ---
> diff --git a/arch/arm/mach-omap2/usb-musb.c b/arch/arm/mach-omap2/usb-musb.c
> index 61c5709..5d79f89 100644
> --- a/arch/arm/mach-omap2/usb-musb.c
> +++ b/arch/arm/mach-omap2/usb-musb.c
> @@ -28,6 +28,7 @@
>  #include <linux/usb/musb.h>
>  
>  #include <mach/hardware.h>
> +#include <mach/irqs.h>
>  #include <mach/pm.h>
>  #include <mach/mux.h>
>  #include <mach/usb.h>

Re: [PATCH] Fix compile error in usb-musb.c

[Tony Lindgren]

* Tony Lindgren <tony@atomide.com> [090116 09:29]:
> * Gadiyar, Anand <gadiyar@ti.com> [090115 20:48]:
> > From: Anand Gadiyar <gadiyar@ti.com>
> > 
> > Fix this compile error
> 
> This one should go via the usb list too.

Uh, looks like my usb filter is set too sensitive :)

This is the platform code part, I'll apply this and queue it up
in omap-fixes.

Thanks,

Tony

> Acked-by: Tony Lindgren <tony@atomide.com>
> 
> 
> >   CC      arch/arm/mach-omap2/usb-musb.o
> > arch/arm/mach-omap2/usb-musb.c:47: error: 'INT_243X_HS_USB_MC' undeclared here (not in a function)
> > arch/arm/mach-omap2/usb-musb.c:51: error: 'INT_243X_HS_USB_DMA' undeclared here (not in a function)
> > make[1]: *** [arch/arm/mach-omap2/usb-musb.o] Error 1
> > 
> > Signed-off-by: Anand Gadiyar <gadiyar@ti.com>
> > Reported-by: David Brownell <david-b@pacbell.net>
> > ---
> > diff --git a/arch/arm/mach-omap2/usb-musb.c b/arch/arm/mach-omap2/usb-musb.c
> > index 61c5709..5d79f89 100644
> > --- a/arch/arm/mach-omap2/usb-musb.c
> > +++ b/arch/arm/mach-omap2/usb-musb.c
> > @@ -28,6 +28,7 @@
> >  #include <linux/usb/musb.h>
> >  
> >  #include <mach/hardware.h>
> > +#include <mach/irqs.h>
> >  #include <mach/pm.h>
> >  #include <mach/mux.h>
> >  #include <mach/usb.h>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Fix compile error in usb-musb.c

[Felipe Balbi]

On Fri, Jan 16, 2009 at 09:37:38AM +0200, Tony Lindgren wrote:
> * Tony Lindgren <tony@atomide.com> [090116 09:29]:
> > * Gadiyar, Anand <gadiyar@ti.com> [090115 20:48]:
> > > From: Anand Gadiyar <gadiyar@ti.com>
> > > 
> > > Fix this compile error
> > 
> > This one should go via the usb list too.
> 
> Uh, looks like my usb filter is set too sensitive :)
> 
> This is the platform code part, I'll apply this and queue it up
> in omap-fixes.
> 

I think it's time to send this via greg so we can get musb working on
beagle. No otg though due to missing CONFIG_PM for omap3. Any plans to
get that upstream ??

Maybe it's better to get PM there first and avoid compile issues without
CONFIG_PM=y

-- 
balbi

RE: [PATCH] Fix compile error in usb-musb.c

[Gadiyar, Anand]

> On Fri, Jan 16, 2009 at 09:37:38AM +0200, Tony Lindgren wrote:
> > * Tony Lindgren <tony@atomide.com> [090116 09:29]:
> > > * Gadiyar, Anand <gadiyar@ti.com> [090115 20:48]:
> > > > From: Anand Gadiyar <gadiyar@ti.com>
> > > > 
> > > > Fix this compile error
> > > 
> > > This one should go via the usb list too.
> > 
> > Uh, looks like my usb filter is set too sensitive :)
> > 
> > This is the platform code part, I'll apply this and queue it up
> > in omap-fixes.
> > 
> 
> I think it's time to send this via greg so we can get musb working on
> beagle. No otg though due to missing CONFIG_PM for omap3. Any plans to
> get that upstream ??
> 
> Maybe it's better to get PM there first and avoid compile issues without
> CONFIG_PM=y

I still don't get it. Why Greg?

It's a one-line compile fix for God's sake - nothing even remotely related
to a change in USB - it's platform code that got broken for some reason.

And Tony's already going to queue it up.

Re: [PATCH] Fix compile error in usb-musb.c

[Felipe Balbi]

On Fri, Jan 16, 2009 at 09:08:57PM +0530, Gadiyar, Anand wrote:
> I still don't get it. Why Greg?
> 
> It's a one-line compile fix for God's sake - nothing even remotely related
> to a change in USB - it's platform code that got broken for some reason.
> 
> And Tony's already going to queue it up.

I'm talking about pushing the whole file via musb patches ;-)

-- 
balbi

RE: [PATCH] Fix compile error in usb-musb.c

[Gadiyar, Anand]

> On Fri, Jan 16, 2009 at 09:08:57PM +0530, Gadiyar, Anand wrote:
> > I still don't get it. Why Greg?
> > 
> > It's a one-line compile fix for God's sake - nothing even remotely related
> > to a change in USB - it's platform code that got broken for some reason.
> > 
> > And Tony's already going to queue it up.
> 
> I'm talking about pushing the whole file via musb patches ;-)
> 

Oh, ok. Sorry.

- Anand

Re: [PATCH] Fix compile error in usb-musb.c

[David Brownell]

On Friday 16 January 2009, Felipe Balbi wrote:
> 
> I think it's time to send this via greg so we can get musb working on
> beagle. No otg though due to missing CONFIG_PM for omap3. Any plans to
> get that upstream ??

So why not just enable PM=y in the configuration?  It's not
actually required to do much, beyond not being broken.

- Dave

Re: [PATCH] Fix compile error in usb-musb.c

[Felipe Balbi]

On Fri, Jan 16, 2009 at 01:27:52PM -0800, David Brownell wrote:
> So why not just enable PM=y in the configuration?  It's not
> actually required to do much, beyond not being broken.

That patch would have to go through tony

arch/arch/plat-omap/include/mach/pm.h:

#if     !defined(CONFIG_ARCH_OMAP730) && \
	!defined(CONFIG_ARCH_OMAP15XX) && \
	!defined(CONFIG_ARCH_OMAP16XX) && \
	!defined(CONFIG_ARCH_OMAP24XX) && \
	!defined(CONFIG_ARCH_OMAP34XX)
#error "Power management for this processor not implemented yet"
#endif

-- 
balbi

Re: [PATCH] Fix compile error in usb-musb.c

[David Brownell]

On Friday 16 January 2009, Felipe Balbi wrote:
> On Fri, Jan 16, 2009 at 01:27:52PM -0800, David Brownell wrote:
> > So why not just enable PM=y in the configuration?  It's not
> > actually required to do much, beyond not being broken.
> 
> That patch would have to go through tony
> 
> arch/arm/plat-omap/include/mach/pm.h:
> 
> #if     !defined(CONFIG_ARCH_OMAP730) && \
> 	!defined(CONFIG_ARCH_OMAP15XX) && \
> 	!defined(CONFIG_ARCH_OMAP16XX) && \
> 	!defined(CONFIG_ARCH_OMAP24XX) && \
> 	!defined(CONFIG_ARCH_OMAP34XX)
> #error "Power management for this processor not implemented yet"
> #endif

I didn't realize anyone outside of TI had their hands
on OMAP4 chips yet.  :)

Re: [PATCH] Fix compile error in usb-musb.c

[Felipe Balbi]

On Fri, Jan 16, 2009 at 02:31:00PM -0800, David Brownell wrote:
> On Friday 16 January 2009, Felipe Balbi wrote:
> > On Fri, Jan 16, 2009 at 01:27:52PM -0800, David Brownell wrote:
> > > So why not just enable PM=y in the configuration?  It's not
> > > actually required to do much, beyond not being broken.
> > 
> > That patch would have to go through tony
> > 
> > arch/arm/plat-omap/include/mach/pm.h:
> > 
> > #if     !defined(CONFIG_ARCH_OMAP730) && \
> > 	!defined(CONFIG_ARCH_OMAP15XX) && \
> > 	!defined(CONFIG_ARCH_OMAP16XX) && \
> > 	!defined(CONFIG_ARCH_OMAP24XX) && \
> > 	!defined(CONFIG_ARCH_OMAP34XX)
> > #error "Power management for this processor not implemented yet"
> > #endif
> 
> I didn't realize anyone outside of TI had their hands
> on OMAP4 chips yet.  :)

hehe, the last line isn't in mainline ;-)

-- 
balbi

Re: [PATCH] Fix compile error in usb-musb.c

[Tony Lindgren]

* David Brownell <david-b@pacbell.net> [090117 00:31]:
> On Friday 16 January 2009, Felipe Balbi wrote:
> > On Fri, Jan 16, 2009 at 01:27:52PM -0800, David Brownell wrote:
> > > So why not just enable PM=y in the configuration?  It's not
> > > actually required to do much, beyond not being broken.
> > 
> > That patch would have to go through tony
> > 
> > arch/arm/plat-omap/include/mach/pm.h:
> > 
> > #if     !defined(CONFIG_ARCH_OMAP730) && \
> > 	!defined(CONFIG_ARCH_OMAP15XX) && \
> > 	!defined(CONFIG_ARCH_OMAP16XX) && \
> > 	!defined(CONFIG_ARCH_OMAP24XX) && \
> > 	!defined(CONFIG_ARCH_OMAP34XX)
> > #error "Power management for this processor not implemented yet"
> > #endif
> 
> I didn't realize anyone outside of TI had their hands
> on OMAP4 chips yet.  :)

Might be worth looking what it would take to make dummy CONFIG_PM
compile in mainline for mach-omap2.

Tony

Re: [PATCH] Fix compile error in usb-musb.c

[David Brownell]

On Sunday 18 January 2009, Tony Lindgren wrote:
> 
> > > #if     !defined(CONFIG_ARCH_OMAP730) && \
> > >     !defined(CONFIG_ARCH_OMAP15XX) && \
> > >     !defined(CONFIG_ARCH_OMAP16XX) && \
> > >     !defined(CONFIG_ARCH_OMAP24XX) && \
> > >     !defined(CONFIG_ARCH_OMAP34XX)
> > > #error "Power management for this processor not implemented yet"
> > > #endif
> > 
> > I didn't realize anyone outside of TI had their hands
> > on OMAP4 chips yet.  :)
> 
> Might be worth looking what it would take to make dummy CONFIG_PM
> compile in mainline for mach-omap2.

This (against mainline) makes build+link work ...


---
 arch/arm/plat-omap/include/mach/pm.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/arch/arm/plat-omap/include/mach/pm.h
+++ b/arch/arm/plat-omap/include/mach/pm.h
@@ -108,7 +108,7 @@
 	!defined(CONFIG_ARCH_OMAP15XX) && \
 	!defined(CONFIG_ARCH_OMAP16XX) && \
 	!defined(CONFIG_ARCH_OMAP24XX)
-#error "Power management for this processor not implemented yet"
+#warning "Power management for this processor not implemented yet"
 #endif
 
 #ifndef __ASSEMBLER__

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Fix compile error in usb-musb.c

[Felipe Balbi]

On Mon, Jan 26, 2009 at 03:23:42PM -0800, David Brownell wrote:
> --- a/arch/arm/plat-omap/include/mach/pm.h
> +++ b/arch/arm/plat-omap/include/mach/pm.h
> @@ -108,7 +108,7 @@
>  	!defined(CONFIG_ARCH_OMAP15XX) && \
>  	!defined(CONFIG_ARCH_OMAP16XX) && \
>  	!defined(CONFIG_ARCH_OMAP24XX)
> -#error "Power management for this processor not implemented yet"
> +#warning "Power management for this processor not implemented yet"
>  #endif
>  
>  #ifndef __ASSEMBLER__

this is great as we can push usb-musb.c to mainline.

-- 
balbi

Re: [PATCH] Fix compile error in usb-musb.c

[Tony Lindgren]

* David Brownell <david-b@pacbell.net> [090126 15:23]:
> On Sunday 18 January 2009, Tony Lindgren wrote:
> > 
> > > > #if     !defined(CONFIG_ARCH_OMAP730) && \
> > > >     !defined(CONFIG_ARCH_OMAP15XX) && \
> > > >     !defined(CONFIG_ARCH_OMAP16XX) && \
> > > >     !defined(CONFIG_ARCH_OMAP24XX) && \
> > > >     !defined(CONFIG_ARCH_OMAP34XX)
> > > > #error "Power management for this processor not implemented yet"
> > > > #endif
> > > 
> > > I didn't realize anyone outside of TI had their hands
> > > on OMAP4 chips yet.  :)
> > 
> > Might be worth looking what it would take to make dummy CONFIG_PM
> > compile in mainline for mach-omap2.
> 
> This (against mainline) makes build+link work ...

I'll add it to omap-fixes. Dave, can you please reply with your SOB?

Thanks,

Tony


> ---
>  arch/arm/plat-omap/include/mach/pm.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/arch/arm/plat-omap/include/mach/pm.h
> +++ b/arch/arm/plat-omap/include/mach/pm.h
> @@ -108,7 +108,7 @@
>  	!defined(CONFIG_ARCH_OMAP15XX) && \
>  	!defined(CONFIG_ARCH_OMAP16XX) && \
>  	!defined(CONFIG_ARCH_OMAP24XX)
> -#error "Power management for this processor not implemented yet"
> +#warning "Power management for this processor not implemented yet"
>  #endif
>  
>  #ifndef __ASSEMBLER__
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Fix compile error in usb-musb.c

[David Brownell]

On Wednesday 11 February 2009, Tony Lindgren wrote:
> * David Brownell <david-b@pacbell.net> [090126 15:23]:
> > On Sunday 18 January 2009, Tony Lindgren wrote:
> > > 
> > > > > #if     !defined(CONFIG_ARCH_OMAP730) && \
> > > > >     !defined(CONFIG_ARCH_OMAP15XX) && \
> > > > >     !defined(CONFIG_ARCH_OMAP16XX) && \
> > > > >     !defined(CONFIG_ARCH_OMAP24XX) && \
> > > > >     !defined(CONFIG_ARCH_OMAP34XX)
> > > > > #error "Power management for this processor not implemented yet"
> > > > > #endif
> > > > 
> > > > I didn't realize anyone outside of TI had their hands
> > > > on OMAP4 chips yet.  :)
> > > 
> > > Might be worth looking what it would take to make dummy CONFIG_PM
> > > compile in mainline for mach-omap2.
> > 
> > This (against mainline) makes build+link work ...
> 
> I'll add it to omap-fixes. Dave, can you please reply with your SOB?

Special offer, today only ... take your pick:

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>

Sonofabitch: David Brownell <dbrownell@users.sourceforge.net>

:)


> 
> Thanks,
> 
> Tony
> 
> 
> > ---
> >  arch/arm/plat-omap/include/mach/pm.h |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > --- a/arch/arm/plat-omap/include/mach/pm.h
> > +++ b/arch/arm/plat-omap/include/mach/pm.h
> > @@ -108,7 +108,7 @@
> >  	!defined(CONFIG_ARCH_OMAP15XX) && \
> >  	!defined(CONFIG_ARCH_OMAP16XX) && \
> >  	!defined(CONFIG_ARCH_OMAP24XX)
> > -#error "Power management for this processor not implemented yet"
> > +#warning "Power management for this processor not implemented yet"
> >  #endif
> >  
> >  #ifndef __ASSEMBLER__
> > 
> 
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Fix compile error in usb-musb.c

[Tony Lindgren]

* David Brownell <david-b@pacbell.net> [090211 17:55]:
> On Wednesday 11 February 2009, Tony Lindgren wrote:
> > * David Brownell <david-b@pacbell.net> [090126 15:23]:
> > > On Sunday 18 January 2009, Tony Lindgren wrote:
> > > > 
> > > > > > #if     !defined(CONFIG_ARCH_OMAP730) && \
> > > > > >     !defined(CONFIG_ARCH_OMAP15XX) && \
> > > > > >     !defined(CONFIG_ARCH_OMAP16XX) && \
> > > > > >     !defined(CONFIG_ARCH_OMAP24XX) && \
> > > > > >     !defined(CONFIG_ARCH_OMAP34XX)
> > > > > > #error "Power management for this processor not implemented yet"
> > > > > > #endif
> > > > > 
> > > > > I didn't realize anyone outside of TI had their hands
> > > > > on OMAP4 chips yet.  :)
> > > > 
> > > > Might be worth looking what it would take to make dummy CONFIG_PM
> > > > compile in mainline for mach-omap2.
> > > 
> > > This (against mainline) makes build+link work ...
> > 
> > I'll add it to omap-fixes. Dave, can you please reply with your SOB?
> 
> Special offer, today only ... take your pick:
> 
> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
> 
> Sonofabitch: David Brownell <dbrownell@users.sourceforge.net>
> 
> :)

Thanks, I'll stick with the first one :)

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html