From: Tony Lindgren <tony@atomide.com>
To: Jarkko Nikula <jhnikula@gmail.com>
Cc: Jarkko Nikula <jarkko.nikula@nokia.com>,
"Shargorodsky Atal (EXT-Teleca/Helsinki)"
<ext-atal.shargorodsky@nokia.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH 1/1] Allow I2C_OMAP to compile as a module.
Date: Mon, 16 Feb 2009 15:09:35 -0800 [thread overview]
Message-ID: <20090216230935.GN7562@atomide.com> (raw)
In-Reply-To: <20090215214501.c7386464.jhnikula@gmail.com>
* Jarkko Nikula <jhnikula@gmail.com> [090215 11:44]:
> On Sun, 15 Feb 2009 21:35:59 +0200
> Jarkko Nikula <jhnikula@gmail.com> wrote:
>
> > Tony's version does not fix the issue since obj-$(CONFIG_I2C_OMAP)
> > below still tries to compile arch/arm/plat-omap/i2c.c as a module.
> >
> > -obj-$(CONFIG_I2C_OMAP) += i2c.o
> > +
> > +ifneq ($(CONFIG_I2C_OMAP),)
> > + obj-$(CONFIG_I2C_OMAP) += i2c.o
> > +endif
> >
> And build works if obj-y rule is used instead
>
> -obj-$(CONFIG_I2C_OMAP) += i2c.o
> +
> +ifneq ($(CONFIG_I2C_OMAP),)
> + obj-y += i2c.o
> +endif
>
> Good. Patch can be made to touch only single file and add only three new
> lines.
Ah sorry for the typo :)
Tony
next prev parent reply other threads:[~2009-02-16 23:09 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-12 14:10 [PATCH 1/1] Allow I2C_OMAP to compile as a module Atal Shargorodsky
2009-02-13 6:58 ` Jarkko Nikula
2009-02-13 22:21 ` Tony Lindgren
2009-02-15 19:35 ` Jarkko Nikula
2009-02-15 19:45 ` Jarkko Nikula
2009-02-16 16:40 ` Aaro Koskinen
2009-02-16 23:09 ` Tony Lindgren
2009-02-17 9:25 ` Jarkko Nikula
2009-02-17 23:50 ` Tony Lindgren
2009-02-17 23:59 ` Otto Solares
2009-02-18 0:07 ` Tony Lindgren
2009-02-18 9:22 ` [PATCH] ARM: OMAP: Allow I2C bus driver to be compiled " Aaro Koskinen
2009-02-18 9:45 ` Jarkko Nikula
2009-02-18 23:40 ` Tony Lindgren
2009-02-18 23:43 ` Otto Solares
2009-02-18 23:59 ` Tony Lindgren
2009-02-19 0:15 ` Otto Solares
2009-02-16 23:09 ` Tony Lindgren [this message]
2009-02-15 20:47 ` [PATCH 1/1] Allow I2C_OMAP to compile " Felipe Balbi
-- strict thread matches above, loose matches on Subject: below --
2009-02-12 12:54 Atal Shargorodsky
2009-02-12 13:10 ` Jarkko Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090216230935.GN7562@atomide.com \
--to=tony@atomide.com \
--cc=ext-atal.shargorodsky@nokia.com \
--cc=jarkko.nikula@nokia.com \
--cc=jhnikula@gmail.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox