public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Jarkko Nikula <jhnikula@gmail.com>
Cc: Aaro Koskinen <aaro.koskinen@nokia.com>,
	"Nikula Jarkko (Nokia-D/Helsinki)" <jarkko.nikula@nokia.com>,
	"Shargorodsky Atal (EXT-Teleca/Helsinki)"
	<ext-atal.shargorodsky@nokia.com>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH 1/1] Allow I2C_OMAP to compile as a module.
Date: Tue, 17 Feb 2009 15:50:18 -0800	[thread overview]
Message-ID: <20090217235018.GF11928@atomide.com> (raw)
In-Reply-To: <20090217112513.303d62e6.jhnikula@gmail.com>

* Jarkko Nikula <jhnikula@gmail.com> [090217 01:22]:
> On Mon, 16 Feb 2009 18:40:12 +0200
> Aaro Koskinen <aaro.koskinen@nokia.com> wrote:
> 
> > Taking example from fs/Makefile (nfsd):
> > 
> > -obj-$(CONFIG_I2C_OMAP) += i2c.o
> > +i2c-omap-$(CONFIG_I2C_OMAP) := i2c.o
> > +obj-y += $(i2c-omap-m) $(i2c-omap-y)
> > 
> This is getting shorter and shorter :-)
> 
> > Also arch/arm/plat-omap/include/mach/common.h should be updated to
> > check for CONFIG_I2C_OMAP_MODULE.
> > 
> Good catch, that's true!

Aaro, can you please send a proper patch with Signed-off-by and I'll
add it to omap-fixes?

Thanks

Tony

  reply	other threads:[~2009-02-17 23:50 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-12 14:10 [PATCH 1/1] Allow I2C_OMAP to compile as a module Atal Shargorodsky
2009-02-13  6:58 ` Jarkko Nikula
2009-02-13 22:21   ` Tony Lindgren
2009-02-15 19:35     ` Jarkko Nikula
2009-02-15 19:45       ` Jarkko Nikula
2009-02-16 16:40         ` Aaro Koskinen
2009-02-16 23:09           ` Tony Lindgren
2009-02-17  9:25           ` Jarkko Nikula
2009-02-17 23:50             ` Tony Lindgren [this message]
2009-02-17 23:59               ` Otto Solares
2009-02-18  0:07                 ` Tony Lindgren
2009-02-18  9:22               ` [PATCH] ARM: OMAP: Allow I2C bus driver to be compiled " Aaro Koskinen
2009-02-18  9:45                 ` Jarkko Nikula
2009-02-18 23:40                   ` Tony Lindgren
2009-02-18 23:43                     ` Otto Solares
2009-02-18 23:59                       ` Tony Lindgren
2009-02-19  0:15                         ` Otto Solares
2009-02-16 23:09         ` [PATCH 1/1] Allow I2C_OMAP to compile " Tony Lindgren
2009-02-15 20:47       ` Felipe Balbi
  -- strict thread matches above, loose matches on Subject: below --
2009-02-12 12:54 Atal Shargorodsky
2009-02-12 13:10 ` Jarkko Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090217235018.GF11928@atomide.com \
    --to=tony@atomide.com \
    --cc=aaro.koskinen@nokia.com \
    --cc=ext-atal.shargorodsky@nokia.com \
    --cc=jarkko.nikula@nokia.com \
    --cc=jhnikula@gmail.com \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox