Re: [PATCH 2/2] OMAP: tsc2005: Change state machine to be more stable.

[Tony Lindgren <tony@atomide.com>]

* Trilok Soni <soni.trilok@gmail.com> [090217 09:44]:
> Hi Phil,
> 
> >        r = request_irq(ts->spi->irq, tsc2005_ts_irq_handler,
> > -                       IRQF_TRIGGER_FALLING | IRQF_DISABLED |
> > -                       IRQF_SAMPLE_RANDOM, "tsc2005", ts);
> > +                       (((TSC2005_CFR2_INITVALUE & TSC2005_CFR2_IRQ_MASK) ==
> > +                         TSC2005_CFR2_IRQ_PENDAV)
> > +                        ? IRQF_TRIGGER_RISING
> > +                        : IRQF_TRIGGER_FALLING) |
> > +                       IRQF_DISABLED | IRQF_SAMPLE_RANDOM, "tsc2005", ts);
> 
> No need to IRQF_SAMPLE_RANDOM, as it is already handled by input
> subsystem. Please check input_report_event.
> 
> I had submitted earlier version of tsc2005.c to mainline, and we have
> got couple of comments, I can see that you have fixed simple_strtoul
> return related problem in sysfs in the first patch. I will send you
> that thread link tomorrow.

Yeah let's plan on resetting l-o tree drivers/input/touchscreen at
some point soon to mainline. Those driver patches should be discussed
on the input list with l-o list cc'd.

Regards,

Tony