From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH] ARM: OMAP: Allow I2C bus driver to be compiled as a module Date: Wed, 18 Feb 2009 15:59:56 -0800 Message-ID: <20090218235956.GC31436@atomide.com> References: <20090217235018.GF11928@atomide.com> <1234948938-6979-1-git-send-email-Aaro.Koskinen@nokia.com> <20090218114525.cb95391f.jhnikula@gmail.com> <20090218234029.GB31436@atomide.com> <20090218234327.GM24800@guug.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-01-bos.mailhop.org ([63.208.196.178]:63108 "EHLO mho-01-bos.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752093AbZBSAAC (ORCPT ); Wed, 18 Feb 2009 19:00:02 -0500 Content-Disposition: inline In-Reply-To: <20090218234327.GM24800@guug.org> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Otto Solares Cc: linux-omap@vger.kernel.org * Otto Solares [090218 15:43]: > On Wed, Feb 18, 2009 at 03:40:29PM -0800, Tony Lindgren wrote: > > * Jarkko Nikula [090218 01:42]: > > > On Wed, 18 Feb 2009 11:22:18 +0200 > > > Aaro Koskinen wrote: > > > > > > > Fixes a linker error when OMAP I2C bus driver is compiled as a module: > > > > > > > > ERROR: "i2c_register_board_info" [arch/arm/plat-omap/i2c.ko] > > > > undefined! > > > > > > > > The I2C utility functions used for board initialization should be > > > > always built-in. > > > > > > > > Signed-off-by: Aaro Koskinen > > > > --- > > > > arch/arm/plat-omap/Makefile | 3 ++- > > > > arch/arm/plat-omap/include/mach/common.h | 2 +- > > > > 2 files changed, 3 insertions(+), 2 deletions(-) > > > > > > > Acked-by: Jarkko Nikula > > > > Applying to linux-omap and omap-fixes. > > Just curious: what about omap-2.6.28? Heh, OK pushed there too :) I think we should close that branch soon as 2.6.29 is fast approaching.. Tony