From: David Brownell <david-b@pacbell.net>
To: Kim Kyuwon <chammoru@gmail.com>
Cc: linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
drzeus-mmc@drzeus.cx, 김규원 <q1.kim@samsung.com>,
박경민 <kyungmin.park@samsung.com>
Subject: Re: [PATCH] OMAP: HSMMC: Initialize hsmmc controller registers when resuming
Date: Fri, 20 Feb 2009 13:11:43 -0800 [thread overview]
Message-ID: <200902201311.44056.david-b@pacbell.net> (raw)
In-Reply-To: <4d34a0a70902200400s252f48ddvfd6e0d83e91fa291@mail.gmail.com>
On Friday 20 February 2009, Kim Kyuwon wrote:
> +static void omap_hsmmc_init(struct mmc_omap_host *host)
> +{
> + u32 hctl, capa, value;
> +
> + /* Only MMC1 supports 3.0V */
> + if (host->id == OMAP_MMC1_DEVID) {
> + hctl = SDVS30;
Shouldn't it be remembering what voltage it was using,
and then restore that, instead of always making MMC1
restart at a 3.0V level? That's pretty awkward to test
unless you have a 1.8V-capable card in MMC1...
Somewhat related: I think the PBIAS register updates
should be moved out of mach-omap2/mmc-twl4030.c into
this driver. They're needed no matter what flavor
regulator is used to with MMC1 voltage over 1.8V,
and it's a bit odd to split the state machine for
1.8V -vs- 3.0V I/O voltages the way it's now done.
- Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-02-20 21:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-20 12:00 [PATCH] OMAP: HSMMC: Initialize hsmmc controller registers when resuming Kim Kyuwon
2009-02-20 21:11 ` David Brownell [this message]
2009-02-23 5:41 ` Kim Kyuwon
2009-02-23 8:04 ` Adrian Hunter
2009-02-23 12:26 ` Kyungmin Park
2009-02-23 13:47 ` Adrian Hunter
2009-02-23 18:23 ` David Brownell
2009-02-24 13:01 ` Adrian Hunter
2009-02-24 22:10 ` David Brownell
2009-02-27 22:08 ` Tony Lindgren
2009-03-02 12:27 ` Adrian Hunter
2009-03-02 16:44 ` Tony Lindgren
2009-03-02 21:23 ` Pierre Ossman
2009-02-24 22:12 ` David Brownell
2009-02-23 18:30 ` David Brownell
2009-03-11 3:33 ` David Brownell
2009-03-11 6:50 ` Pierre Ossman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200902201311.44056.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=chammoru@gmail.com \
--cc=drzeus-mmc@drzeus.cx \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=q1.kim@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox