Re: [PATCH] usb: musb: adding support for registering nop xceiv

[Tony Lindgren <tony@atomide.com>]

* Gupta, Ajay Kumar <ajay.gupta@ti.com> [090119 02:39]:
> > -----Original Message-----
> > From: Felipe Balbi [mailto:me@felipebalbi.com]
> > Sent: Tuesday, January 13, 2009 4:00 AM
> > To: Gupta, Ajay Kumar
> > Cc: linux-omap@vger.kernel.org; david-b@pacbell.net; felipe.balbi@nokia.com
> > Subject: Re: [PATCH] usb: musb: adding support for registering nop xceiv
> > 
> > On Thu, Jan 08, 2009 at 04:23:56PM +0530, Ajay Kumar Gupta wrote:
> > > Adding support for registering nop usb transceiver for musb
> > > platforms. Tested with OMAP35xx EVM having OTG phy ISP1504
> > > which is autonomous and doesn't require any phy programming.
> > >
> > > Signed-off-by: Ajay Kumar Gupta <ajay.gupta@ti.com>
> > 
> > Tony, if Dave is ok with the nop-xceiv, we can apply this to l-o and
> > people who doesn't use twl4030/tlw5030 xceiv will have to select this
> > driver.
> 
> Hi David,
> 
> Please review this one too.

According to Felipe this is in Greg's queue, so I'll apply this to
linux-omap to wait for it to fall down from mainline.

Tony

> 
> Regards,
> Ajay
> 
> > 
> > > ---
> > >  arch/arm/mach-omap2/usb-musb.c |   19 +++++++++++++++++++
> > >  1 files changed, 19 insertions(+), 0 deletions(-)
> > >
> > > diff --git a/arch/arm/mach-omap2/usb-musb.c b/arch/arm/mach-omap2/usb-musb.c
> > > index 61c5709..c202256 100644
> > > --- a/arch/arm/mach-omap2/usb-musb.c
> > > +++ b/arch/arm/mach-omap2/usb-musb.c
> > > @@ -155,10 +155,29 @@ static struct platform_device musb_device = {
> > >  };
> > >  #endif
> > >
> > > +#ifdef CONFIG_NOP_USB_XCEIV
> > > +static u64 nop_xceiv_dmamask = DMA_32BIT_MASK;
> > > +
> > > +static struct platform_device nop_xceiv_device = {
> > > +	.name		= "nop_usb_xceiv",
> > > +	.id		= -1,
> > > +	.dev = {
> > > +		.dma_mask		= &nop_xceiv_dmamask,
> > > +		.coherent_dma_mask	= DMA_32BIT_MASK,
> > > +		.platform_data		= NULL,
> > > +	},
> > > +};
> > > +#endif
> > >
> > >  void __init usb_musb_init(void)
> > >  {
> > >  #ifdef CONFIG_USB_MUSB_SOC
> > > +#ifdef CONFIG_NOP_USB_XCEIV
> > > +	if (platform_device_register(&nop_xceiv_device) < 0) {
> > > +		printk(KERN_ERR "Unable to register NOP-XCEIV device\n");
> > > +		return;
> > > +	}
> > > +#endif
> > >  	if (platform_device_register(&musb_device) < 0) {
> > >  		printk(KERN_ERR "Unable to register HS-USB (MUSB) device\n");
> > >  		return;
> > > --
> > > 1.5.6
> > >
> > > --
> > > To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> > > the body of a message to majordomo@vger.kernel.org
> > > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > 
> > --
> > balbi
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html