Re: [rft/rfc/patch-v2.6.29-rc5+ 21/23] usb: host: ehci: don't ensure register write

[Felipe Balbi <me@felipebalbi.com>]

On Mon, Feb 23, 2009 at 08:55:33PM +0200, Felipe Balbi wrote:
> +#include "../../../arch/arm/mach-omap2/cm-regbits-34xx.h"
> +
>  /* omap_start_ehc
>   *	- Start the TI USBHOST controller
>   */
> @@ -274,32 +258,11 @@ static int omap_start_ehc(struct ehci_hcd_omap *omap, struct usb_hcd *hcd)
>  			PLL_MOD, OMAP3430ES2_CM_CLKEN2);
>  
>  	while (!(cm_read_mod_reg(PLL_MOD, CM_IDLEST2) &
> -				OMAP3430ES2_ST_PERIPH2_CLK_MASK)) {
> +				OMAP3430ES2_ST_PERIPH2_CLK_MASK))
>  		dev_dbg(omap->dev, "idlest2 = 0x%x\n",
>  			cm_read_mod_reg(PLL_MOD, CM_IDLEST2));
> -
> -		if (time_after(timeout, jiffies)) {
> -			dev_dbg(omap->dev, "operation timed out\n");
> -			ret = -EINVAL;
> -			goto err_idlest2;
> -		}
> -	}
>  	/* End DPLL5 programming */

Hi Paul, could you look at how could we move dpll5 programming to clk
fw? This driver shouldn't have such code. Also, I guess this programming
is not right since I hear this driver doesn't enumerate anything.

-- 
balbi