Re: [PATCH 07/13] ARM: OMAP: No need to include board-omap2430sdp.h from hardware.h

[Felipe Balbi <me@felipebalbi.com>]

Nothing to do with this patch in particular, but...

On Thu, Feb 26, 2009 at 04:01:15PM -0800, Tony Lindgren wrote:
> @@ -102,8 +105,8 @@ static struct resource sdp2430_smc91x_resources[] = {
>  		.flags	= IORESOURCE_MEM,
>  	},
>  	[1] = {
> -		.start	= OMAP_GPIO_IRQ(OMAP24XX_ETHR_GPIO_IRQ),
> -		.end	= OMAP_GPIO_IRQ(OMAP24XX_ETHR_GPIO_IRQ),
> +		.start	= OMAP_GPIO_IRQ(SDP2430_ETHR_GPIO_IRQ),
> +		.end	= OMAP_GPIO_IRQ(SDP2430_ETHR_GPIO_IRQ),
>  		.flags	= IORESOURCE_IRQ | IORESOURCE_IRQ_LOWLEVEL,

normally we only pass start and this should probably be using
gpio_to_irq(), but for that...

>  	},
>  };
> @@ -170,13 +173,13 @@ static inline void __init sdp2430_init_smc91x(void)
>  	sdp2430_smc91x_resources[0].end = cs_mem_base + 0x30f;
>  	udelay(100);
>  
> -	if (gpio_request(OMAP24XX_ETHR_GPIO_IRQ, "SMC91x irq") < 0) {
> +	if (gpio_request(SDP2430_ETHR_GPIO_IRQ, "SMC91x irq") < 0) {
>  		printk(KERN_ERR "Failed to request GPIO%d for smc91x IRQ\n",
> -			OMAP24XX_ETHR_GPIO_IRQ);
> +			SDP2430_ETHR_GPIO_IRQ);
>  		gpmc_cs_free(eth_cs);
>  		goto out;
>  	}
> -	gpio_direction_input(OMAP24XX_ETHR_GPIO_IRQ);
> +	gpio_direction_input(SDP2430_ETHR_GPIO_IRQ);

we should probably add:

sdp2430_scm91x_resources[1].start = gpio_to_irq(OMAP24XX_ETHER_GPIO_IRQ);

here

-- 
balbi