From: David Brownell <david-b@pacbell.net>
To: Tony Lindgren <tony@atomide.com>
Cc: Kim Kyuwon <chammoru@gmail.com>, OMAP <linux-omap@vger.kernel.org>
Subject: Re: Suggestion regarding the ordering of GPIO MUX configurations
Date: Mon, 2 Mar 2009 11:41:33 -0800 [thread overview]
Message-ID: <200903021141.33650.david-b@pacbell.net> (raw)
In-Reply-To: <20090302164008.GA11864@atomide.com>
On Monday 02 March 2009, Tony Lindgren wrote:
>
> > I wonder if we can sort the order of GPIO MUX configurations and then
> > insert new MUXs at right position. Can I ask your opinions?
>
> Yes, I was thinking about the same. I'll combine the pending mux patches
> and merge them into a single patch for mainline tree. While doing that
> I'll sort them by gpio number. Will post the patch here for testing
> probably today.
Another thing to consider is eliminating the bugs that can
come from having the mux.c MUX_CFG_*() entries not match the
mux.h order; accidents happen. The simplest fix changes
MUX_CFG_X("string", ...)
==> {
.name = string,
...
},
to MUX_CFG_X(enum, ...)
==> [enum] = {
.name = #enum,
...
},
and adds a smidgeon of logic to verify a given mux table entry
has been initialized before using it.
- Dave
prev parent reply other threads:[~2009-03-02 19:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-02 2:37 Suggestion regarding the ordering of GPIO MUX configurations Kim Kyuwon
2009-03-02 16:40 ` Tony Lindgren
2009-03-02 17:31 ` Peter Barada
2009-03-02 17:47 ` Tony Lindgren
2009-03-02 19:41 ` David Brownell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200903021141.33650.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=chammoru@gmail.com \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox