From: David Brownell <david-b@pacbell.net>
To: Adrian Hunter <adrian.hunter@nokia.com>
Cc: Tony Lindgren <tony@atomide.com>,
Jarkko Lavinen <jarkko.lavinen@nokia.com>,
linux-omap Mailing List <linux-omap@vger.kernel.org>
Subject: Re: [PATCH 1/6] OMAP: mmc-twl4030 fix name buffer length
Date: Tue, 10 Mar 2009 09:28:25 -0800 [thread overview]
Message-ID: <200903101028.25844.david-b@pacbell.net> (raw)
In-Reply-To: <20090310093302.16889.4535.sendpatchset@ahunter-laptop>
On Tuesday 10 March 2009, Adrian Hunter wrote:
> >From 60238a3a80b5be3e1843a049b39eabf729c315aa Mon Sep 17 00:00:00 2001
> From: Adrian Hunter <adrian.hunter@nokia.com>
> Date: Thu, 22 Jan 2009 17:58:04 +0200
> Subject: [PATCH] OMAP: mmc-twl4030 fix name buffer length
>
> Add 1 to buffer length for null terminator.
>
> Signed-off-by: Adrian Hunter <adrian.hunter@nokia.com>
Acked-by: David Brownell <dbrownell@users.sourceforge.net>
An endless off-by-one bug ...
> ---
> arch/arm/mach-omap2/mmc-twl4030.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/mmc-twl4030.c b/arch/arm/mach-omap2/mmc-twl4030.c
> index 33e5b9b..aeaab5a 100644
> --- a/arch/arm/mach-omap2/mmc-twl4030.c
> +++ b/arch/arm/mach-omap2/mmc-twl4030.c
> @@ -61,7 +61,7 @@ static struct twl_mmc_controller {
> struct omap_mmc_platform_data *mmc;
> u8 twl_vmmc_dev_grp;
> u8 twl_mmc_dedicated;
> - char name[HSMMC_NAME_LEN];
> + char name[HSMMC_NAME_LEN + 1];
> } hsmmc[OMAP34XX_NR_MMC] = {
> {
> .twl_vmmc_dev_grp = VMMC1_DEV_GRP,
> --
> 1.5.6.3
>
>
next prev parent reply other threads:[~2009-03-10 17:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-10 9:32 [PATCH 0/6] mmc-twl4030 patches for RX51 Adrian Hunter
2009-03-10 9:33 ` [PATCH 1/6] OMAP: mmc-twl4030 fix name buffer length Adrian Hunter
2009-03-10 17:28 ` David Brownell [this message]
2009-03-10 19:17 ` [APPLIED] <span class="quote">> [PATCH] OMAP: mmc-twl4030 fix name buffer length</span> Tony Lindgren
2009-03-10 9:33 ` [PATCH 2/6] OMAP: mmc-twl4030 support VSIM is VMMC2_IO Adrian Hunter
2009-03-10 17:46 ` David Brownell
2009-03-10 9:33 ` [PATCH 3/6] OMAP: mmc-twl4030 add cover switch Adrian Hunter
2009-03-10 17:50 ` David Brownell
2009-03-10 19:29 ` Tony Lindgren
2009-03-10 9:33 ` [PATCH 4/6] OMAP: mmc-twl4030 allow arbitrary slot names Adrian Hunter
2009-03-10 17:56 ` David Brownell
2009-03-10 19:22 ` [APPLIED] <span class="quote">> [PATCH] OMAP: mmc-twl4030 allow arbitrary slot names</span> Tony Lindgren
2009-03-10 9:33 ` [PATCH 6/6] OMAP: mmc-twl4030: Add VAUX3 support Adrian Hunter
[not found] ` <20090310093329.16889.76098.sendpatchset@ahunter-laptop>
2009-03-10 17:58 ` [PATCH 5/6] RX51: adjust hsmmc info David Brownell
2009-03-10 19:30 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200903101028.25844.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=adrian.hunter@nokia.com \
--cc=jarkko.lavinen@nokia.com \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox